* [PATCH -next] scsi: dc395x: use module_pci_driver to simplify the code
@ 2020-09-17 7:10 Liu Shixin
2020-10-07 3:05 ` Martin K. Petersen
2020-10-13 22:42 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Liu Shixin @ 2020-09-17 7:10 UTC (permalink / raw)
To: Oliver Neukum, Ali Akcaagac, Jamie Lenehan, James E.J. Bottomley,
Martin K. Petersen
Cc: dc395x, linux-scsi, linux-kernel, Liu Shixin
Use the module_pci_driver() macro to make the code simpler
by eliminating module_init and module_exit calls.
Signed-off-by: Liu Shixin <liushixin2@huawei.com>
---
drivers/scsi/dc395x.c | 25 +------------------------
1 file changed, 1 insertion(+), 24 deletions(-)
diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
index 0c251a3b99b7..fa16894d8758 100644
--- a/drivers/scsi/dc395x.c
+++ b/drivers/scsi/dc395x.c
@@ -4721,30 +4721,7 @@ static struct pci_driver dc395x_driver = {
.probe = dc395x_init_one,
.remove = dc395x_remove_one,
};
-
-
-/**
- * dc395x_module_init - Module initialization function
- *
- * Used by both module and built-in driver to initialise this driver.
- **/
-static int __init dc395x_module_init(void)
-{
- return pci_register_driver(&dc395x_driver);
-}
-
-
-/**
- * dc395x_module_exit - Module cleanup function.
- **/
-static void __exit dc395x_module_exit(void)
-{
- pci_unregister_driver(&dc395x_driver);
-}
-
-
-module_init(dc395x_module_init);
-module_exit(dc395x_module_exit);
+module_pci_driver(dc395x_driver);
MODULE_AUTHOR("C.L. Huang / Erich Chen / Kurt Garloff");
MODULE_DESCRIPTION("SCSI host adapter driver for Tekram TRM-S1040 based adapters: Tekram DC395 and DC315 series");
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] scsi: dc395x: use module_pci_driver to simplify the code
2020-09-17 7:10 [PATCH -next] scsi: dc395x: use module_pci_driver to simplify the code Liu Shixin
@ 2020-10-07 3:05 ` Martin K. Petersen
2020-10-13 22:42 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-10-07 3:05 UTC (permalink / raw)
To: Liu Shixin
Cc: Oliver Neukum, Ali Akcaagac, Jamie Lenehan, James E.J. Bottomley,
Martin K. Petersen, dc395x, linux-scsi, linux-kernel
Liu,
> Use the module_pci_driver() macro to make the code simpler by
> eliminating module_init and module_exit calls.
Applied to 5.10/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] scsi: dc395x: use module_pci_driver to simplify the code
2020-09-17 7:10 [PATCH -next] scsi: dc395x: use module_pci_driver to simplify the code Liu Shixin
2020-10-07 3:05 ` Martin K. Petersen
@ 2020-10-13 22:42 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-10-13 22:42 UTC (permalink / raw)
To: Ali Akcaagac, Liu Shixin, Jamie Lenehan, Oliver Neukum,
James E.J. Bottomley
Cc: Martin K . Petersen, dc395x, linux-kernel, linux-scsi
On Thu, 17 Sep 2020 15:10:44 +0800, Liu Shixin wrote:
> Use the module_pci_driver() macro to make the code simpler
> by eliminating module_init and module_exit calls.
Applied to 5.10/scsi-queue, thanks!
[1/1] scsi: dc395x: Use module_pci_driver() to simplify the code
https://git.kernel.org/mkp/scsi/c/75c31c80a77d
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-13 22:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-17 7:10 [PATCH -next] scsi: dc395x: use module_pci_driver to simplify the code Liu Shixin
2020-10-07 3:05 ` Martin K. Petersen
2020-10-13 22:42 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).