From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753281AbdATUKC (ORCPT ); Fri, 20 Jan 2017 15:10:02 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:50144 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753240AbdATUKB (ORCPT ); Fri, 20 Jan 2017 15:10:01 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 20 Jan 2017 12:10:00 -0800 From: Subhash Jadavani To: Bjorn Andersson Cc: Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Vivek Gautam Subject: Re: [PATCH 1/4] phy: qcom-ufs: Don't kfree devres resource In-Reply-To: <20170119104739.4376-1-bjorn.andersson@linaro.org> References: <20170119104739.4376-1-bjorn.andersson@linaro.org> Message-ID: <16029f0d74037f0c8023a0d562593556@codeaurora.org> User-Agent: Roundcube Webmail/1.2.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-01-19 02:47, Bjorn Andersson wrote: > Upon failing to acquire regulator supplies the qcom-ufs driver calls > kfree() on the devm allocated memory used to store the name of the > regulator, leading to devres corruption. > > Rather than switching to using the appropriate free function the patch > acknowledge the fact that "name" is always a constant string and we > don't actually need to create a local copy of it, but rather just > reference the constant string. > > Cc: Subhash Jadavani > Cc: Vivek Gautam > Signed-off-by: Bjorn Andersson > --- > drivers/phy/phy-qcom-ufs.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/drivers/phy/phy-qcom-ufs.c b/drivers/phy/phy-qcom-ufs.c > index c69568b8543d..4d7f3c018223 100644 > --- a/drivers/phy/phy-qcom-ufs.c > +++ b/drivers/phy/phy-qcom-ufs.c > @@ -217,12 +217,7 @@ static int __ufs_qcom_phy_init_vreg(struct device > *dev, > > char prop_name[MAX_PROP_NAME]; > > - vreg->name = devm_kstrdup(dev, name, GFP_KERNEL); > - if (!vreg->name) { > - err = -ENOMEM; > - goto out; > - } > - > + vreg->name = name; > vreg->reg = devm_regulator_get(dev, name); > if (IS_ERR(vreg->reg)) { > err = PTR_ERR(vreg->reg); > @@ -265,8 +260,6 @@ static int __ufs_qcom_phy_init_vreg(struct device > *dev, > } > > out: > - if (err) > - kfree(vreg->name); > return err; > } Looks good to me. Reviewed-by: Subhash Jadavani -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project