From: Sumit Garg <sumit.garg@linaro.org>
To: maz@kernel.org, catalin.marinas@arm.com, will@kernel.org
Cc: linux-arm-kernel@lists.infradead.org, tglx@linutronix.de,
jason@lakedaemon.net, linux@armlinux.org.uk,
tsbogend@alpha.franken.de, mpe@ellerman.id.au,
davem@davemloft.net, mingo@redhat.com, bp@alien8.de,
x86@kernel.org, mark.rutland@arm.com,
julien.thierry.kdev@gmail.com, dianders@chromium.org,
daniel.thompson@linaro.org, jason.wessel@windriver.com,
msys.mizuma@gmail.com, ito-yuichi@fujitsu.com,
kgdb-bugreport@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Sumit Garg <sumit.garg@linaro.org>
Subject: [PATCH v6 6/7] kgdb: roundup: Allow runtime arch specific override
Date: Thu, 29 Oct 2020 20:26:26 +0530 [thread overview]
Message-ID: <1603983387-8738-7-git-send-email-sumit.garg@linaro.org> (raw)
In-Reply-To: <1603983387-8738-1-git-send-email-sumit.garg@linaro.org>
Add a new API kgdb_arch_roundup_cpus() for a particular archichecture to
override default kgdb roundup and if it detects at runtime to not support
NMI roundup then it can fallback to default implementation using async
SMP cross-calls.
Currently such an architecture example is arm64 supporting pseudo NMIs
feature which is only available on platforms which have support for GICv3
or later version.
Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
---
arch/powerpc/kernel/kgdb.c | 3 ++-
arch/sparc/kernel/smp_64.c | 3 ++-
arch/x86/kernel/kgdb.c | 6 ++++--
include/linux/kgdb.h | 5 +++--
kernel/debug/debug_core.c | 10 +++++++++-
5 files changed, 20 insertions(+), 7 deletions(-)
diff --git a/arch/powerpc/kernel/kgdb.c b/arch/powerpc/kernel/kgdb.c
index 4090802..126575d 100644
--- a/arch/powerpc/kernel/kgdb.c
+++ b/arch/powerpc/kernel/kgdb.c
@@ -125,9 +125,10 @@ static int kgdb_debugger_ipi(struct pt_regs *regs)
}
#ifdef CONFIG_SMP
-void kgdb_roundup_cpus(void)
+bool kgdb_arch_roundup_cpus(void)
{
smp_send_debugger_break();
+ return true;
}
#endif
diff --git a/arch/sparc/kernel/smp_64.c b/arch/sparc/kernel/smp_64.c
index e38d8bf..c459c83 100644
--- a/arch/sparc/kernel/smp_64.c
+++ b/arch/sparc/kernel/smp_64.c
@@ -1014,9 +1014,10 @@ void flush_dcache_page_all(struct mm_struct *mm, struct page *page)
}
#ifdef CONFIG_KGDB
-void kgdb_roundup_cpus(void)
+bool kgdb_arch_roundup_cpus(void)
{
smp_cross_call(&xcall_kgdb_capture, 0, 0, 0);
+ return true;
}
#endif
diff --git a/arch/x86/kernel/kgdb.c b/arch/x86/kernel/kgdb.c
index ff7878d..1b756d9 100644
--- a/arch/x86/kernel/kgdb.c
+++ b/arch/x86/kernel/kgdb.c
@@ -404,7 +404,8 @@ static void kgdb_disable_hw_debug(struct pt_regs *regs)
#ifdef CONFIG_SMP
/**
- * kgdb_roundup_cpus - Get other CPUs into a holding pattern
+ * kgdb_arch_roundup_cpus - Get other CPUs into a holding pattern
+ * in an architectural specific manner
*
* On SMP systems, we need to get the attention of the other CPUs
* and get them be in a known state. This should do what is needed
@@ -414,9 +415,10 @@ static void kgdb_disable_hw_debug(struct pt_regs *regs)
*
* On non-SMP systems, this is not called.
*/
-void kgdb_roundup_cpus(void)
+bool kgdb_arch_roundup_cpus(void)
{
apic_send_IPI_allbutself(NMI_VECTOR);
+ return true;
}
#endif
diff --git a/include/linux/kgdb.h b/include/linux/kgdb.h
index 0d6cf64..f9db5b8 100644
--- a/include/linux/kgdb.h
+++ b/include/linux/kgdb.h
@@ -200,7 +200,8 @@ kgdb_arch_handle_qxfer_pkt(char *remcom_in_buffer,
extern void kgdb_call_nmi_hook(void *ignored);
/**
- * kgdb_roundup_cpus - Get other CPUs into a holding pattern
+ * kgdb_arch_roundup_cpus - Get other CPUs into a holding pattern
+ * in an architectural specific manner
*
* On SMP systems, we need to get the attention of the other CPUs
* and get them into a known state. This should do what is needed
@@ -210,7 +211,7 @@ extern void kgdb_call_nmi_hook(void *ignored);
*
* On non-SMP systems, this is not called.
*/
-extern void kgdb_roundup_cpus(void);
+extern bool kgdb_arch_roundup_cpus(void);
/**
* kgdb_arch_set_pc - Generic call back to the program counter
diff --git a/kernel/debug/debug_core.c b/kernel/debug/debug_core.c
index 1e75a89..27e401c 100644
--- a/kernel/debug/debug_core.c
+++ b/kernel/debug/debug_core.c
@@ -241,13 +241,21 @@ void __weak kgdb_call_nmi_hook(void *ignored)
}
NOKPROBE_SYMBOL(kgdb_call_nmi_hook);
-void __weak kgdb_roundup_cpus(void)
+bool __weak kgdb_arch_roundup_cpus(void)
+{
+ return false;
+}
+
+static void kgdb_roundup_cpus(void)
{
call_single_data_t *csd;
int this_cpu = raw_smp_processor_id();
int cpu;
int ret;
+ if (kgdb_arch_roundup_cpus())
+ return;
+
for_each_online_cpu(cpu) {
/* No need to roundup ourselves */
if (cpu == this_cpu)
--
2.7.4
next prev parent reply other threads:[~2020-10-29 14:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 14:56 [PATCH v6 0/7] arm64: Add framework to turn an IPI as NMI Sumit Garg
2020-10-29 14:56 ` [PATCH v6 1/7] arm64: Add framework to turn " Sumit Garg
2020-10-29 14:56 ` [PATCH v6 2/7] irqchip/gic-v3: Enable support for SGIs to act as NMIs Sumit Garg
2020-10-29 14:56 ` [PATCH v6 3/7] arm64: smp: Assign and setup an IPI as NMI Sumit Garg
2020-10-29 14:56 ` [PATCH v6 4/7] nmi: backtrace: Allow runtime arch specific override Sumit Garg
2020-10-29 14:56 ` [PATCH v6 5/7] arm64: ipi_nmi: Add support for NMI backtrace Sumit Garg
2020-10-29 14:56 ` Sumit Garg [this message]
2020-10-29 15:21 ` [PATCH v6 6/7] kgdb: roundup: Allow runtime arch specific override Daniel Thompson
2020-11-02 6:18 ` Sumit Garg
2020-11-02 9:19 ` Daniel Thompson
2020-10-29 14:56 ` [PATCH v6 7/7] arm64: kgdb: Roundup cpus using IPI as NMI Sumit Garg
2020-10-29 16:22 ` Daniel Thompson
2020-10-29 16:39 ` Daniel Thompson
2020-11-02 6:59 ` Sumit Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1603983387-8738-7-git-send-email-sumit.garg@linaro.org \
--to=sumit.garg@linaro.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=daniel.thompson@linaro.org \
--cc=davem@davemloft.net \
--cc=dianders@chromium.org \
--cc=ito-yuichi@fujitsu.com \
--cc=jason.wessel@windriver.com \
--cc=jason@lakedaemon.net \
--cc=julien.thierry.kdev@gmail.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=msys.mizuma@gmail.com \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).