From: Stephen Boyd <swboyd@chromium.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
Neil Armstrong <narmstrong@baylibre.com>,
LKML <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Sean Paul <seanpaul@chromium.org>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH 4/4] drm/bridge: ti-sn65dsi86: Update reply on aux failures
Date: Thu, 29 Oct 2020 13:24:18 -0700 [thread overview]
Message-ID: <160400305868.884498.15370248590957087613@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <CAD=FV=U93bfZv_uLG0XFXtBBMrD7gg=L3ijnpPnOCgeeo=CqAg@mail.gmail.com>
Quoting Doug Anderson (2020-10-29 09:22:55)
> Hi,
>
> On Wed, Oct 28, 2020 at 6:12 PM Stephen Boyd <swboyd@chromium.org> wrote:
> >
> > We should be setting the drm_dp_aux_msg::reply field if a NACK or a
> > SHORT reply happens.
>
> I don't think you update the "reply" field for SHORT, right? You just
> return a different size?
Correct.
>
>
> > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> > index 6b6e98ca2881..19737bc01b8f 100644
> > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> > @@ -909,10 +910,32 @@ static ssize_t ti_sn_aux_transfer(struct drm_dp_aux *aux,
> > ret = regmap_read(pdata->regmap, SN_AUX_CMD_STATUS_REG, &val);
> > if (ret)
> > return ret;
> > - else if ((val & AUX_IRQ_STATUS_NAT_I2C_FAIL)
> > - || (val & AUX_IRQ_STATUS_AUX_RPLY_TOUT)
> > - || (val & AUX_IRQ_STATUS_AUX_SHORT))
> > - return -ENXIO;
> > +
> > + if (val & AUX_IRQ_STATUS_AUX_RPLY_TOUT) {
> > + /*
> > + * The hardware tried the message seven times per the DP spec
> > + * but it hit a timeout. We ignore defers here because they're
> > + * handled in hardware.
> > + */
> > + return -ETIMEDOUT;
> > + }
> > + if (val & AUX_IRQ_STATUS_AUX_SHORT) {
> > + ret = regmap_read(pdata->regmap, SN_AUX_LENGTH_REG, &len);
> > + if (ret)
> > + return ret;
>
> IIUC, your digging through the code showed that in order to fully
> handle the "SHORT" case you also needed to add support for
> "DP_AUX_I2C_WRITE_STATUS_UPDATE", right?
Oh yeah. If a short reply happens and it is aux over i2c then
drm_dp_i2c_msg_write_status_update() is called and
DP_AUX_I2C_WRITE_STATUS_UPDATE is set and then we try a transfer again.
We need to handle that type of request in this ti_sn_aux_transfer()
function.
>
> Even without handling "DP_AUX_I2C_WRITE_STATUS_UPDATE" though, this
> patch seems to be an improvement and I'd support landing it.
>
> Oh, I guess one other thing: I think this is all from code inspection,
> right? You didn't manage to reproduce anything that would tickle one
> of these code paths? Might be worth mentioning, even if "after the
> cut"?
>
Yes, just code inspection. I can add that detail to the commit text.
prev parent reply other threads:[~2020-10-29 20:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 1:11 [PATCH 0/4] drm/bridge: ti-sn65dsi86: Support EDID reading Stephen Boyd
2020-10-29 1:11 ` [PATCH 1/4] drm/bridge: ti-sn65dsi86: Combine register accesses in ti_sn_aux_transfer() Stephen Boyd
2020-10-29 16:10 ` Doug Anderson
2020-10-30 1:18 ` Stephen Boyd
2020-10-29 1:11 ` [PATCH 2/4] drm/bridge: ti-sn65dsi86: Make polling a busy loop Stephen Boyd
2020-10-29 16:11 ` Doug Anderson
2020-10-29 1:11 ` [PATCH 3/4] drm/bridge: ti-sn65dsi86: Read EDID blob over DDC Stephen Boyd
2020-10-29 16:11 ` Doug Anderson
2020-10-29 1:11 ` [PATCH 4/4] drm/bridge: ti-sn65dsi86: Update reply on aux failures Stephen Boyd
2020-10-29 16:22 ` Doug Anderson
2020-10-29 20:24 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160400305868.884498.15370248590957087613@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=sam@ravnborg.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).