From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755090AbcG0KCx (ORCPT ); Wed, 27 Jul 2016 06:02:53 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:36459 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754501AbcG0KCu (ORCPT ); Wed, 27 Jul 2016 06:02:50 -0400 From: stefan.mavrodiev@gmail.com To: Maxime Ripard Cc: stefan.mavrodiev@gmail.com, dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@armlinux.org.uk, wens@csie.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v4] ARM: dts: sun8i: Add dts file for Olimex A33-OLinuXino Date: Wed, 27 Jul 2016 13:02:41 +0300 Message-ID: <1604486.mrBvLz4HRZ@linux-cigu> User-Agent: KMail/5.2.1 (Linux/4.6.0-1-default; KDE/5.22.0; x86_64; ; ) In-Reply-To: <20160727062146.GA6560@lukather> References: <1469450243-19138-1-git-send-email-stefan.mavrodiev@gmail.com> <30014119.IrjfP0xFry@linux-cigu> <20160727062146.GA6560@lukather> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, July 27, 2016 8:21:46 AM EEST Maxime Ripard wrote: > On Wed, Jul 27, 2016 at 08:12:29AM +0300, stefan.mavrodiev@gmail.com wrote: > > > > +®_dcdc1 { > > > > + regulator-always-on; > > > > + regulator-min-microvolt = <3300000>; > > > > + regulator-max-microvolt = <3300000>; > > > > + regulator-name = "vcc-dsi"; > > > > +}; > > > > > > What is it used for? Is it really necessary to keep it on at all time? > > > > I think so. > > This is the supply for the MMC. > > Then it's poorly named, and you should tie it to the MMC, and remove > the always-on if it's only used by the mmc. always-on is supposed to > be for regulators that shouldn't but turned off for the system to stay > running. Some MMC regulator doesn't fit that description. > It's named upon the A33 power pin - "VCC-DSI". If I remove "always-on" the board still will work, since dcdc1 is tied to mmc0. vmmc-supply = <®_dcdc1>; We assume this voltage will be always present and there are some pullups that are tied to it (on i2c0 and i2c1 bus). In this case should I remove "always- on" from the regulator node? > Maxime Best regards, Stefan Mavrodiev