From: Stephen Boyd <sboyd@kernel.org>
To: Zong Li <zong.li@sifive.com>,
aou@eecs.berkeley.edu, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
mturquette@baylibre.com, palmer@dabbelt.com,
paul.walmsley@sifive.com, yash.shah@sifive.com
Cc: Zong Li <zong.li@sifive.com>
Subject: Re: [PATCH 1/4] clk: sifive: Extract prci core to common base
Date: Wed, 04 Nov 2020 18:45:42 -0800 [thread overview]
Message-ID: <160454434294.3965362.6100009498384462585@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <b10784643665ad56ca41ea6754c7f28f8be1c7ca.1602838910.git.zong.li@sifive.com>
Quoting Zong Li (2020-10-16 02:18:23)
> Extract common core of prci driver to an independent file, it could
> allow other chips to reuse it. Separate SoCs-dependent code 'fu540'
> from prci core, then we can easily add 'fu740' later.
Please indicate if there are any functional changes or this is just code
movement.
>
> Signed-off-by: Zong Li <zong.li@sifive.com>
> ---
> drivers/clk/sifive/Makefile | 2 +
> drivers/clk/sifive/fu540-prci.c | 586 +------------------------------
> drivers/clk/sifive/fu540-prci.h | 21 ++
> drivers/clk/sifive/sifive-prci.c | 409 +++++++++++++++++++++
> drivers/clk/sifive/sifive-prci.h | 201 +++++++++++
How much of this is a copy/pastes? Can you generate patches with
format-patch -M -C to try to find copies and renames?
> 5 files changed, 652 insertions(+), 567 deletions(-)
> create mode 100644 drivers/clk/sifive/fu540-prci.h
> create mode 100644 drivers/clk/sifive/sifive-prci.c
> create mode 100644 drivers/clk/sifive/sifive-prci.h
>
next prev parent reply other threads:[~2020-11-05 2:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 9:18 [PATCH 0/4] clk: add driver for the SiFive FU740 Zong Li
2020-10-16 9:18 ` [PATCH 1/4] clk: sifive: Extract prci core to common base Zong Li
2020-11-05 2:45 ` Stephen Boyd [this message]
2020-11-05 7:22 ` Zong Li
2020-11-05 9:19 ` Andreas Schwab
2020-11-05 9:30 ` Zong Li
2020-10-16 9:18 ` [PATCH 2/4] clk: sifive: Use common name for prci configuration Zong Li
2020-11-05 2:46 ` Stephen Boyd
2020-11-05 6:56 ` Zong Li
2020-11-05 18:54 ` Palmer Dabbelt
2020-10-16 9:18 ` [PATCH 3/4] clk: sifive: Add a driver for the SiFive FU740 PRCI IP block Zong Li
2020-10-16 9:18 ` [PATCH 4/4] clk: sifive: Refactor __prci_clock array by using macro Zong Li
2020-11-05 2:50 ` Stephen Boyd
2020-11-05 7:16 ` Zong Li
2020-10-16 14:17 ` [PATCH 0/4] clk: add driver for the SiFive FU740 Sean Anderson
2020-10-16 14:56 ` Zong Li
2020-11-04 6:37 ` Zong Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160454434294.3965362.6100009498384462585@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=yash.shah@sifive.com \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).