From: Sagar Shrikant Kadam <sagar.kadam@sifive.com>
To: linux-kernel@vger.kernel.org
Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
kernel@esmil.dk, atish.patra@wdc.com, alistair.francis@wdc.com,
anup@brainfault.org, yash.shah@sifive.com, aou@eecs.berkeley.edu,
palmer@dabbelt.com, paul.walmsley@sifive.com, robh+dt@kernel.org,
Sagar Shrikant Kadam <sagar.kadam@sifive.com>
Subject: [PATCH v2 1/3] dts: phy: fix missing mdio device and probe failure of vsc8541-01 device
Date: Tue, 10 Nov 2020 07:22:10 -0800 [thread overview]
Message-ID: <1605021732-268521-2-git-send-email-sagar.kadam@sifive.com> (raw)
In-Reply-To: <1605021732-268521-1-git-send-email-sagar.kadam@sifive.com>
HiFive unleashed A00 board has VSC8541-01 ethernet phy, this device is
identified as a Revision B device as described in device identification
registers. In order to use this phy in the unmanaged mode, it requires
a specific reset sequence of logical 0-1-0-1 transition on the NRESET pin
as documented here [1].
Currently, the bootloader (fsbl or u-boot-spl) takes care of the phy reset.
If due to some reason the phy device hasn't received the reset by the prior
stages before the linux macb driver comes into the picture, the MACB mii
bus gets probed but the mdio scan fails and is not even able to read the
phy ID registers. It gives an error message:
"libphy: MACB_mii_bus: probed
mdio_bus 10090000.ethernet-ffffffff: MDIO device at address 0 is missing."
Thus adding the device OUI (Organizationally Unique Identifier) to the phy
device node helps to probe the phy device.
[1]: VSC8541-01 datasheet:
https://www.mouser.com/ds/2/523/Microsemi_VSC8541-01_Datasheet_10496_V40-1148034.pdf
Signed-off-by: Sagar Shrikant Kadam <sagar.kadam@sifive.com>
---
arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
index 4a2729f..60846e8 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
@@ -88,6 +88,7 @@
phy-mode = "gmii";
phy-handle = <&phy0>;
phy0: ethernet-phy@0 {
+ compatible = "ethernet-phy-id0007.0771";
reg = <0>;
};
};
--
2.7.4
next prev parent reply other threads:[~2020-11-10 15:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 15:22 [PATCH v2 0/3] fix macb phy probe failure if phy-reset is not handled Sagar Shrikant Kadam
2020-11-10 15:22 ` Sagar Shrikant Kadam [this message]
2020-11-10 15:22 ` [PATCH v2 2/3] dts: phy: add GPIO number and active state used for phy reset Sagar Shrikant Kadam
2020-11-10 15:22 ` [PATCH v2 3/3] riscv: defconfig: enable gpio support for HiFive Unleashed Sagar Shrikant Kadam
2021-01-14 5:01 ` [PATCH v2 0/3] fix macb phy probe failure if phy-reset is not handled Palmer Dabbelt
2021-02-04 10:16 ` Andreas Schwab
2021-02-05 3:41 ` Palmer Dabbelt
2021-02-06 10:27 ` David Abdurachmanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1605021732-268521-2-git-send-email-sagar.kadam@sifive.com \
--to=sagar.kadam@sifive.com \
--cc=alistair.francis@wdc.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@wdc.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@esmil.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=yash.shah@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).