From: "tip-bot2 for Hui Su" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Hui Su <sh_def@163.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Phil Auld <pauld@redhat.com>, Ben Segall <bsegall@google.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: sched/core] sched/fair: Remove superfluous lock section in do_sched_cfs_slack_timer()
Date: Wed, 11 Nov 2020 08:23:14 -0000 [thread overview]
Message-ID: <160508299420.11244.12434914421630975924.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20201030144621.GA96974@rlk>
The following commit has been merged into the sched/core branch of tip:
Commit-ID: cdb310474dece99985e4cdd2b96b1324e39c1c9d
Gitweb: https://git.kernel.org/tip/cdb310474dece99985e4cdd2b96b1324e39c1c9d
Author: Hui Su <sh_def@163.com>
AuthorDate: Fri, 30 Oct 2020 22:46:21 +08:00
Committer: Peter Zijlstra <peterz@infradead.org>
CommitterDate: Tue, 10 Nov 2020 18:39:05 +01:00
sched/fair: Remove superfluous lock section in do_sched_cfs_slack_timer()
Since ab93a4bc955b ("sched/fair: Remove distribute_running fromCFS
bandwidth"), there is nothing to protect between
raw_spin_lock_irqsave/store() in do_sched_cfs_slack_timer().
Signed-off-by: Hui Su <sh_def@163.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Phil Auld <pauld@redhat.com>
Reviewed-by: Ben Segall <bsegall@google.com>
Link: https://lkml.kernel.org/r/20201030144621.GA96974@rlk
---
kernel/sched/fair.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 2755a7e..3e5d98f 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -5126,9 +5126,6 @@ static void do_sched_cfs_slack_timer(struct cfs_bandwidth *cfs_b)
return;
distribute_cfs_runtime(cfs_b);
-
- raw_spin_lock_irqsave(&cfs_b->lock, flags);
- raw_spin_unlock_irqrestore(&cfs_b->lock, flags);
}
/*
prev parent reply other threads:[~2020-11-11 8:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 14:46 [PATCH] sched/fair: remove the spin_lock operations Hui Su
2020-10-30 15:42 ` Phil Auld
2020-10-30 18:48 ` Benjamin Segall
2020-10-30 22:16 ` David Laight
2020-11-02 13:53 ` Phil Auld
2020-11-02 14:10 ` Hui Su
2020-11-11 8:23 ` tip-bot2 for Hui Su [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160508299420.11244.12434914421630975924.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=bsegall@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=pauld@redhat.com \
--cc=peterz@infradead.org \
--cc=sh_def@163.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).