* [PATCH] rtl8xxxu: remove the unused variable timeout value assignment
@ 2020-11-13 9:50 xiakaixu1987
2020-11-13 14:56 ` Jes Sorensen
0 siblings, 1 reply; 2+ messages in thread
From: xiakaixu1987 @ 2020-11-13 9:50 UTC (permalink / raw)
To: Jes.Sorensen, kvalo, chiu; +Cc: linux-wireless, linux-kernel, Kaixu Xia
From: Kaixu Xia <kaixuxia@tencent.com>
The value of variable timeout is overwritten by the following statement in
rtl8xxxu_gen1_init_aggregation(), so here the value assignment is useless.
Remove it.
Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
index 5cd7ef3..342126b 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
@@ -4426,7 +4426,7 @@ void rtl8xxxu_gen1_init_aggregation(struct rtl8xxxu_priv *priv)
page_thresh = (priv->fops->rx_agg_buf_size / 512);
if (rtl8xxxu_dma_agg_pages >= 0) {
if (rtl8xxxu_dma_agg_pages <= page_thresh)
- timeout = page_thresh;
+ ; /* do nothing */
else if (rtl8xxxu_dma_agg_pages <= 6)
dev_err(&priv->udev->dev,
"%s: dma_agg_pages=%i too small, minimum is 6\n",
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtl8xxxu: remove the unused variable timeout value assignment
2020-11-13 9:50 [PATCH] rtl8xxxu: remove the unused variable timeout value assignment xiakaixu1987
@ 2020-11-13 14:56 ` Jes Sorensen
0 siblings, 0 replies; 2+ messages in thread
From: Jes Sorensen @ 2020-11-13 14:56 UTC (permalink / raw)
To: xiakaixu1987, kvalo, chiu; +Cc: linux-wireless, linux-kernel, Kaixu Xia
On 11/13/20 4:50 AM, xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>
>
> The value of variable timeout is overwritten by the following statement in
> rtl8xxxu_gen1_init_aggregation(), so here the value assignment is useless.
> Remove it.
>
> Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
> ---
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> index 5cd7ef3..342126b 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> @@ -4426,7 +4426,7 @@ void rtl8xxxu_gen1_init_aggregation(struct rtl8xxxu_priv *priv)
> page_thresh = (priv->fops->rx_agg_buf_size / 512);
> if (rtl8xxxu_dma_agg_pages >= 0) {
> if (rtl8xxxu_dma_agg_pages <= page_thresh)
> - timeout = page_thresh;
> + ; /* do nothing */
Sorry this is the wrong way to do this. If the if statement is no longer
needed, then remove it, don't just make it do nothing.
Nack
Jes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-13 14:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-13 9:50 [PATCH] rtl8xxxu: remove the unused variable timeout value assignment xiakaixu1987
2020-11-13 14:56 ` Jes Sorensen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).