From: Stephen Boyd <swboyd@chromium.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Matthias Kaehlcke <mka@chromium.org>
Subject: Re: [PATCH v2] arm64: dts: qcom: sc7180: Add prox sensor to LTE sku Lazor boards
Date: Fri, 20 Nov 2020 10:21:24 -0800 [thread overview]
Message-ID: <160589648433.2717324.4950553484725759433@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <CAD=FV=WhbAQMm4u9kj7ZrdxSRDX1dWxdopuMx7TGx+wafC1Rjg@mail.gmail.com>
Quoting Doug Anderson (2020-11-20 09:50:38)
> Hi,
>
> On Thu, Nov 19, 2020 at 11:45 PM Stephen Boyd <swboyd@chromium.org> wrote:
> >
> > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dts
> > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dts
> > @@ -13,6 +13,14 @@ / {
> > compatible = "google,lazor-rev1-sku0", "google,lazor-rev2-sku0", "qcom,sc7180";
> > };
> >
> > +&ap_sar_sensor {
> > + status = "okay";
> > +};
> > +
> > +&ap_sar_sensor_i2c {
> > + status = "okay";
>
> Technically you don't need to mark the i2c bus as "okay" upstream
> because it's already "okay" in "sc7180-trogdor.dtsi". ...or perhaps
> you should add a patch that changes that and makes us match
> downstream. ;-)
Ok I will resend with that extra part too.
prev parent reply other threads:[~2020-11-20 18:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 7:45 [PATCH v2] arm64: dts: qcom: sc7180: Add prox sensor to LTE sku Lazor boards Stephen Boyd
2020-11-20 17:50 ` Doug Anderson
2020-11-20 18:21 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160589648433.2717324.4950553484725759433@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).