From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E301AC6379D for ; Wed, 25 Nov 2020 00:14:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8EBBA2151B for ; Wed, 25 Nov 2020 00:14:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="eLU5QbBu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727151AbgKYAOn (ORCPT ); Tue, 24 Nov 2020 19:14:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:56390 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726463AbgKYAOn (ORCPT ); Tue, 24 Nov 2020 19:14:43 -0500 Received: from kernel.org (unknown [104.132.1.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DBB86206E5; Wed, 25 Nov 2020 00:14:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606263283; bh=yiZ84YEeFL0wWYezky6vF3yhpPWjHZ52uDhLhbMfJQM=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=eLU5QbBunDunzGLbn35O61lp48dnCiQcXoMj6ntVLrpCl3D2hSb7EzYMD9E7xCufo faLinbGoGYFCtqY3HR9mXHNu5faGJskKKN4nMkiF9Z0YrPcdbgRghR/v20re2SmSD7 rf5xyq57yHsYQeoFrG1CdVXncecGIlRjpGaTHnF4= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20201115170950.304460-4-krzk@kernel.org> References: <20201115170950.304460-1-krzk@kernel.org> <20201115170950.304460-4-krzk@kernel.org> Subject: Re: [RFC 3/3] media: atomisp: do not select COMMON_CLK to fix builds From: Stephen Boyd Cc: Krzysztof Kozlowski To: Chen-Yu Tsai , Greg Kroah-Hartman , Jaroslav Kysela , Jernej Skrabec , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Mauro Carvalho Chehab , Maxime Ripard , Michael Turquette , Sakari Ailus , Takashi Iwai , alsa-devel@alsa-project.org, devel@driverdev.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Date: Tue, 24 Nov 2020 16:14:41 -0800 Message-ID: <160626328163.2717324.18098835445527872342@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Krzysztof Kozlowski (2020-11-15 09:09:50) > COMMON_CLK is a user-selectable option with its own dependencies. The > most important dependency is !HAVE_LEGACY_CLK. User-selectable drivers > should not select COMMON_CLK because they will create a dependency cycle > and build failures. >=20 > Signed-off-by: Krzysztof Kozlowski This is fallout from making the COMMON_CLK symbol selectable in commit bbd7ffdbef68 ("clk: Allow the common clk framework to be selectable"). Before then we needed drivers to select the COMMON_CLK config so that the framework was enabled. Now that isn't necessary and any user-selectable options should be moved to depends syntax. Reviewed-by: Stephen Boyd