From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3735FC64E7D for ; Wed, 25 Nov 2020 02:06:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D190B2067D for ; Wed, 25 Nov 2020 02:06:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="RJHypOeL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727192AbgKYCGY (ORCPT ); Tue, 24 Nov 2020 21:06:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:37040 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726085AbgKYCGX (ORCPT ); Tue, 24 Nov 2020 21:06:23 -0500 Received: from kernel.org (unknown [104.132.1.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 66CAE2067D; Wed, 25 Nov 2020 02:06:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606269983; bh=iwIWhrMn6QmFc+tknI5JAn3HLJvGt8AXMGD/Vwy263s=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=RJHypOeL30X1wAE/0WLrkf+vjEo4OHYMMmK6+txIyHr0mdGBJkHCj7pmntl8Bu5Ge 7yq/1C5SKUK6YrhCgi1y+E33+HQ9oecyS2RjhcO91tku5y5pkYtggk0i3GawP1FpKs HoeVqfni/Z7L/w6vZ9MUgWxfIgzYM5nvGLEv+O9o= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20201120161839.GD3870099@ulmo> References: <20201029004820.9062-1-nicoleotsuka@gmail.com> <20201120161656.GC3870099@ulmo> <20201120161839.GD3870099@ulmo> Subject: Re: [PATCH] clk: tegra: Do not return 0 on failure From: Stephen Boyd Cc: Nicolin Chen , jonathanh@nvidia.com, pgaikwad@nvidia.com, pdeschrijver@nvidia.com, stable@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-clk@vger.kernel.org To: Michael Turquette , Thierry Reding Date: Tue, 24 Nov 2020 18:06:22 -0800 Message-ID: <160626998208.2717324.3699032150208058364@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Thierry Reding (2020-11-20 08:18:39) > On Fri, Nov 20, 2020 at 05:16:56PM +0100, Thierry Reding wrote: > > On Wed, Oct 28, 2020 at 05:48:20PM -0700, Nicolin Chen wrote: > > > Return values from read_dt_param() will be either TRUE (1) or > > > FALSE (0), while dfll_fetch_pwm_params() returns 0 on success > > > or an ERR code on failure. > > >=20 > > > So this patch fixes the bug of returning 0 on failure. > > >=20 > > > Fixes: 36541f0499fe ("clk: tegra: dfll: support PWM regulator control= ") > > > Cc: > > > Signed-off-by: Nicolin Chen > > > --- > > > drivers/clk/tegra/clk-dfll.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > >=20 > > Mike, Stephen, > >=20 > > if you don't mind, I'll pick this up in the Tegra tree since there are a > > few other Tegra clock patches on the list that may require coordination > > inside the Tegra tree. >=20 > Also, I do plan on sending the collected set of patches to you for > inclusion via PR at a later date, if that's okay with you. >=20 Ok sure.