From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70476C71156 for ; Mon, 30 Nov 2020 08:59:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 258F8207BC for ; Mon, 30 Nov 2020 08:59:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="lNx2ZA5/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727770AbgK3I71 (ORCPT ); Mon, 30 Nov 2020 03:59:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:40244 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727662AbgK3I70 (ORCPT ); Mon, 30 Nov 2020 03:59:26 -0500 Received: from localhost (lfbn-tou-1-1075-236.w90-76.abo.wanadoo.fr [90.76.143.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8E9302074A; Mon, 30 Nov 2020 08:58:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606726726; bh=PiMzl5bnuYdPj6Syuw2erWkfTDrkKeAjIdjuNj4J0bc=; h=In-Reply-To:References:From:Subject:To:Cc:Date:From; b=lNx2ZA5/+lvaHjLAmh8seGbJO7F4ZWNQ3YkvHNvhnxZQfXiKGFxCUF2l3tm3kY4/L q2AyTo0Cr8TTvlPaX3IGcV8sr66KU/KimKbsAT/o8j2bJgorvLIxl11iLvyWtVQ89Y nCH7X+k2cwQcjPu0DeTiQQJJ/2LdHy3a6tw0p2EI= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20201129135525.396671-1-maz@kernel.org> References: <20201129135525.396671-1-maz@kernel.org> From: Antoine Tenart Subject: Re: [PATCH] irqchip/alpine-msi: Fix freeing of interrupts on allocation error path To: Marc Zyngier , linux-kernel@vger.kernel.org Cc: Thomas Gleixner , Tsahee Zidenberg Message-ID: <160672672303.3588.8640979209865178403@kwain.local> Date: Mon, 30 Nov 2020 09:58:43 +0100 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Marc, Quoting Marc Zyngier (2020-11-29 14:55:25) > The alpine-msi driver has an interesting allocation error handling, > where it frees the same interrupts repeatedly. Hilarity follows. That's interesting indeed... > This code is probably never executed, but let's fix it nonetheless. >=20 > Fixes: e6b78f2c3e14 ("irqchip: Add the Alpine MSIX interrupt controller") > Cc: Tsahee Zidenberg > Cc: Antoine Tenart > Signed-off-by: Marc Zyngier Reviewed-by: Antoine Tenart Thanks, Antoine > --- > drivers/irqchip/irq-alpine-msi.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/drivers/irqchip/irq-alpine-msi.c b/drivers/irqchip/irq-alpin= e-msi.c > index 23a3b877f7f1..ede02dc2bcd0 100644 > --- a/drivers/irqchip/irq-alpine-msi.c > +++ b/drivers/irqchip/irq-alpine-msi.c > @@ -165,8 +165,7 @@ static int alpine_msix_middle_domain_alloc(struct irq= _domain *domain, > return 0; > =20 > err_sgi: > - while (--i >=3D 0) > - irq_domain_free_irqs_parent(domain, virq, i); > + irq_domain_free_irqs_parent(domain, virq, i - 1); > alpine_msix_free_sgi(priv, sgi, nr_irqs); > return err; > } > --=20 > 2.29.2 >=20