From: Stephen Boyd <swboyd@chromium.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Alexandru M Stan <amstan@chromium.org>,
Mark Brown <broonie@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
Akash Asthana <akashast@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>
Subject: Re: [PATCH] spi: spi-geni-qcom: Use the new method of gpio CS control
Date: Thu, 03 Dec 2020 16:10:39 -0800 [thread overview]
Message-ID: <160704063968.1580929.17834773484656581141@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <CAD=FV=WDYdfURHWf8qGOSwT+7Y5i=9FMgRn5hYZA-oTfR6KoFQ@mail.gmail.com>
Quoting Doug Anderson (2020-12-03 12:06:10)
> On Wed, Dec 2, 2020 at 4:47 PM Stephen Boyd <swboyd@chromium.org> wrote:
> >
> > And that is wrong. With even more investigation and Doug's eagle eyes it
> > seems that the cros-ec driver is overriding the spi::mode to clear out
> > the SPI_CS_HIGH bit that the spi core sets in there when using the gpio
> > descriptors. I'll send a patch for cros-ec-spi shortly.
>
> So do we need any coordinating here, are we OK w/ trogdor devices
> being broken for a short period of time?
>
> I think the device tree changes switching to use GPIO for chip select
> is already queued in linux-next. That means if we land this patch
> before the fix to cros_ec [1] then we'll end up in a broken state.
> Would we be able to do some quick landing to get the cros-ec fix into
> v5.10 and then target the SPI patch for 5.11?
I don't think it really matters if the two patches meet up in linux-next
or cros-ec is fast tracked, but it would be bad if this patch was merged
without the cros-ec one. One option would be to apply the cros-ec fix to
the spi tree along with this patch (or vice versa) so that a bisection
hole isn't created. Or this patch can wait for a while until cros-ec is
fixed. I'm not the maintainer here so it's really up to Mark and
Enric/Benson.
>
> [1] https://lore.kernel.org/r/20201203011649.1405292-2-swboyd@chromium.org/
next prev parent reply other threads:[~2020-12-04 0:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 21:49 [PATCH] spi: spi-geni-qcom: Use the new method of gpio CS control Stephen Boyd
2020-12-02 22:18 ` Alexandru M Stan
2020-12-02 23:28 ` Stephen Boyd
2020-12-03 0:47 ` Stephen Boyd
2020-12-03 20:06 ` Doug Anderson
2020-12-04 0:10 ` Stephen Boyd [this message]
2020-12-04 9:13 ` Enric Balletbo i Serra
2020-12-04 17:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160704063968.1580929.17834773484656581141@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=akashast@codeaurora.org \
--cc=amstan@chromium.org \
--cc=bjorn.andersson@linaro.org \
--cc=bleung@chromium.org \
--cc=broonie@kernel.org \
--cc=dianders@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).