From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57CDDC19437 for ; Fri, 4 Dec 2020 01:24:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 07D4A224BD for ; Fri, 4 Dec 2020 01:24:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731985AbgLDBX7 (ORCPT ); Thu, 3 Dec 2020 20:23:59 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:8634 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729022AbgLDBX6 (ORCPT ); Thu, 3 Dec 2020 20:23:58 -0500 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CnFLq4L7pz15X18; Fri, 4 Dec 2020 09:22:43 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Fri, 4 Dec 2020 09:23:07 +0800 From: Tian Tao To: , , , , , , , , Subject: [PATCH] gpu: ipu-v3: replace spin_lock_irqsave by spin_lock in hard IRQ Date: Fri, 4 Dec 2020 09:23:16 +0800 Message-ID: <1607044999-47666-11-git-send-email-tiantao6@hisilicon.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1607044999-47666-1-git-send-email-tiantao6@hisilicon.com> References: <1607044999-47666-1-git-send-email-tiantao6@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The code has been in a irq-disabled context since it is hard IRQ. There is no necessity to do it again. Signed-off-by: Tian Tao --- drivers/gpu/ipu-v3/ipu-image-convert.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu-image-convert.c b/drivers/gpu/ipu-v3/ipu-image-convert.c index aa1d4b6..c28764c 100644 --- a/drivers/gpu/ipu-v3/ipu-image-convert.c +++ b/drivers/gpu/ipu-v3/ipu-image-convert.c @@ -1737,9 +1737,8 @@ static irqreturn_t eof_irq(int irq, void *data) struct ipu_image_convert_run *run; irqreturn_t ret = IRQ_HANDLED; bool tile_complete = false; - unsigned long flags; - spin_lock_irqsave(&chan->irqlock, flags); + spin_lock(&chan->irqlock); /* get current run and its context */ run = chan->current_run; @@ -1778,7 +1777,7 @@ static irqreturn_t eof_irq(int irq, void *data) if (tile_complete) ret = do_tile_complete(run); out: - spin_unlock_irqrestore(&chan->irqlock, flags); + spin_unlock(&chan->irqlock); return ret; } -- 2.7.4