From: Tian Tao <tiantao6@hisilicon.com>
To: <airlied@linux.ie>, <daniel@ffwll.ch>, <tzimmermann@suse.de>,
<kraxel@redhat.com>, <alexander.deucher@amd.com>,
<tglx@linutronix.de>, <dri-devel@lists.freedesktop.org>,
<xinliang.liu@linaro.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/2] drm/hisilicon: Use managed mode-config init
Date: Fri, 4 Dec 2020 09:23:08 +0800 [thread overview]
Message-ID: <1607044999-47666-3-git-send-email-tiantao6@hisilicon.com> (raw)
In-Reply-To: <1607044999-47666-1-git-send-email-tiantao6@hisilicon.com>
Using drmm_mode_config_init() sets up managed release of modesetting
resources.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
index 5aea2e9..04fee18 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
+++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
@@ -82,7 +82,9 @@ static int hibmc_kms_init(struct hibmc_drm_private *priv)
struct drm_device *dev = &priv->dev;
int ret;
- drm_mode_config_init(dev);
+ ret = drmm_mode_config_init(dev);
+ if (ret)
+ return ret;
priv->mode_config_initialized = true;
dev->mode_config.min_width = 0;
@@ -111,14 +113,6 @@ static int hibmc_kms_init(struct hibmc_drm_private *priv)
return 0;
}
-static void hibmc_kms_fini(struct hibmc_drm_private *priv)
-{
- if (priv->mode_config_initialized) {
- drm_mode_config_cleanup(&priv->dev);
- priv->mode_config_initialized = false;
- }
-}
-
/*
* It can operate in one of three modes: 0, 1 or Sleep.
*/
@@ -248,7 +242,6 @@ static int hibmc_unload(struct drm_device *dev)
drm_atomic_helper_shutdown(dev);
pci_disable_msi(dev->pdev);
- hibmc_kms_fini(priv);
dev->dev_private = NULL;
return 0;
}
--
2.7.4
next prev parent reply other threads:[~2020-12-04 1:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 1:23 [PATCH drm/hisilicon 0/3] support reading resolutions from EDID Tian Tao
2020-12-04 1:23 ` [PATCH] drm/fsl-dcu: remove redundant platform_get_irq error message Tian Tao
2020-12-04 1:23 ` Tian Tao [this message]
2020-12-04 1:23 ` [PATCH] drm/msm/dp: remove duplicate include statement Tian Tao
2020-12-04 1:23 ` [PATCH] drm/msm/dsi: Replace spin_lock_irqsave by spin_lock in hard IRQ Tian Tao
2020-12-04 1:23 ` [PATCH] drm/nouveau/fb/gp102-: use flexible-array member instead of zero-length array Tian Tao
2020-12-04 1:23 ` [PATCH] drm/nouveau: Use vmemdup_user() Tian Tao
2020-12-04 1:23 ` [PATCH] drm/tilcdc: Remove unnecessary THIS_MODULE Tian Tao
2020-12-04 1:23 ` [PATCH] drm/ttm: remove unused varibles Tian Tao
2020-12-04 1:23 ` [PATCH] drm/vc4: Deleted the drm_device declaration Tian Tao
2020-12-04 1:23 ` [PATCH] gpu: ipu-v3: replace spin_lock_irqsave by spin_lock in hard IRQ Tian Tao
2020-12-04 1:23 ` [PATCH 2/2] drm/hisilicon: Deletted unused local parameters Tian Tao
2020-12-04 1:23 ` [PATCH v2] drm/hisilicon: Delete the entire file hibmc_ttm.c Tian Tao
2020-12-04 1:23 ` [PATCH drm/hisilicon v3 0/2] support reading resolutions from EDID Tian Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1607044999-47666-3-git-send-email-tiantao6@hisilicon.com \
--to=tiantao6@hisilicon.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tzimmermann@suse.de \
--cc=xinliang.liu@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).