From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752131AbcGPAqs (ORCPT ); Fri, 15 Jul 2016 20:46:48 -0400 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:43573 "HELO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751775AbcGPAqq (ORCPT ); Fri, 15 Jul 2016 20:46:46 -0400 From: "Rafael J. Wysocki" To: Lv Zheng Cc: "Rafael J. Wysocki" , Len Brown , Lv Zheng , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [RFC PATCH 3/3] ACPI / PM: Fix EC polling issue by implementing prepare_late/finish_early suspend_ops callbacks Date: Sat, 16 Jul 2016 02:51:34 +0200 Message-ID: <1607219.k0v9zRxBvM@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.5.0-rc1+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <48245fbc4b0510a7af281986ccc1a2a583766f73.1467100803.git.lv.zheng@intel.com> References: <48245fbc4b0510a7af281986ccc1a2a583766f73.1467100803.git.lv.zheng@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, June 28, 2016 04:04:46 PM Lv Zheng wrote: > _PTS/_WAK may contain EC transactions, it is better to have them handled > with IRQ enabled. This patch moves the 2 suspend PM ops from noirq stage > to late/early stage. > > Signed-off-by: Lv Zheng There are systems that won't work with this patch applied, so I don't see a point in applying the other two. > --- > drivers/acpi/sleep.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c > index d30fce7f..c5c374c9 100644 > --- a/drivers/acpi/sleep.c > +++ b/drivers/acpi/sleep.c > @@ -595,9 +595,10 @@ static int acpi_suspend_state_valid(suspend_state_t pm_state) > static const struct platform_suspend_ops acpi_suspend_ops = { > .valid = acpi_suspend_state_valid, > .begin = acpi_suspend_begin, > - .prepare_noirq = acpi_pm_prepare, > + .prepare_late = __acpi_pm_prepare, > + .prepare_noirq = acpi_pm_pre_suspend, > .enter = acpi_suspend_enter, > - .finish_noirq = acpi_pm_finish, > + .finish_early = acpi_pm_finish, > .end = acpi_pm_end, > }; > > Thanks, Rafael