From: Stephen Boyd <sboyd@kernel.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Michael Ellerman <mpe@ellerman.id.au>,
Michael Turquette <mturquette@baylibre.com>,
Paul Mackerras <paulus@samba.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Gareth Williams <gareth.williams.jx@renesas.com>,
linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [PATCH v2] clk: renesas: r9a06g032: Drop __packed for portability
Date: Mon, 07 Dec 2020 13:58:53 -0800 [thread overview]
Message-ID: <160737833361.1580929.4851886406060076908@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20201130085743.1656317-1-geert+renesas@glider.be>
Quoting Geert Uytterhoeven (2020-11-30 00:57:43)
> The R9A06G032 clock driver uses an array of packed structures to reduce
> kernel size. However, this array contains pointers, which are no longer
> aligned naturally, and cannot be relocated on PPC64. Hence when
> compile-testing this driver on PPC64 with CONFIG_RELOCATABLE=y (e.g.
> PowerPC allyesconfig), the following warnings are produced:
>
> WARNING: 136 bad relocations
> c000000000616be3 R_PPC64_UADDR64 .rodata+0x00000000000cf338
> c000000000616bfe R_PPC64_UADDR64 .rodata+0x00000000000cf370
> ...
>
> Fix this by dropping the __packed attribute from the r9a06g032_clkdesc
> definition, trading a small size increase for portability.
>
> This increases the 156-entry clock table by 1 byte per entry, but due to
> the compiler generating more efficient code for unpacked accesses, the
> net size increase is only 76 bytes (gcc 9.3.0 on arm32).
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Fixes: 4c3d88526eba2143 ("clk: renesas: Renesas R9A06G032 clock driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
Applied to clk-fixes
prev parent reply other threads:[~2020-12-07 21:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 8:57 [PATCH v2] clk: renesas: r9a06g032: Drop __packed for portability Geert Uytterhoeven
2020-11-30 21:57 ` Stephen Rothwell
2020-12-01 10:03 ` Stephen Rothwell
2020-12-05 6:24 ` Stephen Boyd
2020-12-05 9:05 ` Geert Uytterhoeven
2020-12-07 21:58 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160737833361.1580929.4851886406060076908@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=gareth.williams.jx@renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=mturquette@baylibre.com \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).