linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] mtd: spi-nor: Fix multiple typos
@ 2020-11-30 15:24 Jonathan Neuschäfer
  2020-12-02 11:20 ` Tudor.Ambarus
  2020-12-08 16:09 ` Vignesh Raghavendra
  0 siblings, 2 replies; 3+ messages in thread
From: Jonathan Neuschäfer @ 2020-11-30 15:24 UTC (permalink / raw)
  To: linux-mtd
  Cc: Vignesh Raghavendra, Jonathan Neuschäfer, Tudor Ambarus,
	Miquel Raynal, Richard Weinberger, linux-kernel

There are a few typos in comments in the SPI NOR framework; fix them.

Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
 drivers/mtd/spi-nor/core.c  | 4 ++--
 drivers/mtd/spi-nor/sfdp.c  | 2 +-
 include/linux/mtd/spi-nor.h | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
index f0ae7a01703a1..b224b275125a3 100644
--- a/drivers/mtd/spi-nor/core.c
+++ b/drivers/mtd/spi-nor/core.c
@@ -1447,7 +1447,7 @@ static int spi_nor_erase_multi_sectors(struct spi_nor *nor, u64 addr, u32 len)

 /*
  * Erase an address range on the nor chip.  The address range may extend
- * one or more erase sectors.  Return an error is there is a problem erasing.
+ * one or more erase sectors.  Return an error if there is a problem erasing.
  */
 static int spi_nor_erase(struct mtd_info *mtd, struct erase_info *instr)
 {
@@ -2537,7 +2537,7 @@ spi_nor_select_uniform_erase(struct spi_nor_erase_map *map,
 		}

 		/*
-		 * Otherwise, the current erase size is still a valid canditate.
+		 * Otherwise, the current erase size is still a valid candidate.
 		 * Select the biggest valid candidate.
 		 */
 		if (!erase && tested_erase->size)
diff --git a/drivers/mtd/spi-nor/sfdp.c b/drivers/mtd/spi-nor/sfdp.c
index e2a43d39eb5f4..05b22c6576832 100644
--- a/drivers/mtd/spi-nor/sfdp.c
+++ b/drivers/mtd/spi-nor/sfdp.c
@@ -59,7 +59,7 @@ struct sfdp_bfpt_read {

 struct sfdp_bfpt_erase {
 	/*
-	 * The half-word at offset <shift> in DWORD <dwoard> encodes the
+	 * The half-word at offset <shift> in DWORD <dword> encodes the
 	 * op code and erase sector size to be used by Sector Erase commands.
 	 */
 	u32			dword;
diff --git a/include/linux/mtd/spi-nor.h b/include/linux/mtd/spi-nor.h
index 60bac2c0ec456..582ee04eeea20 100644
--- a/include/linux/mtd/spi-nor.h
+++ b/include/linux/mtd/spi-nor.h
@@ -406,7 +406,7 @@ static inline struct device_node *spi_nor_get_flash_node(struct spi_nor *nor)
  * @name:	the chip type name
  * @hwcaps:	the hardware capabilities supported by the controller driver
  *
- * The drivers can use this fuction to scan the SPI NOR.
+ * The drivers can use this function to scan the SPI NOR.
  * In the scanning, it will try to get all the necessary information to
  * fill the mtd_info{} and the spi_nor{}.
  *
--
2.29.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] mtd: spi-nor: Fix multiple typos
  2020-11-30 15:24 [PATCH v2] mtd: spi-nor: Fix multiple typos Jonathan Neuschäfer
@ 2020-12-02 11:20 ` Tudor.Ambarus
  2020-12-08 16:09 ` Vignesh Raghavendra
  1 sibling, 0 replies; 3+ messages in thread
From: Tudor.Ambarus @ 2020-12-02 11:20 UTC (permalink / raw)
  To: j.neuschaefer, linux-mtd; +Cc: vigneshr, miquel.raynal, richard, linux-kernel

On 11/30/20 5:24 PM, Jonathan Neuschäfer wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> There are a few typos in comments in the SPI NOR framework; fix them.
> 
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> ---
>  drivers/mtd/spi-nor/core.c  | 4 ++--
>  drivers/mtd/spi-nor/sfdp.c  | 2 +-
>  include/linux/mtd/spi-nor.h | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
> index f0ae7a01703a1..b224b275125a3 100644
> --- a/drivers/mtd/spi-nor/core.c
> +++ b/drivers/mtd/spi-nor/core.c
> @@ -1447,7 +1447,7 @@ static int spi_nor_erase_multi_sectors(struct spi_nor *nor, u64 addr, u32 len)
> 
>  /*
>   * Erase an address range on the nor chip.  The address range may extend
> - * one or more erase sectors.  Return an error is there is a problem erasing.
> + * one or more erase sectors.  Return an error if there is a problem erasing.

There's a double space before "Return" that could be trimmed.
Maybe Vignesh will do it when applying. It's good to see typos
fixed, thanks.

Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>

>   */
>  static int spi_nor_erase(struct mtd_info *mtd, struct erase_info *instr)
>  {
> @@ -2537,7 +2537,7 @@ spi_nor_select_uniform_erase(struct spi_nor_erase_map *map,
>                 }
> 
>                 /*
> -                * Otherwise, the current erase size is still a valid canditate.
> +                * Otherwise, the current erase size is still a valid candidate.
>                  * Select the biggest valid candidate.
>                  */
>                 if (!erase && tested_erase->size)
> diff --git a/drivers/mtd/spi-nor/sfdp.c b/drivers/mtd/spi-nor/sfdp.c
> index e2a43d39eb5f4..05b22c6576832 100644
> --- a/drivers/mtd/spi-nor/sfdp.c
> +++ b/drivers/mtd/spi-nor/sfdp.c
> @@ -59,7 +59,7 @@ struct sfdp_bfpt_read {
> 
>  struct sfdp_bfpt_erase {
>         /*
> -        * The half-word at offset <shift> in DWORD <dwoard> encodes the
> +        * The half-word at offset <shift> in DWORD <dword> encodes the
>          * op code and erase sector size to be used by Sector Erase commands.
>          */
>         u32                     dword;
> diff --git a/include/linux/mtd/spi-nor.h b/include/linux/mtd/spi-nor.h
> index 60bac2c0ec456..582ee04eeea20 100644
> --- a/include/linux/mtd/spi-nor.h
> +++ b/include/linux/mtd/spi-nor.h
> @@ -406,7 +406,7 @@ static inline struct device_node *spi_nor_get_flash_node(struct spi_nor *nor)
>   * @name:      the chip type name
>   * @hwcaps:    the hardware capabilities supported by the controller driver
>   *
> - * The drivers can use this fuction to scan the SPI NOR.
> + * The drivers can use this function to scan the SPI NOR.
>   * In the scanning, it will try to get all the necessary information to
>   * fill the mtd_info{} and the spi_nor{}.
>   *
> --
> 2.29.2
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] mtd: spi-nor: Fix multiple typos
  2020-11-30 15:24 [PATCH v2] mtd: spi-nor: Fix multiple typos Jonathan Neuschäfer
  2020-12-02 11:20 ` Tudor.Ambarus
@ 2020-12-08 16:09 ` Vignesh Raghavendra
  1 sibling, 0 replies; 3+ messages in thread
From: Vignesh Raghavendra @ 2020-12-08 16:09 UTC (permalink / raw)
  To: Jonathan Neuschäfer, linux-mtd
  Cc: Vignesh Raghavendra, Tudor Ambarus, linux-kernel,
	Richard Weinberger, Miquel Raynal

On Mon, 30 Nov 2020 16:24:15 +0100, Jonathan Neuschäfer wrote:
> There are a few typos in comments in the SPI NOR framework; fix them.

Addressed Tudor's comments locally.

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git spi-nor/next, thanks!
[1/1] mtd: spi-nor: Fix multiple typos
      https://git.kernel.org/mtd/c/c69942bda5

--
Regards
Vignesh


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-12-08 16:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-30 15:24 [PATCH v2] mtd: spi-nor: Fix multiple typos Jonathan Neuschäfer
2020-12-02 11:20 ` Tudor.Ambarus
2020-12-08 16:09 ` Vignesh Raghavendra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).