From: Stanley Chu <stanley.chu@mediatek.com>
To: Bean Huo <huobean@gmail.com>
Cc: <linux-scsi@vger.kernel.org>, <martin.petersen@oracle.com>,
<avri.altman@wdc.com>, <alim.akhtar@samsung.com>,
<jejb@linux.ibm.com>, <beanhuo@micron.com>,
<asutoshd@codeaurora.org>, <cang@codeaurora.org>,
<matthias.bgg@gmail.com>, <bvanassche@acm.org>,
<linux-mediatek@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <nguyenb@codeaurora.org>,
<bjorn.andersson@linaro.org>, <kuohong.wang@mediatek.com>,
<peter.wang@mediatek.com>, <chun-hung.wu@mediatek.com>,
<andy.teng@mediatek.com>, <chaotian.jing@mediatek.com>,
<cc.chou@mediatek.com>, <jiajie.hao@mediatek.com>,
<alice.chao@mediatek.com>
Subject: Re: [PATCH v2 1/2] scsi: ufs: Re-enable WriteBooster after device reset
Date: Wed, 9 Dec 2020 09:09:30 +0800 [thread overview]
Message-ID: <1607476170.3580.29.camel@mtkswgap22> (raw)
In-Reply-To: <970af8b1abf565184bf37c3c055bf42ad760201a.camel@gmail.com>
On Tue, 2020-12-08 at 15:13 +0100, Bean Huo wrote:
> On Tue, 2020-12-08 at 21:56 +0800, Stanley Chu wrote:
> > index 08c8a591e6b0..36d367eb8139 100644
> > --- a/drivers/scsi/ufs/ufshcd.h
> > +++ b/drivers/scsi/ufs/ufshcd.h
> > @@ -1221,8 +1221,13 @@ static inline void
> > ufshcd_vops_device_reset(struct ufs_hba *hba)
> > if (hba->vops && hba->vops->device_reset) {
> > int err = hba->vops->device_reset(hba);
> >
> > - if (!err)
> > + if (!err) {
> > ufshcd_set_ufs_dev_active(hba);
> > + if (ufshcd_is_wb_allowed(hba)) {
> > + hba->wb_enabled = false;
> > + hba->wb_buf_flush_enabled = false;
> > + }
> > + }
>
> Stanley,
> how do you think group wb_buf_flush_enabled and wb_enabled to the
> dev_info, since they are UFS device attributes. means they are set only
> when UFS device flags being set.
Hi Bean,
Thanks for your review.
Yes, I agreed that wb related variables is a mess currently. I would
like to clean them up once I have time. Feel free to post your patch if
you want to take it up : )
Thanks,
Stanley Chu
>
> Reviewed-by: Bean Huo <beanhuo@micron.com>
>
next prev parent reply other threads:[~2020-12-09 1:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 13:56 [PATCH v2 0/2] scsi: ufs: Re-enable WB after device reset Stanley Chu
2020-12-08 13:56 ` [PATCH v2 1/2] scsi: ufs: Re-enable WriteBooster " Stanley Chu
2020-12-08 14:13 ` Bean Huo
2020-12-09 1:09 ` Stanley Chu [this message]
2020-12-14 20:32 ` Bean Huo
2020-12-08 13:56 ` [PATCH v2 2/2] scsi: ufs: Uninline ufshcd_vops_device_reset function Stanley Chu
2020-12-08 14:14 ` Bean Huo
2020-12-15 17:33 ` Asutosh Das (asd)
2020-12-09 17:12 ` [PATCH v2 0/2] scsi: ufs: Re-enable WB after device reset Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1607476170.3580.29.camel@mtkswgap22 \
--to=stanley.chu@mediatek.com \
--cc=alice.chao@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=andy.teng@mediatek.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bjorn.andersson@linaro.org \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=cc.chou@mediatek.com \
--cc=chaotian.jing@mediatek.com \
--cc=chun-hung.wu@mediatek.com \
--cc=huobean@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=jiajie.hao@mediatek.com \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=nguyenb@codeaurora.org \
--cc=peter.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).