linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] scsi: qedi: fix missing destroy_workqueue() on error in __qedi_probe
@ 2020-11-09  9:15 Qinglang Miao
  2020-12-02 19:27 ` Mike Christie
  2020-12-09 17:23 ` Martin K. Petersen
  0 siblings, 2 replies; 3+ messages in thread
From: Qinglang Miao @ 2020-11-09  9:15 UTC (permalink / raw)
  To: Nilesh Javali, Manish Rangankar, GR-QLogic-Storage-Upstream,
	James E.J. Bottomley, Martin K. Petersen
  Cc: linux-scsi, linux-kernel, Qinglang Miao

Add the missing destroy_workqueue() before return from
__qedi_probe in the error handling case when fails to
create workqueue qedi->offload_thread.

Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver framework.")
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
---
 drivers/scsi/qedi/qedi_main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
index 61fab01d2d52..f5fc7f518f8a 100644
--- a/drivers/scsi/qedi/qedi_main.c
+++ b/drivers/scsi/qedi/qedi_main.c
@@ -2766,7 +2766,7 @@ static int __qedi_probe(struct pci_dev *pdev, int mode)
 			QEDI_ERR(&qedi->dbg_ctx,
 				 "Unable to start offload thread!\n");
 			rc = -ENODEV;
-			goto free_cid_que;
+			goto free_tmf_thread;
 		}
 
 		INIT_DELAYED_WORK(&qedi->recovery_work, qedi_recovery_handler);
@@ -2790,6 +2790,8 @@ static int __qedi_probe(struct pci_dev *pdev, int mode)
 
 	return 0;
 
+free_tmf_thread:
+	destroy_workqueue(qedi->tmf_thread);
 free_cid_que:
 	qedi_release_cid_que(qedi);
 free_uio:
-- 
2.23.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] scsi: qedi: fix missing destroy_workqueue() on error in __qedi_probe
  2020-11-09  9:15 [PATCH] scsi: qedi: fix missing destroy_workqueue() on error in __qedi_probe Qinglang Miao
@ 2020-12-02 19:27 ` Mike Christie
  2020-12-09 17:23 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Mike Christie @ 2020-12-02 19:27 UTC (permalink / raw)
  To: Qinglang Miao, Nilesh Javali, Manish Rangankar,
	GR-QLogic-Storage-Upstream, James E.J. Bottomley,
	Martin K. Petersen
  Cc: linux-scsi, linux-kernel

On 11/9/20 3:15 AM, Qinglang Miao wrote:
> Add the missing destroy_workqueue() before return from
> __qedi_probe in the error handling case when fails to
> create workqueue qedi->offload_thread.
> 
> Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver framework.")
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
> ---
>  drivers/scsi/qedi/qedi_main.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
> index 61fab01d2d52..f5fc7f518f8a 100644
> --- a/drivers/scsi/qedi/qedi_main.c
> +++ b/drivers/scsi/qedi/qedi_main.c
> @@ -2766,7 +2766,7 @@ static int __qedi_probe(struct pci_dev *pdev, int mode)
>  			QEDI_ERR(&qedi->dbg_ctx,
>  				 "Unable to start offload thread!\n");
>  			rc = -ENODEV;
> -			goto free_cid_que;
> +			goto free_tmf_thread;
>  		}
>  
>  		INIT_DELAYED_WORK(&qedi->recovery_work, qedi_recovery_handler);
> @@ -2790,6 +2790,8 @@ static int __qedi_probe(struct pci_dev *pdev, int mode)
>  
>  	return 0;
>  
> +free_tmf_thread:
> +	destroy_workqueue(qedi->tmf_thread);
>  free_cid_que:
>  	qedi_release_cid_que(qedi);
>  free_uio:
> 

Reviewed-by: Mike Christie <michael.christie@oracle.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] scsi: qedi: fix missing destroy_workqueue() on error in __qedi_probe
  2020-11-09  9:15 [PATCH] scsi: qedi: fix missing destroy_workqueue() on error in __qedi_probe Qinglang Miao
  2020-12-02 19:27 ` Mike Christie
@ 2020-12-09 17:23 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-12-09 17:23 UTC (permalink / raw)
  To: Qinglang Miao, James E.J. Bottomley, Nilesh Javali,
	Manish Rangankar, GR-QLogic-Storage-Upstream
  Cc: Martin K . Petersen, linux-scsi, linux-kernel

On Mon, 9 Nov 2020 17:15:18 +0800, Qinglang Miao wrote:

> Add the missing destroy_workqueue() before return from
> __qedi_probe in the error handling case when fails to
> create workqueue qedi->offload_thread.

Applied to 5.11/scsi-queue, thanks!

[1/1] scsi: qedi: fix missing destroy_workqueue() on error in __qedi_probe
      https://git.kernel.org/mkp/scsi/c/62eebd5247c4

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-12-09 17:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-09  9:15 [PATCH] scsi: qedi: fix missing destroy_workqueue() on error in __qedi_probe Qinglang Miao
2020-12-02 19:27 ` Mike Christie
2020-12-09 17:23 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).