From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "Ahmed S. Darwish" <a.darwish@linutronix.de>,
Finn Thain <fthain@telegraphics.com.au>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Sebastian A. Siewior" <bigeasy@linutronix.de>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Michael Schmitz <schmitzmic@gmail.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH v3] scsi: NCR5380: Remove context check
Date: Wed, 9 Dec 2020 12:23:13 -0500 [thread overview]
Message-ID: <160753457755.14816.7863858983010100701.b4-ty@oracle.com> (raw)
In-Reply-To: <20201206075157.19067-1-a.darwish@linutronix.de>
On Sun, 6 Dec 2020 08:51:57 +0100, Ahmed S. Darwish wrote:
> NCR5380_poll_politely2() uses in_interrupt() and irqs_disabled() to
> check if it is safe to sleep.
>
> Such usage in drivers is phased out and Linus clearly requested that
> code which changes behaviour depending on context should either be
> separated, or the context be explicitly conveyed in an argument passed
> by the caller.
>
> [...]
Applied to 5.11/scsi-queue, thanks!
[1/1] scsi: NCR5380: Remove context check
https://git.kernel.org/mkp/scsi/c/e7734ef14ead
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2020-12-09 17:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 6:46 [PATCH] scsi/NCR5380: Remove in_interrupt() test Finn Thain
2020-12-01 17:05 ` Sebastian Andrzej Siewior
2020-12-03 23:08 ` Finn Thain
2020-12-04 8:38 ` Geert Uytterhoeven
2020-12-04 16:08 ` Ahmed S. Darwish
2020-12-01 18:01 ` Michael Schmitz
2020-12-04 15:32 ` [PATCH v2] scsi: NCR5380: Remove context check Ahmed S. Darwish
2020-12-05 4:28 ` Finn Thain
2020-12-06 7:51 ` [PATCH v3] " Ahmed S. Darwish
2020-12-08 0:12 ` Finn Thain
2020-12-08 1:26 ` Martin K. Petersen
2020-12-09 17:23 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160753457755.14816.7863858983010100701.b4-ty@oracle.com \
--to=martin.petersen@oracle.com \
--cc=a.darwish@linutronix.de \
--cc=bigeasy@linutronix.de \
--cc=fthain@telegraphics.com.au \
--cc=geert@linux-m68k.org \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=schmitzmic@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).