From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D5FBC4361B for ; Fri, 11 Dec 2020 15:37:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC65023121 for ; Fri, 11 Dec 2020 15:37:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437625AbgLKPDq (ORCPT ); Fri, 11 Dec 2020 10:03:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:33300 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437570AbgLKPDK (ORCPT ); Fri, 11 Dec 2020 10:03:10 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C816922571; Fri, 11 Dec 2020 15:01:54 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1knjvc-000TxV-QC; Fri, 11 Dec 2020 15:01:53 +0000 From: Marc Zyngier To: shawnguo@kernel.org, linux@rasmusvillemoes.dk, leoyang.li@nxp.com, mark.rutland@arm.com, zhiqiang.hou@nxp.com, Biwen Li , robh+dt@kernel.org, tglx@linutronix.de, Lokesh Vutla Cc: xiaobo.xie@nxp.com, Hou Zhiqiang , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Biwen Li , linux-kernel@vger.kernel.org, jiafei.pan@nxp.com, Sekhar Nori , Nishanth Menon Subject: Re: [PATCH] irqchip/ti-sci-intr: Fix freeing of irqs Date: Fri, 11 Dec 2020 15:01:38 +0000 Message-Id: <160769813659.482133.15271657798818561633.b4-ty@kernel.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201102120631.11165-1-lokeshvutla@ti.com> References: <20201102120631.11165-1-lokeshvutla@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: shawnguo@kernel.org, linux@rasmusvillemoes.dk, leoyang.li@nxp.com, mark.rutland@arm.com, zhiqiang.hou@nxp.com, biwen.li@oss.nxp.com, robh+dt@kernel.org, tglx@linutronix.de, lokeshvutla@ti.com, xiaobo.xie@nxp.com, Zhiqiang.Hou@nxp.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, biwen.li@nxp.com, linux-kernel@vger.kernel.org, jiafei.pan@nxp.com, nsekhar@ti.com, nm@ti.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2 Nov 2020 17:36:31 +0530, Lokesh Vutla wrote: > ti_sci_intr_irq_domain_free() assumes that out_irq of intr is stored in > data->chip_data and uses it for calling ti_sci irq_free() and then > mark the out_irq as available resource. But ti_sci_intr_irq_domain_alloc() > is storing p_hwirq(parent's hardware irq) which is translated from out_irq. > This is causing resource leakage and eventually out_irq resources might > be exhausted. Fix ti_sci_intr_irq_domain_alloc() by storing the out_irq > in data->chip_data. Applied to irq/irqchip-next, thanks! [1/1] irqchip/ti-sci-intr: Fix freeing of irqs commit: fc6c7cd3878641fd43189f15697e7ad0871f5c1a Cheers, M. -- Without deviation from the norm, progress is not possible.