From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
Stanley Chu <stanley.chu@mediatek.com>,
Min Guo <min.guo@mediatek.com>, <dri-devel@lists.freedesktop.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>, <linux-usb@vger.kernel.org>,
Serge Semin <Sergey.Semin@baikalelectronics.ru>
Subject: Re: [PATCH v4 01/11] dt-bindings: usb: convert usb-device.txt to YAML schema
Date: Thu, 24 Dec 2020 15:26:39 +0800 [thread overview]
Message-ID: <1608794799.7499.2.camel@mhfsdcap03> (raw)
In-Reply-To: <20201221190937.GA369845@robh.at.kernel.org>
On Mon, 2020-12-21 at 12:09 -0700, Rob Herring wrote:
> On Wed, Dec 16, 2020 at 05:30:02PM +0800, Chunfeng Yun wrote:
> > Convert usb-device.txt to YAML schema usb-device.yaml
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> > v4: no changes, update dependent series:
> > https://patchwork.kernel.org/project/linux-usb/list/?series=399561
> > [v6,00/19] dt-bindings: usb: Add generic USB HCD, xHCI, DWC USB3 DT schema
[...]
> > diff --git a/Documentation/devicetree/bindings/usb/usb-device.yaml b/Documentation/devicetree/bindings/usb/usb-device.yaml
> > new file mode 100644
> > index 000000000000..f31d8a85d3e6
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/usb-device.yaml
> > @@ -0,0 +1,125 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/usb/usb-device.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: The device tree bindings for the Generic USB Device
> > +
> > +maintainers:
> > + - Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > +
> > +description: |
> > + Usually, we only use device tree for hard wired USB device.
> > + The reference binding doc is from:
> > + http://www.devicetree.org/open-firmware/bindings/usb/usb-1_0.ps
> > +
> > + Four types of device-tree nodes are defined: "host-controller nodes"
> > + representing USB host controllers, "device nodes" representing USB devices,
> > + "interface nodes" representing USB interfaces and "combined nodes"
> > + representing simple USB devices.
> > +
> > + A combined node shall be used instead of a device node and an interface node
> > + for devices of class 0 or 9 (hub) with a single configuration and a single
> > + interface.
> > +
> > + A "hub node" is a combined node or an interface node that represents a USB
> > + hub.
> > +
> > +properties:
> > + compatible:
> > + pattern: "^usb[0-9a-f]+,[0-9a-f]+$"
>
> You can refine the length allowed a bit: [0-9a-f]{1,4}
>
> Same applies elsewhere.
Ok
>
> > + description: Device nodes or combined nodes.
> > + "usbVID,PID", where VID is the vendor id and PID the product id.
> > + The textual representation of VID and PID shall be in lower case
> > + hexadecimal with leading zeroes suppressed. The other compatible
> > + strings from the above standard binding could also be used,
> > + but a device adhering to this binding may leave out all except
> > + for "usbVID,PID".
> > +
[...]
> > diff --git a/Documentation/devicetree/bindings/usb/usb-hcd.yaml b/Documentation/devicetree/bindings/usb/usb-hcd.yaml
> > index 9881ac10380d..5d0c6b5500d6 100755
> > --- a/Documentation/devicetree/bindings/usb/usb-hcd.yaml
> > +++ b/Documentation/devicetree/bindings/usb/usb-hcd.yaml
> > @@ -23,6 +23,32 @@ properties:
> > targeted hosts (non-PC hosts).
> > type: boolean
> >
> > + "#address-cells":
> > + const: 1
> > +
> > + "#size-cells":
> > + const: 0
> > +
> > +patternProperties:
> > + "@[0-9a-f]+$":
> > + type: object
> > + description: The hard wired USB devices
> > +
> > + properties:
> > + compatible:
> > + pattern: "^usb[0-9a-f]+,[0-9a-f]+$"
> > + $ref: /usb/usb-device.yaml
>
> This is wrong. It should be up a level.
Ok
> And no need to define
> 'compatible' or 'reg' here because those are defined within
> usb-device.yaml.
will drop it
>
> > + description: the string is 'usbVID,PID', where VID is the vendor id
> > + and PID is the product id
> > +
> > + reg:
> > + $ref: /usb/usb-device.yaml
> > + maxItems: 1
> > +
> > + required:
> > + - compatible
> > + - reg
> > +
> > additionalProperties: true
> >
> > examples:
> > @@ -30,4 +56,11 @@ examples:
> > usb {
> > phys = <&usb2_phy1>, <&usb3_phy1>;
> > phy-names = "usb";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + hub@1 {
> > + compatible = "usb5e3,610";
> > + reg = <1>;
> > + };
> > };
> > --
> > 2.18.0
> >
prev parent reply other threads:[~2020-12-24 7:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 9:30 [PATCH v4 01/11] dt-bindings: usb: convert usb-device.txt to YAML schema Chunfeng Yun
2020-12-16 9:30 ` [PATCH v4 02/11] dt-bindings: net: btusb: change reference file name Chunfeng Yun
2020-12-21 19:09 ` Rob Herring
2020-12-16 9:30 ` [PATCH v4 03/11] dt-bindings: phy: convert phy-mtk-xsphy.txt to YAML schema Chunfeng Yun
2020-12-16 9:30 ` [PATCH v4 04/11] dt-bindings: phy: convert phy-mtk-tphy.txt " Chunfeng Yun
2020-12-16 9:30 ` [PATCH v4 05/11] dt-bindings: phy: convert phy-mtk-ufs.txt " Chunfeng Yun
2020-12-16 9:30 ` [PATCH v4 06/11] dt-bindings: phy: convert HDMI PHY binding " Chunfeng Yun
2020-12-24 0:24 ` Chun-Kuang Hu
2020-12-16 9:30 ` [PATCH v4 07/11] dt-bindings: phy: convert MIPI DSI " Chunfeng Yun
2020-12-21 19:11 ` Rob Herring
2020-12-24 0:26 ` Chun-Kuang Hu
2020-12-16 9:30 ` [PATCH v4 08/11] dt-bindings: usb: convert mediatek,musb.txt " Chunfeng Yun
2020-12-16 9:30 ` [PATCH v4 09/11] dt-bindings: usb: convert mediatek,mtk-xhci.txt " Chunfeng Yun
2020-12-21 19:23 ` Rob Herring
2020-12-24 8:39 ` Chunfeng Yun
2020-12-16 9:30 ` [PATCH v4 10/11] dt-bindings: usb: convert mediatek,mtu3.txt " Chunfeng Yun
2020-12-21 19:26 ` Rob Herring
2020-12-25 1:44 ` Chunfeng Yun
2020-12-16 9:30 ` [PATCH v4 11/11] MAINTAINERS: update MediaTek PHY/USB entry Chunfeng Yun
2020-12-21 19:09 ` [PATCH v4 01/11] dt-bindings: usb: convert usb-device.txt to YAML schema Rob Herring
2020-12-24 7:26 ` Chunfeng Yun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1608794799.7499.2.camel@mhfsdcap03 \
--to=chunfeng.yun@mediatek.com \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=airlied@linux.ie \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=min.guo@mediatek.com \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=stanley.chu@mediatek.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).