From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753463AbcKHPLZ (ORCPT ); Tue, 8 Nov 2016 10:11:25 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:53065 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751503AbcKHPLL (ORCPT ); Tue, 8 Nov 2016 10:11:11 -0500 From: Arnd Bergmann To: John Garry Cc: linux-arm-kernel@lists.infradead.org, Anurup M , anurup.m@huawei.com, linux-kernel@vger.kernel.org, mark.rutland@arm.com, shyju.pv@huawei.com, gabriele.paoloni@huawei.com, will.deacon@arm.com, linuxarm@huawei.com, xuwei5@hisilicon.com, zhangshaokun@hisilicon.com, sanil.kumar@hisilicon.com, tanxiaojun@huawei.com, shiju.jose@huawei.com Subject: Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver Date: Tue, 08 Nov 2016 16:10:23 +0100 Message-ID: <1609380.NN50qvVsP7@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <2bac1a34-591b-6557-15bf-40db25c3d129@huawei.com> References: <1478101374-18778-1-git-send-email-anurup.m@huawei.com> <2030692.HPgjBCTYG6@wuerfel> <2bac1a34-591b-6557-15bf-40db25c3d129@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:ITNeWRc7BO/MecRBWZ5EaTB4PCPCCDpvLXZzwsFQEUiRADqqilr ClQuBznH8crxtySvcriDy/u0aMUyG412xIqz0Je+Zez5nFMukBQUAAdEv05A9c0pmsuclty /Z0XqKnCkvPkaF6PEIfIY6FKos2tdX767d48sZQXxPY1PIDgHPK2Z1olVt81+RI1e2+rET3 rtNz+20ti/YKO1meYX7gw== X-UI-Out-Filterresults: notjunk:1;V01:K0:1CuMSP6RjGs=:/XzQ3sH1qx7txdtYzXVgZo d+A0E3GUB2drPspxNsxPFbyWY9gUTvvrUDU5FYHK2osfHc+pOQbqo4fevUtXqZxMMnvECByLk mQjLc2ZI/2qmTxZTzXGG15FoVgQ3PsLpSTrIxQHrfsQPNa93BpH4P1r9Ra2tpojM/syZH599g sdPlja5QJ9SdsHrmoGtJynmsJbGTr+Q/jb4CBpbGJe9ib4hFaqh16kz296xA75qpWuwNMPQdn VKYF5Fw3opwNj0vNuKVoGfoVI8tYctpt1PXEkQIhLge1RcTlTvl25tPJv5bSg+IBDDOECA8SC bbbb7WRPz7DF1aVE13orzT2XsHpgsUVAHbebZXeNod25JrV1AH5jjlbvkKKQNiBYvXuswxK1S IgEez04S036o79KUk3kPv7g6SIXpKGZ0Pj+6hRSMso9HLSk5wirIsARK4GoFsJnVbDA3lZXb0 qmjOV/DshGV9ju5dzNGBUyVJGgtfQGuKFvdMXsbAFMW55+zJVnwf9n1eTDq33q6TpdRBv3Kgi Ozgn7iHy4MBJT+tYhJ0nB3eX6QhmSFEbR5zNPthOthyTLTUfY4dlOHicrCuaVge1rnZpTAikR cYulIqNLqSw7d0jkGLLVYXcdjXvJhpdGGSq7FWPqANLOZT7adMxJBSkOxmMxQFS/3efQ6PCyD mKJfJwiGrLPEqwKSN4GY8Sag5+oONza4RWYDsJTNpMdyZn/tbP/LYL0MpPeHiCKS4U0U8SF3L oAc5IovZijioscIt Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, November 8, 2016 1:49:43 PM CET John Garry wrote: > > Hi Arnd, > > Thanks for the reference. > > I think the i2c interface doesn't fully satisfy our requirements as we > need more than just a slave bus address when accessing the slave device > (which I think is what i2c uses). We also need to pass "offset" and > "mod_mask" arguments to the djtag adapter to access specific registers > in the slave device. Ok. Are those values constant per device, or maybe a range? We may want to include those in the reg property as well then. Arnd