From: Marc Zyngier <maz@kernel.org>
To: Steven Price <steven.price@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, <kvmarm@lists.cs.columbia.edu>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, James Morse <james.morse@arm.com>,
Julien Thierry <julien.thierry.kdev@gmail.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>
Subject: Re: [PATCH 1/2] arm64: Rename WORKAROUND_1165522 to SPECULATIVE_AT
Date: Mon, 11 Nov 2019 16:51:41 +0109 [thread overview]
Message-ID: <160a852027f4481cc63aed72c4f4a409@www.loen.fr> (raw)
In-Reply-To: <20191111141157.55062-2-steven.price@arm.com>
Hi Steven,
On 2019-11-11 15:21, Steven Price wrote:
> Cortex-A55 is affected by a similar erratum, so rename the existing
> workaround for errarum 1165522 so it can be used for both errata.
nit: erratum
>
> Signed-off-by: Steven Price <steven.price@arm.com>
> ---
> arch/arm64/Kconfig | 4 ++++
> arch/arm64/include/asm/cpucaps.h | 2 +-
> arch/arm64/include/asm/kvm_host.h | 2 +-
> arch/arm64/include/asm/kvm_hyp.h | 3 +--
> arch/arm64/kernel/cpu_errata.c | 17 +++++++++++++----
> arch/arm64/kvm/hyp/switch.c | 2 +-
> arch/arm64/kvm/hyp/tlb.c | 4 ++--
> 7 files changed, 23 insertions(+), 11 deletions(-)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 3f047afb982c..6cb4eff602c6 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -510,9 +510,13 @@ config ARM64_ERRATUM_1418040
>
> If unsure, say Y.
>
> +config ARM64_WORKAROUND_SPECULATIVE_AT
> + bool
> +
> config ARM64_ERRATUM_1165522
> bool "Cortex-A76: Speculative AT instruction using out-of-context
> translation regime could cause subsequent request to generate an
> incorrect translation"
> default y
> + select ARM64_WORKAROUND_SPECULATIVE_AT
I'd object that ARM64_ERRATUM_1319367 (and its big brother 1319537)
are also related to speculative AT execution, and yet are not covered
by this configuration symbol.
I can see three solutions to this:
- Either you call it SPECULATIVE_AT_VHE and introduce
SPECULATIVE_AT_NVHE
for symmetry
- Or you make SPECULATIVE_AT cover all the speculative AT errata, which
may or may not work...
- Or even better, you just ammend the documentation to say that 1165522
also covers the newly found A55 one (just like we have for A57/A72)
What do you think?
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2019-11-11 15:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 14:11 [PATCH 0/2] arm64: Workaround for Cortex-A55 erratum 1530923 Steven Price
2019-11-11 14:11 ` [PATCH 1/2] arm64: Rename WORKAROUND_1165522 to SPECULATIVE_AT Steven Price
2019-11-11 15:42 ` Marc Zyngier [this message]
2019-11-11 16:07 ` Steven Price
2019-11-11 17:16 ` Mark Rutland
2019-11-11 14:11 ` [PATCH 2/2] arm64: Workaround for Cortex-A55 erratum 1530923 Steven Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160a852027f4481cc63aed72c4f4a409@www.loen.fr \
--to=maz@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=julien.thierry.kdev@gmail.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steven.price@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).