From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32097C433DB for ; Tue, 12 Jan 2021 02:05:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 04FA122E01 for ; Tue, 12 Jan 2021 02:05:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727396AbhALCE6 (ORCPT ); Mon, 11 Jan 2021 21:04:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727090AbhALCE5 (ORCPT ); Mon, 11 Jan 2021 21:04:57 -0500 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B547C061786 for ; Mon, 11 Jan 2021 18:04:17 -0800 (PST) Received: by mail-pl1-x636.google.com with SMTP id s15so533968plr.9 for ; Mon, 11 Jan 2021 18:04:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:content-transfer-encoding:in-reply-to:references :subject:from:cc:to:date:message-id:user-agent; bh=fe2mkczbp1t/E/ldhMQUrkd5DSYed87fCtNvZY007Ik=; b=KJ/unG0DMwgO8FOHpLwA0BAGGO8yEgZ0kZmUxPC2a4zmth9V3xtzyqeig3Fj9AosUm Nxx6FqOXJ22uU4SceH/4Ut1DoTDtq0wiufH6sm1hDw2NoCos08qzi5O8ZEHp549VhhdH G6rzgxxZaKzCJTzqc5lC5Lk3bne9QbGLcaJzE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding :in-reply-to:references:subject:from:cc:to:date:message-id :user-agent; bh=fe2mkczbp1t/E/ldhMQUrkd5DSYed87fCtNvZY007Ik=; b=XvRGaPUpQ5cr5dgvS1sZ21Ol0jdwIYIEhE+p4QETzEw92BQQmOWzoJNKxyH20MsRwG 2Ui4m/LansRctfQCAbUsQYBJggQzLEAJWoNFopJVeAS/f5JVhjy3JfFVYGpUbfH9P5Ip ywQQU1CyAafUwKqMj41XumoAqHhp+sYoS+062D1qSxiPRsRsrymWctGpXV+8NfUjZhtT hJtgnd4reXFEcXXpExId4k3h1A9CD9g8l96xMF06rtNxH/84Mg3WIPruCZcVtEtnGGNh lnCb5qMUw5IsBRj+YU666XPxH6CC9hxZNRPF4fYMQz1tC9sQrrnqIQ8oEa0h43knUMH/ vr9Q== X-Gm-Message-State: AOAM5330AhBg7IBJQuAf7VidI3y0HCy9c3tGkRnokU2QWyV5LVzYKcfF 5LvJ3X29PtS6FLp3LXU8C4Yvvg== X-Google-Smtp-Source: ABdhPJyN19svv59QhQEu8hZ7lIHMauMtWTxanOuICr3xOYCM6BMmfN2oPXquM0xU9ModjRJKMdbuWA== X-Received: by 2002:a17:90a:ad82:: with SMTP id s2mr1819632pjq.167.1610417056650; Mon, 11 Jan 2021 18:04:16 -0800 (PST) Received: from chromium.org ([2620:15c:202:201:3e52:82ff:fe6c:83ab]) by smtp.gmail.com with ESMTPSA id h8sm936536pjc.2.2021.01.11.18.04.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 18:04:15 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <20201216071926.3147108-1-swboyd@chromium.org> Subject: Re: [PATCH] soc: qcom: socinfo: Open read access to all for debugfs From: Stephen Boyd Cc: Andy Gross , Bjorn Andersson , LKML , linux-arm-msm , Sai Prakash Ranjan , Dmitry Baryshkov To: Doug Anderson Date: Mon, 11 Jan 2021 18:04:13 -0800 Message-ID: <161041705349.3661239.3305335724733202161@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Doug Anderson (2021-01-05 15:06:35) > Hi, >=20 > On Tue, Dec 15, 2020 at 11:19 PM Stephen Boyd wrote: > > > > There doesn't seem to be any reason to limit this to only root user > > readable. Let's make it readable by all so that random programs can > > read the debugfs files in here instead of just root. The information is > > just that, informational, so this is fine. > > > > Cc: Sai Prakash Ranjan > > Cc: Douglas Anderson > > Cc: Dmitry Baryshkov > > Signed-off-by: Stephen Boyd > > --- > > drivers/soc/qcom/socinfo.c | 40 +++++++++++++++++++------------------- > > 1 file changed, 20 insertions(+), 20 deletions(-) >=20 > One worry I'd have is whether there would ever be any PII (personally > identifiable information) here, like maybe a chip serial number. If > so, is that something that is OK to provide to any random process? > ...maybe I'm just being paranoid though, since presumably there are > enough random HW characteristics that could be strung together and > hashed to make roughly a unique ID anyway and hiding every HW > characteristic would be a bit extreme... >=20 I suppose if that's a problem then the process that mounts debugfs can change the access to restrict it. I'm not aware of this needing to be a kernel policy though, so I'd rather leave that up to userspace to decide if it should be restricted further.