* [PATCH RESEND v4 01/11] usb: gadget: bdc: fix improper SPDX comment style for header file
@ 2021-01-13 2:42 Chunfeng Yun
2021-01-13 2:42 ` [PATCH RESEND v4 02/11] usb: gadget: bdc: remove bdc_ep_set_halt() declaration Chunfeng Yun
` (10 more replies)
0 siblings, 11 replies; 23+ messages in thread
From: Chunfeng Yun @ 2021-01-13 2:42 UTC (permalink / raw)
To: Felipe Balbi
Cc: Florian Fainelli, Al Cooper, Greg Kroah-Hartman,
Matthias Brugger, linux-usb, bcm-kernel-feedback-list,
linux-kernel, linux-arm-kernel, linux-mediatek, Chunfeng Yun
For C header files Documentation/process/license-rules.rst
mandates C-like comments (opposed to C source files where
C++ style should be used).
Cc: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
---
v4 resend: base on kernel 5.11-rc1
v4: no changes, but rebase on kernel 5.10-rc1
v3: add acked-by Florian
v2: add Cc Florian
---
drivers/usb/gadget/udc/bdc/bdc.h | 2 +-
drivers/usb/gadget/udc/bdc/bdc_cmd.h | 2 +-
drivers/usb/gadget/udc/bdc/bdc_dbg.h | 2 +-
drivers/usb/gadget/udc/bdc/bdc_ep.h | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/gadget/udc/bdc/bdc.h b/drivers/usb/gadget/udc/bdc/bdc.h
index ac75e25c3b6a..fcba77e42fd1 100644
--- a/drivers/usb/gadget/udc/bdc/bdc.h
+++ b/drivers/usb/gadget/udc/bdc/bdc.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
/*
* bdc.h - header for the BRCM BDC USB3.0 device controller
*
diff --git a/drivers/usb/gadget/udc/bdc/bdc_cmd.h b/drivers/usb/gadget/udc/bdc/bdc_cmd.h
index 29cc988a671a..373e674809e9 100644
--- a/drivers/usb/gadget/udc/bdc/bdc_cmd.h
+++ b/drivers/usb/gadget/udc/bdc/bdc_cmd.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
/*
* bdc_cmd.h - header for the BDC debug functions
*
diff --git a/drivers/usb/gadget/udc/bdc/bdc_dbg.h b/drivers/usb/gadget/udc/bdc/bdc_dbg.h
index 373d5abffbb8..859d588e209d 100644
--- a/drivers/usb/gadget/udc/bdc/bdc_dbg.h
+++ b/drivers/usb/gadget/udc/bdc/bdc_dbg.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
/*
* bdc_dbg.h - header for the BDC debug functions
*
diff --git a/drivers/usb/gadget/udc/bdc/bdc_ep.h b/drivers/usb/gadget/udc/bdc/bdc_ep.h
index a37ff8033b4f..5bbd73f99c6f 100644
--- a/drivers/usb/gadget/udc/bdc/bdc_ep.h
+++ b/drivers/usb/gadget/udc/bdc/bdc_ep.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
/*
* bdc_ep.h - header for the BDC debug functions
*
--
2.18.0
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH RESEND v4 02/11] usb: gadget: bdc: remove bdc_ep_set_halt() declaration
2021-01-13 2:42 [PATCH RESEND v4 01/11] usb: gadget: bdc: fix improper SPDX comment style for header file Chunfeng Yun
@ 2021-01-13 2:42 ` Chunfeng Yun
2021-01-13 8:41 ` Felipe Balbi
2021-01-13 2:42 ` [PATCH RESEND v4 03/11] usb: gadget: bdc: prefer pointer dereference to pointer type Chunfeng Yun
` (9 subsequent siblings)
10 siblings, 1 reply; 23+ messages in thread
From: Chunfeng Yun @ 2021-01-13 2:42 UTC (permalink / raw)
To: Felipe Balbi
Cc: Florian Fainelli, Al Cooper, Greg Kroah-Hartman,
Matthias Brugger, linux-usb, bcm-kernel-feedback-list,
linux-kernel, linux-arm-kernel, linux-mediatek, Chunfeng Yun
No definition for bdc_ep_set_halt(), so remove it.
Cc: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
---
v4 resend: base on kernel 5.11-rc1
v4: no changes, but rebase on kernel 5.10-rc1
v3: add acked-by Florian
v2: add Cc Florian
---
drivers/usb/gadget/udc/bdc/bdc_cmd.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/bdc/bdc_cmd.h b/drivers/usb/gadget/udc/bdc/bdc_cmd.h
index 373e674809e9..a3a6dbd0022c 100644
--- a/drivers/usb/gadget/udc/bdc/bdc_cmd.h
+++ b/drivers/usb/gadget/udc/bdc/bdc_cmd.h
@@ -16,7 +16,6 @@ int bdc_dconfig_ep(struct bdc *, struct bdc_ep *);
int bdc_stop_ep(struct bdc *, int);
int bdc_ep_set_stall(struct bdc *, int);
int bdc_ep_clear_stall(struct bdc *, int);
-int bdc_ep_set_halt(struct bdc_ep *, u32 , int);
int bdc_ep_bla(struct bdc *, struct bdc_ep *, dma_addr_t);
int bdc_function_wake(struct bdc*, u8);
int bdc_function_wake_fh(struct bdc*, u8);
--
2.18.0
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH RESEND v4 03/11] usb: gadget: bdc: prefer pointer dereference to pointer type
2021-01-13 2:42 [PATCH RESEND v4 01/11] usb: gadget: bdc: fix improper SPDX comment style for header file Chunfeng Yun
2021-01-13 2:42 ` [PATCH RESEND v4 02/11] usb: gadget: bdc: remove bdc_ep_set_halt() declaration Chunfeng Yun
@ 2021-01-13 2:42 ` Chunfeng Yun
2021-01-13 8:41 ` Felipe Balbi
2021-01-13 2:42 ` [PATCH RESEND v4 04/11] usb: gadget: bdc: fix warning of embedded function name Chunfeng Yun
` (8 subsequent siblings)
10 siblings, 1 reply; 23+ messages in thread
From: Chunfeng Yun @ 2021-01-13 2:42 UTC (permalink / raw)
To: Felipe Balbi
Cc: Florian Fainelli, Al Cooper, Greg Kroah-Hartman,
Matthias Brugger, linux-usb, bcm-kernel-feedback-list,
linux-kernel, linux-arm-kernel, linux-mediatek, Chunfeng Yun
Prefer kzalloc(sizeof(*bd_table)...) over
kzalloc(sizeof(struct bd_table)
Cc: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
---
v4 resend: base on kernel 5.11-rc1
v4: no changes, but rebase on kernel 5.10-rc1
v3: add acked-by Florian
v2: add Cc Florian
---
drivers/usb/gadget/udc/bdc/bdc_ep.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/bdc/bdc_ep.c b/drivers/usb/gadget/udc/bdc/bdc_ep.c
index fafdc9fdb4a5..76463de75595 100644
--- a/drivers/usb/gadget/udc/bdc/bdc_ep.c
+++ b/drivers/usb/gadget/udc/bdc/bdc_ep.c
@@ -147,7 +147,7 @@ static int ep_bd_list_alloc(struct bdc_ep *ep)
/* Allocate memory for each table */
for (index = 0; index < num_tabs; index++) {
/* Allocate memory for bd_table structure */
- bd_table = kzalloc(sizeof(struct bd_table), GFP_ATOMIC);
+ bd_table = kzalloc(sizeof(*bd_table), GFP_ATOMIC);
if (!bd_table)
goto fail;
--
2.18.0
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH RESEND v4 04/11] usb: gadget: bdc: fix warning of embedded function name
2021-01-13 2:42 [PATCH RESEND v4 01/11] usb: gadget: bdc: fix improper SPDX comment style for header file Chunfeng Yun
2021-01-13 2:42 ` [PATCH RESEND v4 02/11] usb: gadget: bdc: remove bdc_ep_set_halt() declaration Chunfeng Yun
2021-01-13 2:42 ` [PATCH RESEND v4 03/11] usb: gadget: bdc: prefer pointer dereference to pointer type Chunfeng Yun
@ 2021-01-13 2:42 ` Chunfeng Yun
2021-01-13 8:42 ` Felipe Balbi
2021-01-13 2:42 ` [PATCH RESEND v4 05/11] usb: gadget: bdc: fix check warning of block comments alignment Chunfeng Yun
` (7 subsequent siblings)
10 siblings, 1 reply; 23+ messages in thread
From: Chunfeng Yun @ 2021-01-13 2:42 UTC (permalink / raw)
To: Felipe Balbi
Cc: Florian Fainelli, Al Cooper, Greg Kroah-Hartman,
Matthias Brugger, linux-usb, bcm-kernel-feedback-list,
linux-kernel, linux-arm-kernel, linux-mediatek, Chunfeng Yun
Use '"%s...", __func__' to replace embedded function name
Cc: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
---
v4 resend: base on kernel 5.11-rc1
v4: no changes, but rebase on kernel 5.10-rc1
v3: add acked-by Florian
v2: add Cc Florian
---
drivers/usb/gadget/udc/bdc/bdc_dbg.c | 2 +-
drivers/usb/gadget/udc/bdc/bdc_ep.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/gadget/udc/bdc/bdc_dbg.c b/drivers/usb/gadget/udc/bdc/bdc_dbg.c
index 7ba7448ad743..9c03e13308ca 100644
--- a/drivers/usb/gadget/udc/bdc/bdc_dbg.c
+++ b/drivers/usb/gadget/udc/bdc/bdc_dbg.c
@@ -68,7 +68,7 @@ void bdc_dbg_srr(struct bdc *bdc, u32 srr_num)
sr = bdc->srr.sr_bds;
addr = bdc->srr.dma_addr;
- dev_vdbg(bdc->dev, "bdc_dbg_srr sr:%p dqp_index:%d\n",
+ dev_vdbg(bdc->dev, "%s sr:%p dqp_index:%d\n", __func__,
sr, bdc->srr.dqp_index);
for (i = 0; i < NUM_SR_ENTRIES; i++) {
sr = &bdc->srr.sr_bds[i];
diff --git a/drivers/usb/gadget/udc/bdc/bdc_ep.c b/drivers/usb/gadget/udc/bdc/bdc_ep.c
index 76463de75595..44f3a122546d 100644
--- a/drivers/usb/gadget/udc/bdc/bdc_ep.c
+++ b/drivers/usb/gadget/udc/bdc/bdc_ep.c
@@ -756,7 +756,7 @@ static int ep_dequeue(struct bdc_ep *ep, struct bdc_req *req)
dev_dbg(bdc->dev, "%s ep:%s start:%d end:%d\n",
__func__, ep->name, start_bdi, end_bdi);
- dev_dbg(bdc->dev, "ep_dequeue ep=%p ep->desc=%p\n",
+ dev_dbg(bdc->dev, "%s ep=%p ep->desc=%p\n", __func__,
ep, (void *)ep->usb_ep.desc);
/* if still connected, stop the ep to see where the HW is ? */
if (!(bdc_readl(bdc->regs, BDC_USPC) & BDC_PST_MASK)) {
@@ -1858,12 +1858,12 @@ static int bdc_gadget_ep_enable(struct usb_ep *_ep,
int ret;
if (!_ep || !desc || desc->bDescriptorType != USB_DT_ENDPOINT) {
- pr_debug("bdc_gadget_ep_enable invalid parameters\n");
+ pr_debug("%s invalid parameters\n", __func__);
return -EINVAL;
}
if (!desc->wMaxPacketSize) {
- pr_debug("bdc_gadget_ep_enable missing wMaxPacketSize\n");
+ pr_debug("%s missing wMaxPacketSize\n", __func__);
return -EINVAL;
}
--
2.18.0
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH RESEND v4 05/11] usb: gadget: bdc: fix check warning of block comments alignment
2021-01-13 2:42 [PATCH RESEND v4 01/11] usb: gadget: bdc: fix improper SPDX comment style for header file Chunfeng Yun
` (2 preceding siblings ...)
2021-01-13 2:42 ` [PATCH RESEND v4 04/11] usb: gadget: bdc: fix warning of embedded function name Chunfeng Yun
@ 2021-01-13 2:42 ` Chunfeng Yun
2021-01-13 8:43 ` Felipe Balbi
2021-01-13 2:42 ` [PATCH RESEND v4 06/11] usb: gadget: bdc: add identifier name for function declaraion Chunfeng Yun
` (6 subsequent siblings)
10 siblings, 1 reply; 23+ messages in thread
From: Chunfeng Yun @ 2021-01-13 2:42 UTC (permalink / raw)
To: Felipe Balbi
Cc: Florian Fainelli, Al Cooper, Greg Kroah-Hartman,
Matthias Brugger, linux-usb, bcm-kernel-feedback-list,
linux-kernel, linux-arm-kernel, linux-mediatek, Chunfeng Yun
fix the warning:
WARNING:BLOCK_COMMENT_STYLE:
Block comments should align the * on each line
Cc: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
---
v4 resend: base on kernel 5.11-rc1
v4: no changes, but rebase on kernel 5.10-rc1
v3: add acked-by Florian
v2: add Cc Florian
---
drivers/usb/gadget/udc/bdc/bdc.h | 2 +-
drivers/usb/gadget/udc/bdc/bdc_ep.c | 2 +-
drivers/usb/gadget/udc/bdc/bdc_udc.c | 6 +++---
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/gadget/udc/bdc/bdc.h b/drivers/usb/gadget/udc/bdc/bdc.h
index fcba77e42fd1..c0ee735bd887 100644
--- a/drivers/usb/gadget/udc/bdc/bdc.h
+++ b/drivers/usb/gadget/udc/bdc/bdc.h
@@ -35,7 +35,7 @@
/*
* Maximum size of ep0 response buffer for ch9 requests,
* the set_sel request uses 6 so far, the max.
-*/
+ */
#define EP0_RESPONSE_BUFF 6
/* Start with SS as default */
#define EP0_MAX_PKT_SIZE 512
diff --git a/drivers/usb/gadget/udc/bdc/bdc_ep.c b/drivers/usb/gadget/udc/bdc/bdc_ep.c
index 44f3a122546d..3fb36c8454fc 100644
--- a/drivers/usb/gadget/udc/bdc/bdc_ep.c
+++ b/drivers/usb/gadget/udc/bdc/bdc_ep.c
@@ -68,7 +68,7 @@ static void ep_bd_list_free(struct bdc_ep *ep, u32 num_tabs)
* check if the bd_table struct is allocated ?
* if yes, then check if bd memory has been allocated, then
* free the dma_pool and also the bd_table struct memory
- */
+ */
bd_table = bd_list->bd_table_array[index];
dev_dbg(bdc->dev, "bd_table:%p index:%d\n", bd_table, index);
if (!bd_table) {
diff --git a/drivers/usb/gadget/udc/bdc/bdc_udc.c b/drivers/usb/gadget/udc/bdc/bdc_udc.c
index 248426a3e88a..0c1ab9548786 100644
--- a/drivers/usb/gadget/udc/bdc/bdc_udc.c
+++ b/drivers/usb/gadget/udc/bdc/bdc_udc.c
@@ -164,7 +164,7 @@ static void bdc_func_wake_timer(struct work_struct *work)
/*
* Check if host has started transferring on endpoints
* FUNC_WAKE_ISSUED is cleared when transfer has started after resume
- */
+ */
if (bdc->devstatus & FUNC_WAKE_ISSUED) {
dev_dbg(bdc->dev, "FUNC_WAKE_ISSUED FLAG IS STILL SET\n");
/* flag is still set, so again send func wake */
@@ -205,7 +205,7 @@ static void handle_link_state_change(struct bdc *bdc, u32 uspc)
* if not then send function wake again every
* TNotification secs until host initiates
* transfer to BDC, USB3 spec Table 8.13
- */
+ */
schedule_delayed_work(
&bdc->func_wake_notify,
msecs_to_jiffies(BDC_TNOTIFY));
@@ -379,7 +379,7 @@ static int bdc_udc_start(struct usb_gadget *gadget,
* Run the controller from here and when BDC is connected to
* Host then driver will receive a USPC SR with VBUS present
* and then driver will do a softconnect.
- */
+ */
ret = bdc_run(bdc);
if (ret) {
dev_err(bdc->dev, "%s bdc run fail\n", __func__);
--
2.18.0
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH RESEND v4 06/11] usb: gadget: bdc: add identifier name for function declaraion
2021-01-13 2:42 [PATCH RESEND v4 01/11] usb: gadget: bdc: fix improper SPDX comment style for header file Chunfeng Yun
` (3 preceding siblings ...)
2021-01-13 2:42 ` [PATCH RESEND v4 05/11] usb: gadget: bdc: fix check warning of block comments alignment Chunfeng Yun
@ 2021-01-13 2:42 ` Chunfeng Yun
2021-01-13 8:43 ` Felipe Balbi
2021-01-13 2:42 ` [PATCH RESEND v4 07/11] usb: gadget: bdc: avoid precedence issues Chunfeng Yun
` (5 subsequent siblings)
10 siblings, 1 reply; 23+ messages in thread
From: Chunfeng Yun @ 2021-01-13 2:42 UTC (permalink / raw)
To: Felipe Balbi
Cc: Florian Fainelli, Al Cooper, Greg Kroah-Hartman,
Matthias Brugger, linux-usb, bcm-kernel-feedback-list,
linux-kernel, linux-arm-kernel, linux-mediatek, Chunfeng Yun
This is used to avoid the warning of function arguments, e.g.
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32'
should also have an identifier name
Cc: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
---
v4 resend: base on kernel 5.11-rc1
v4: no changes, but rebase on kernel 5.10-rc1
v3: add acked-by Florian
v2: add Cc Florian
---
drivers/usb/gadget/udc/bdc/bdc.h | 28 ++++++++++++++--------------
drivers/usb/gadget/udc/bdc/bdc_cmd.h | 18 +++++++++---------
drivers/usb/gadget/udc/bdc/bdc_dbg.h | 8 ++++----
drivers/usb/gadget/udc/bdc/bdc_ep.h | 8 ++++----
4 files changed, 31 insertions(+), 31 deletions(-)
diff --git a/drivers/usb/gadget/udc/bdc/bdc.h b/drivers/usb/gadget/udc/bdc/bdc.h
index c0ee735bd887..658abeff59d4 100644
--- a/drivers/usb/gadget/udc/bdc/bdc.h
+++ b/drivers/usb/gadget/udc/bdc/bdc.h
@@ -466,24 +466,24 @@ static inline void bdc_writel(void __iomem *base, u32 offset, u32 value)
}
/* Buffer descriptor list operations */
-void bdc_notify_xfr(struct bdc *, u32);
-void bdc_softconn(struct bdc *);
-void bdc_softdisconn(struct bdc *);
-int bdc_run(struct bdc *);
-int bdc_stop(struct bdc *);
-int bdc_reset(struct bdc *);
-int bdc_udc_init(struct bdc *);
-void bdc_udc_exit(struct bdc *);
-int bdc_reinit(struct bdc *);
+void bdc_notify_xfr(struct bdc *bdc, u32 epnum);
+void bdc_softconn(struct bdc *bdc);
+void bdc_softdisconn(struct bdc *bdc);
+int bdc_run(struct bdc *bdc);
+int bdc_stop(struct bdc *bdc);
+int bdc_reset(struct bdc *bdc);
+int bdc_udc_init(struct bdc *bdc);
+void bdc_udc_exit(struct bdc *bdc);
+int bdc_reinit(struct bdc *bdc);
/* Status report handlers */
/* Upstream port status change sr */
-void bdc_sr_uspc(struct bdc *, struct bdc_sr *);
+void bdc_sr_uspc(struct bdc *bdc, struct bdc_sr *sreport);
/* transfer sr */
-void bdc_sr_xsf(struct bdc *, struct bdc_sr *);
+void bdc_sr_xsf(struct bdc *bdc, struct bdc_sr *sreport);
/* EP0 XSF handlers */
-void bdc_xsf_ep0_setup_recv(struct bdc *, struct bdc_sr *);
-void bdc_xsf_ep0_data_start(struct bdc *, struct bdc_sr *);
-void bdc_xsf_ep0_status_start(struct bdc *, struct bdc_sr *);
+void bdc_xsf_ep0_setup_recv(struct bdc *bdc, struct bdc_sr *sreport);
+void bdc_xsf_ep0_data_start(struct bdc *bdc, struct bdc_sr *sreport);
+void bdc_xsf_ep0_status_start(struct bdc *bdc, struct bdc_sr *sreport);
#endif /* __LINUX_BDC_H__ */
diff --git a/drivers/usb/gadget/udc/bdc/bdc_cmd.h b/drivers/usb/gadget/udc/bdc/bdc_cmd.h
index a3a6dbd0022c..533ad52fa6d0 100644
--- a/drivers/usb/gadget/udc/bdc/bdc_cmd.h
+++ b/drivers/usb/gadget/udc/bdc/bdc_cmd.h
@@ -10,14 +10,14 @@
#define __LINUX_BDC_CMD_H__
/* Command operations */
-int bdc_address_device(struct bdc *, u32);
-int bdc_config_ep(struct bdc *, struct bdc_ep *);
-int bdc_dconfig_ep(struct bdc *, struct bdc_ep *);
-int bdc_stop_ep(struct bdc *, int);
-int bdc_ep_set_stall(struct bdc *, int);
-int bdc_ep_clear_stall(struct bdc *, int);
-int bdc_ep_bla(struct bdc *, struct bdc_ep *, dma_addr_t);
-int bdc_function_wake(struct bdc*, u8);
-int bdc_function_wake_fh(struct bdc*, u8);
+int bdc_address_device(struct bdc *bdc, u32 add);
+int bdc_config_ep(struct bdc *bdc, struct bdc_ep *ep);
+int bdc_dconfig_ep(struct bdc *bdc, struct bdc_ep *ep);
+int bdc_stop_ep(struct bdc *bdc, int epnum);
+int bdc_ep_set_stall(struct bdc *bdc, int epnum);
+int bdc_ep_clear_stall(struct bdc *bdc, int epnum);
+int bdc_ep_bla(struct bdc *bdc, struct bdc_ep *ep, dma_addr_t dma_addr);
+int bdc_function_wake(struct bdc *bdc, u8 intf);
+int bdc_function_wake_fh(struct bdc *bdc, u8 intf);
#endif /* __LINUX_BDC_CMD_H__ */
diff --git a/drivers/usb/gadget/udc/bdc/bdc_dbg.h b/drivers/usb/gadget/udc/bdc/bdc_dbg.h
index 859d588e209d..acd8332f8584 100644
--- a/drivers/usb/gadget/udc/bdc/bdc_dbg.h
+++ b/drivers/usb/gadget/udc/bdc/bdc_dbg.h
@@ -12,10 +12,10 @@
#include "bdc.h"
#ifdef CONFIG_USB_GADGET_VERBOSE
-void bdc_dbg_bd_list(struct bdc *, struct bdc_ep*);
-void bdc_dbg_srr(struct bdc *, u32);
-void bdc_dbg_regs(struct bdc *);
-void bdc_dump_epsts(struct bdc *);
+void bdc_dbg_bd_list(struct bdc *bdc, struct bdc_ep *ep);
+void bdc_dbg_srr(struct bdc *bdc, u32 srr_num);
+void bdc_dbg_regs(struct bdc *bdc);
+void bdc_dump_epsts(struct bdc *bdc);
#else
static inline void bdc_dbg_regs(struct bdc *bdc)
{ }
diff --git a/drivers/usb/gadget/udc/bdc/bdc_ep.h b/drivers/usb/gadget/udc/bdc/bdc_ep.h
index 5bbd73f99c6f..4d3affd07a65 100644
--- a/drivers/usb/gadget/udc/bdc/bdc_ep.h
+++ b/drivers/usb/gadget/udc/bdc/bdc_ep.h
@@ -9,9 +9,9 @@
#ifndef __LINUX_BDC_EP_H__
#define __LINUX_BDC_EP_H__
-int bdc_init_ep(struct bdc *);
-int bdc_ep_disable(struct bdc_ep *);
-int bdc_ep_enable(struct bdc_ep *);
-void bdc_free_ep(struct bdc *);
+int bdc_init_ep(struct bdc *bdc);
+int bdc_ep_disable(struct bdc_ep *ep);
+int bdc_ep_enable(struct bdc_ep *ep);
+void bdc_free_ep(struct bdc *bdc);
#endif /* __LINUX_BDC_EP_H__ */
--
2.18.0
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH RESEND v4 07/11] usb: gadget: bdc: avoid precedence issues
2021-01-13 2:42 [PATCH RESEND v4 01/11] usb: gadget: bdc: fix improper SPDX comment style for header file Chunfeng Yun
` (4 preceding siblings ...)
2021-01-13 2:42 ` [PATCH RESEND v4 06/11] usb: gadget: bdc: add identifier name for function declaraion Chunfeng Yun
@ 2021-01-13 2:42 ` Chunfeng Yun
2021-01-13 8:44 ` Felipe Balbi
2021-01-13 2:42 ` [PATCH RESEND v4 08/11] usb: gadget: bdc: use the BIT macro to define bit filed Chunfeng Yun
` (4 subsequent siblings)
10 siblings, 1 reply; 23+ messages in thread
From: Chunfeng Yun @ 2021-01-13 2:42 UTC (permalink / raw)
To: Felipe Balbi
Cc: Florian Fainelli, Al Cooper, Greg Kroah-Hartman,
Matthias Brugger, linux-usb, bcm-kernel-feedback-list,
linux-kernel, linux-arm-kernel, linux-mediatek, Chunfeng Yun
Add () around macro argument to avoid precedence issues
Cc: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
---
v4 resend: base on kernel 5.11-rc1
v4: no changes, but rebase on kernel 5.10-rc1
v3: add acked-by Florian
v2: add Cc Florian
---
drivers/usb/gadget/udc/bdc/bdc.h | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/gadget/udc/bdc/bdc.h b/drivers/usb/gadget/udc/bdc/bdc.h
index 658abeff59d4..f8d595804258 100644
--- a/drivers/usb/gadget/udc/bdc/bdc.h
+++ b/drivers/usb/gadget/udc/bdc/bdc.h
@@ -86,20 +86,20 @@
#define BDC_EPSTS5 0x74
#define BDC_EPSTS6 0x78
#define BDC_EPSTS7 0x7c
-#define BDC_SRRBAL(n) (0x200 + (n * 0x10))
-#define BDC_SRRBAH(n) (0x204 + (n * 0x10))
-#define BDC_SRRINT(n) (0x208 + (n * 0x10))
-#define BDC_INTCTLS(n) (0x20c + (n * 0x10))
+#define BDC_SRRBAL(n) (0x200 + ((n) * 0x10))
+#define BDC_SRRBAH(n) (0x204 + ((n) * 0x10))
+#define BDC_SRRINT(n) (0x208 + ((n) * 0x10))
+#define BDC_INTCTLS(n) (0x20c + ((n) * 0x10))
/* Extended capability regs */
#define BDC_FSCNOC 0xcd4
#define BDC_FSCNIC 0xce4
-#define NUM_NCS(p) (p >> 28)
+#define NUM_NCS(p) ((p) >> 28)
/* Register bit fields and Masks */
/* BDC Configuration 0 */
#define BDC_PGS(p) (((p) & (0x7 << 8)) >> 8)
-#define BDC_SPB(p) (p & 0x7)
+#define BDC_SPB(p) ((p) & 0x7)
/* BDC Capability1 */
#define BDC_P64 (1 << 0)
@@ -113,7 +113,7 @@
#define BDC_CMD_DVC 0x1
#define BDC_CMD_CWS (0x1 << 5)
#define BDC_CMD_CST(p) (((p) & (0xf << 6))>>6)
-#define BDC_CMD_EPN(p) ((p & 0x1f) << 10)
+#define BDC_CMD_EPN(p) (((p) & 0x1f) << 10)
#define BDC_SUB_CMD_ADD (0x1 << 17)
#define BDC_SUB_CMD_FWK (0x4 << 17)
/* Reset sequence number */
@@ -163,7 +163,7 @@
#define BDC_SPEED_HS 0x3
#define BDC_SPEED_SS 0x4
-#define BDC_PST(p) (p & 0xf)
+#define BDC_PST(p) ((p) & 0xf)
#define BDC_PST_MASK 0xf
/* USPPMS */
@@ -228,7 +228,7 @@
/* status report defines */
#define SR_XSF 0
#define SR_USPC 4
-#define SR_BD_LEN(p) (p & 0xffffff)
+#define SR_BD_LEN(p) ((p) & 0xffffff)
#define XSF_SUCC 0x1
#define XSF_SHORT 0x3
--
2.18.0
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH RESEND v4 08/11] usb: gadget: bdc: use the BIT macro to define bit filed
2021-01-13 2:42 [PATCH RESEND v4 01/11] usb: gadget: bdc: fix improper SPDX comment style for header file Chunfeng Yun
` (5 preceding siblings ...)
2021-01-13 2:42 ` [PATCH RESEND v4 07/11] usb: gadget: bdc: avoid precedence issues Chunfeng Yun
@ 2021-01-13 2:42 ` Chunfeng Yun
2021-01-13 5:30 ` kernel test robot
2021-01-13 8:44 ` Felipe Balbi
2021-01-13 2:42 ` [PATCH RESEND v4 09/11] usb: gadget: bdc: fix checkpatch.pl tab warning Chunfeng Yun
` (3 subsequent siblings)
10 siblings, 2 replies; 23+ messages in thread
From: Chunfeng Yun @ 2021-01-13 2:42 UTC (permalink / raw)
To: Felipe Balbi
Cc: Florian Fainelli, Al Cooper, Greg Kroah-Hartman,
Matthias Brugger, linux-usb, bcm-kernel-feedback-list,
linux-kernel, linux-arm-kernel, linux-mediatek, Chunfeng Yun
Prefer using the BIT macro to define bit fileds
Cc: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
---
v4 resend: base on kernel 5.11-rc1
v4: no changes, but rebase on kernel 5.10-rc1
v3: add acked-by Florian
v2: add Cc Florian
---
drivers/usb/gadget/udc/bdc/bdc.h | 84 ++++++++++++++++----------------
1 file changed, 42 insertions(+), 42 deletions(-)
diff --git a/drivers/usb/gadget/udc/bdc/bdc.h b/drivers/usb/gadget/udc/bdc/bdc.h
index f8d595804258..8d00b1239f21 100644
--- a/drivers/usb/gadget/udc/bdc/bdc.h
+++ b/drivers/usb/gadget/udc/bdc/bdc.h
@@ -102,7 +102,7 @@
#define BDC_SPB(p) ((p) & 0x7)
/* BDC Capability1 */
-#define BDC_P64 (1 << 0)
+#define BDC_P64 BIT(0)
/* BDC Command register */
#define BDC_CMD_FH 0xe
@@ -111,7 +111,7 @@
#define BDC_CMD_BLA 0x3
#define BDC_CMD_EPC 0x2
#define BDC_CMD_DVC 0x1
-#define BDC_CMD_CWS (0x1 << 5)
+#define BDC_CMD_CWS BIT(5)
#define BDC_CMD_CST(p) (((p) & (0xf << 6))>>6)
#define BDC_CMD_EPN(p) (((p) & 0x1f) << 10)
#define BDC_SUB_CMD_ADD (0x1 << 17)
@@ -124,7 +124,7 @@
#define BDC_SUB_CMD_EP_STP (0x2 << 17)
#define BDC_SUB_CMD_EP_STL (0x4 << 17)
#define BDC_SUB_CMD_EP_RST (0x1 << 17)
-#define BDC_CMD_SRD (1 << 27)
+#define BDC_CMD_SRD BIT(27)
/* CMD completion status */
#define BDC_CMDS_SUCC 0x1
@@ -141,19 +141,19 @@
#define EPM_SHIFT 4
/* BDC USPSC */
-#define BDC_VBC (1 << 31)
-#define BDC_PRC (1 << 30)
-#define BDC_PCE (1 << 29)
-#define BDC_CFC (1 << 28)
-#define BDC_PCC (1 << 27)
-#define BDC_PSC (1 << 26)
-#define BDC_VBS (1 << 25)
-#define BDC_PRS (1 << 24)
-#define BDC_PCS (1 << 23)
+#define BDC_VBC BIT(31)
+#define BDC_PRC BIT(30)
+#define BDC_PCE BIT(29)
+#define BDC_CFC BIT(28)
+#define BDC_PCC BIT(27)
+#define BDC_PSC BIT(26)
+#define BDC_VBS BIT(25)
+#define BDC_PRS BIT(24)
+#define BDC_PCS BIT(23)
#define BDC_PSP(p) (((p) & (0x7 << 20))>>20)
-#define BDC_SCN (1 << 8)
-#define BDC_SDC (1 << 7)
-#define BDC_SWS (1 << 4)
+#define BDC_SCN BIT(8)
+#define BDC_SDC BIT(7)
+#define BDC_SWS BIT(4)
#define BDC_USPSC_RW (BDC_SCN|BDC_SDC|BDC_SWS|0xf)
#define BDC_PSP(p) (((p) & (0x7 << 20))>>20)
@@ -167,17 +167,17 @@
#define BDC_PST_MASK 0xf
/* USPPMS */
-#define BDC_U2E (0x1 << 31)
-#define BDC_U1E (0x1 << 30)
-#define BDC_U2A (0x1 << 29)
-#define BDC_PORT_W1S (0x1 << 17)
+#define BDC_U2E BIT(31)
+#define BDC_U1E BIT(30)
+#define BDC_U2A BIT(29)
+#define BDC_PORT_W1S BIT(17)
#define BDC_U1T(p) ((p) & 0xff)
#define BDC_U2T(p) (((p) & 0xff) << 8)
#define BDC_U1T_MASK 0xff
/* USBPM2 */
/* Hardware LPM Enable */
-#define BDC_HLE (1 << 16)
+#define BDC_HLE BIT(16)
/* BDC Status and Control */
#define BDC_COP_RST (1 << 29)
@@ -186,11 +186,11 @@
#define BDC_COP_MASK (BDC_COP_RST|BDC_COP_RUN|BDC_COP_STP)
-#define BDC_COS (1 << 28)
+#define BDC_COS BIT(28)
#define BDC_CSTS(p) (((p) & (0x7 << 20)) >> 20)
-#define BDC_MASK_MCW (1 << 7)
-#define BDC_GIE (1 << 1)
-#define BDC_GIP (1 << 0)
+#define BDC_MASK_MCW BIT(7)
+#define BDC_GIE BIT(1)
+#define BDC_GIP BIT(0)
#define BDC_HLT 1
#define BDC_NOR 2
@@ -201,19 +201,19 @@
#define BD_CHAIN 0xf
#define BD_TFS_SHIFT 4
-#define BD_SOT (1 << 26)
-#define BD_EOT (1 << 27)
-#define BD_ISP (1 << 29)
-#define BD_IOC (1 << 30)
-#define BD_SBF (1 << 31)
+#define BD_SOT BIT(26)
+#define BD_EOT BIT(27)
+#define BD_ISP BIT(29)
+#define BD_IOC BIT(30)
+#define BD_SBF BIT(31)
#define BD_INTR_TARGET(p) (((p) & 0x1f) << 27)
-#define BDC_SRR_RWS (1 << 4)
-#define BDC_SRR_RST (1 << 3)
-#define BDC_SRR_ISR (1 << 2)
-#define BDC_SRR_IE (1 << 1)
-#define BDC_SRR_IP (1 << 0)
+#define BDC_SRR_RWS BIT(4)
+#define BDC_SRR_RST BIT(3)
+#define BDC_SRR_ISR BIT(2)
+#define BDC_SRR_IE BIT(1)
+#define BDC_SRR_IP BIT(0)
#define BDC_SRR_EPI(p) (((p) & (0xff << 24)) >> 24)
#define BDC_SRR_DPI(p) (((p) & (0xff << 16)) >> 16)
#define BDC_SRR_DPI_MASK 0x00ff0000
@@ -221,7 +221,7 @@
#define MARK_CHAIN_BD (BD_CHAIN|BD_EOT|BD_SOT)
/* Control transfer BD specific fields */
-#define BD_DIR_IN (1 << 25)
+#define BD_DIR_IN BIT(25)
#define BDC_PTC_MASK 0xf0000000
@@ -241,13 +241,13 @@
/* Transfer BD fields */
#define BD_LEN(p) ((p) & 0x1ffff)
-#define BD_LTF (1 << 25)
+#define BD_LTF BIT(25)
#define BD_TYPE_DS 0x1
#define BD_TYPE_SS 0x2
-#define BDC_EP_ENABLED (1 << 0)
-#define BDC_EP_STALL (1 << 1)
-#define BDC_EP_STOP (1 << 2)
+#define BDC_EP_ENABLED BIT(0)
+#define BDC_EP_STALL BIT(1)
+#define BDC_EP_STOP BIT(2)
/* One BD can transfer max 65536 bytes */
#define BD_MAX_BUFF_SIZE (1 << 16)
@@ -266,9 +266,9 @@
/* FUNCTION WAKE DEV NOTIFICATION interval, USB3 spec table 8.13 */
#define BDC_TNOTIFY 2500 /*in ms*/
/* Devstatus bitfields */
-#define REMOTE_WAKEUP_ISSUED (1 << 16)
-#define DEVICE_SUSPENDED (1 << 17)
-#define FUNC_WAKE_ISSUED (1 << 18)
+#define REMOTE_WAKEUP_ISSUED BIT(16)
+#define DEVICE_SUSPENDED BIT(17)
+#define FUNC_WAKE_ISSUED BIT(18)
#define REMOTE_WAKE_ENABLE (1 << USB_DEVICE_REMOTE_WAKEUP)
/* On disconnect, preserve these bits and clear rest */
--
2.18.0
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH RESEND v4 09/11] usb: gadget: bdc: fix checkpatch.pl tab warning
2021-01-13 2:42 [PATCH RESEND v4 01/11] usb: gadget: bdc: fix improper SPDX comment style for header file Chunfeng Yun
` (6 preceding siblings ...)
2021-01-13 2:42 ` [PATCH RESEND v4 08/11] usb: gadget: bdc: use the BIT macro to define bit filed Chunfeng Yun
@ 2021-01-13 2:42 ` Chunfeng Yun
2021-01-13 8:46 ` Felipe Balbi
2021-01-13 2:42 ` [PATCH RESEND v4 10/11] usb: gadget: bdc: fix checkpatch.pl spacing error Chunfeng Yun
` (2 subsequent siblings)
10 siblings, 1 reply; 23+ messages in thread
From: Chunfeng Yun @ 2021-01-13 2:42 UTC (permalink / raw)
To: Felipe Balbi
Cc: Florian Fainelli, Al Cooper, Greg Kroah-Hartman,
Matthias Brugger, linux-usb, bcm-kernel-feedback-list,
linux-kernel, linux-arm-kernel, linux-mediatek, Chunfeng Yun
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements
WARNING:TABSTOP: Statements should start on a tabstop
Cc: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
---
v4 resend: base on kernel 5.11-rc1
v4: no changes, but rebase on kernel 5.10-rc1
v3: add acked-by Florian
v2: add Cc Florian
---
drivers/usb/gadget/udc/bdc/bdc_cmd.c | 2 +-
drivers/usb/gadget/udc/bdc/bdc_ep.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/gadget/udc/bdc/bdc_cmd.c b/drivers/usb/gadget/udc/bdc/bdc_cmd.c
index 44c2a5eef785..995f79c79f96 100644
--- a/drivers/usb/gadget/udc/bdc/bdc_cmd.c
+++ b/drivers/usb/gadget/udc/bdc/bdc_cmd.c
@@ -163,7 +163,7 @@ int bdc_config_ep(struct bdc *bdc, struct bdc_ep *ep)
usb_endpoint_xfer_isoc(desc)) {
param2 |= si;
if (usb_endpoint_xfer_isoc(desc) && comp_desc)
- mul = comp_desc->bmAttributes;
+ mul = comp_desc->bmAttributes;
}
param2 |= mul << EPM_SHIFT;
diff --git a/drivers/usb/gadget/udc/bdc/bdc_ep.c b/drivers/usb/gadget/udc/bdc/bdc_ep.c
index 3fb36c8454fc..d227d2682dd8 100644
--- a/drivers/usb/gadget/udc/bdc/bdc_ep.c
+++ b/drivers/usb/gadget/udc/bdc/bdc_ep.c
@@ -275,7 +275,7 @@ static inline int find_end_bdi(struct bdc_ep *ep, int next_hwd_bdi)
end_bdi = next_hwd_bdi - 1;
if (end_bdi < 0)
end_bdi = ep->bd_list.max_bdi - 1;
- else if ((end_bdi % (ep->bd_list.num_bds_table-1)) == 0)
+ else if ((end_bdi % (ep->bd_list.num_bds_table-1)) == 0)
end_bdi--;
return end_bdi;
@@ -795,7 +795,7 @@ static int ep_dequeue(struct bdc_ep *ep, struct bdc_req *req)
start_pending = true;
end_pending = true;
} else if (end_bdi >= curr_hw_dqpi || end_bdi <= eqp_bdi) {
- end_pending = true;
+ end_pending = true;
}
} else {
if (start_bdi >= curr_hw_dqpi) {
--
2.18.0
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH RESEND v4 10/11] usb: gadget: bdc: fix checkpatch.pl spacing error
2021-01-13 2:42 [PATCH RESEND v4 01/11] usb: gadget: bdc: fix improper SPDX comment style for header file Chunfeng Yun
` (7 preceding siblings ...)
2021-01-13 2:42 ` [PATCH RESEND v4 09/11] usb: gadget: bdc: fix checkpatch.pl tab warning Chunfeng Yun
@ 2021-01-13 2:42 ` Chunfeng Yun
2021-01-13 8:46 ` Felipe Balbi
2021-01-13 2:42 ` [PATCH RESEND v4 11/11] usb: gadget: bdc: fix checkpatch.pl repeated word warning Chunfeng Yun
2021-01-13 8:40 ` [PATCH RESEND v4 01/11] usb: gadget: bdc: fix improper SPDX comment style for header file Felipe Balbi
10 siblings, 1 reply; 23+ messages in thread
From: Chunfeng Yun @ 2021-01-13 2:42 UTC (permalink / raw)
To: Felipe Balbi
Cc: Florian Fainelli, Al Cooper, Greg Kroah-Hartman,
Matthias Brugger, linux-usb, bcm-kernel-feedback-list,
linux-kernel, linux-arm-kernel, linux-mediatek, Chunfeng Yun
fix checkpatch.pl error:
ERROR:SPACING: space prohibited before that ','
Cc: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
---
v4 resend: base on kernel 5.11-rc1
v4: no changes, but rebase on kernel 5.10-rc1
v3: add acked-by Florian
v2: add Cc Florian
---
drivers/usb/gadget/udc/bdc/bdc_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/bdc/bdc_udc.c b/drivers/usb/gadget/udc/bdc/bdc_udc.c
index 0c1ab9548786..5ac0ef88334e 100644
--- a/drivers/usb/gadget/udc/bdc/bdc_udc.c
+++ b/drivers/usb/gadget/udc/bdc/bdc_udc.c
@@ -530,7 +530,7 @@ int bdc_udc_init(struct bdc *bdc)
bdc->gadget.name = BRCM_BDC_NAME;
ret = devm_request_irq(bdc->dev, bdc->irq, bdc_udc_interrupt,
- IRQF_SHARED , BRCM_BDC_NAME, bdc);
+ IRQF_SHARED, BRCM_BDC_NAME, bdc);
if (ret) {
dev_err(bdc->dev,
"failed to request irq #%d %d\n",
--
2.18.0
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH RESEND v4 11/11] usb: gadget: bdc: fix checkpatch.pl repeated word warning
2021-01-13 2:42 [PATCH RESEND v4 01/11] usb: gadget: bdc: fix improper SPDX comment style for header file Chunfeng Yun
` (8 preceding siblings ...)
2021-01-13 2:42 ` [PATCH RESEND v4 10/11] usb: gadget: bdc: fix checkpatch.pl spacing error Chunfeng Yun
@ 2021-01-13 2:42 ` Chunfeng Yun
2021-01-13 8:47 ` Felipe Balbi
2021-01-13 8:40 ` [PATCH RESEND v4 01/11] usb: gadget: bdc: fix improper SPDX comment style for header file Felipe Balbi
10 siblings, 1 reply; 23+ messages in thread
From: Chunfeng Yun @ 2021-01-13 2:42 UTC (permalink / raw)
To: Felipe Balbi
Cc: Florian Fainelli, Al Cooper, Greg Kroah-Hartman,
Matthias Brugger, linux-usb, bcm-kernel-feedback-list,
linux-kernel, linux-arm-kernel, linux-mediatek, Chunfeng Yun
fix the warning:
WARNING:REPEATED_WORD: Possible repeated word: 'and'
Cc: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
---
v4 resend: base on kernel5.11-rc1
v4: no changes, but rebase on kernel 5.10-rc1
v3: add acked-by Florian
v2: add Cc Florian
---
drivers/usb/gadget/udc/bdc/bdc_ep.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/bdc/bdc_ep.c b/drivers/usb/gadget/udc/bdc/bdc_ep.c
index d227d2682dd8..8e2f20b12519 100644
--- a/drivers/usb/gadget/udc/bdc/bdc_ep.c
+++ b/drivers/usb/gadget/udc/bdc/bdc_ep.c
@@ -1405,7 +1405,7 @@ static int ep0_set_sel(struct bdc *bdc,
}
/*
- * Queue a 0 byte bd only if wLength is more than the length and and length is
+ * Queue a 0 byte bd only if wLength is more than the length and length is
* a multiple of MaxPacket then queue 0 byte BD
*/
static int ep0_queue_zlp(struct bdc *bdc)
--
2.18.0
^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [PATCH RESEND v4 08/11] usb: gadget: bdc: use the BIT macro to define bit filed
2021-01-13 2:42 ` [PATCH RESEND v4 08/11] usb: gadget: bdc: use the BIT macro to define bit filed Chunfeng Yun
@ 2021-01-13 5:30 ` kernel test robot
2021-01-13 8:44 ` Felipe Balbi
1 sibling, 0 replies; 23+ messages in thread
From: kernel test robot @ 2021-01-13 5:30 UTC (permalink / raw)
To: Chunfeng Yun, Felipe Balbi
Cc: kbuild-all, Florian Fainelli, Al Cooper, Greg Kroah-Hartman,
Matthias Brugger, linux-usb, bcm-kernel-feedback-list,
linux-kernel, linux-arm-kernel, linux-mediatek
[-- Attachment #1: Type: text/plain, Size: 8355 bytes --]
Hi Chunfeng,
I love your patch! Perhaps something to improve:
[auto build test WARNING on balbi-usb/testing/next]
[also build test WARNING on v5.11-rc3 next-20210112]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Chunfeng-Yun/usb-gadget-bdc-fix-improper-SPDX-comment-style-for-header-file/20210113-105252
base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next
config: x86_64-randconfig-s022-20210113 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-208-g46a52ca4-dirty
# https://github.com/0day-ci/linux/commit/b9301494d83b247a1c4c1ecc892a9f806dde0aaf
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Chunfeng-Yun/usb-gadget-bdc-fix-improper-SPDX-comment-style-for-header-file/20210113-105252
git checkout b9301494d83b247a1c4c1ecc892a9f806dde0aaf
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
"sparse warnings: (new ones prefixed by >>)"
>> drivers/usb/gadget/udc/bdc/bdc_ep.c:498:26: sparse: sparse: cast truncates bits from constant value (ffffffff7fffffff becomes 7fffffff)
vim +498 drivers/usb/gadget/udc/bdc/bdc_ep.c
efed421a94e62a7d Ashwini Pahuja 2014-11-13 423
efed421a94e62a7d Ashwini Pahuja 2014-11-13 424 /* Setup the bd dma descriptor for a given request */
efed421a94e62a7d Ashwini Pahuja 2014-11-13 425 static int setup_bd_list_xfr(struct bdc *bdc, struct bdc_req *req, int num_bds)
efed421a94e62a7d Ashwini Pahuja 2014-11-13 426 {
efed421a94e62a7d Ashwini Pahuja 2014-11-13 427 dma_addr_t buf_add = req->usb_req.dma;
efed421a94e62a7d Ashwini Pahuja 2014-11-13 428 u32 maxp, tfs, dword2, dword3;
efed421a94e62a7d Ashwini Pahuja 2014-11-13 429 struct bd_transfer *bd_xfr;
efed421a94e62a7d Ashwini Pahuja 2014-11-13 430 struct bd_list *bd_list;
efed421a94e62a7d Ashwini Pahuja 2014-11-13 431 struct bdc_ep *ep;
efed421a94e62a7d Ashwini Pahuja 2014-11-13 432 struct bdc_bd *bd;
efed421a94e62a7d Ashwini Pahuja 2014-11-13 433 int ret, bdnum;
efed421a94e62a7d Ashwini Pahuja 2014-11-13 434 u32 req_len;
efed421a94e62a7d Ashwini Pahuja 2014-11-13 435
efed421a94e62a7d Ashwini Pahuja 2014-11-13 436 ep = req->ep;
efed421a94e62a7d Ashwini Pahuja 2014-11-13 437 bd_list = &ep->bd_list;
efed421a94e62a7d Ashwini Pahuja 2014-11-13 438 bd_xfr = &req->bd_xfr;
efed421a94e62a7d Ashwini Pahuja 2014-11-13 439 bd_xfr->req = req;
efed421a94e62a7d Ashwini Pahuja 2014-11-13 440 bd_xfr->start_bdi = bd_list->eqp_bdi;
efed421a94e62a7d Ashwini Pahuja 2014-11-13 441 bd = bdi_to_bd(ep, bd_list->eqp_bdi);
efed421a94e62a7d Ashwini Pahuja 2014-11-13 442 req_len = req->usb_req.length;
cc2e895c604c480b Felipe Balbi 2016-09-28 443 maxp = usb_endpoint_maxp(ep->desc);
efed421a94e62a7d Ashwini Pahuja 2014-11-13 444 tfs = roundup(req->usb_req.length, maxp);
efed421a94e62a7d Ashwini Pahuja 2014-11-13 445 tfs = tfs/maxp;
efed421a94e62a7d Ashwini Pahuja 2014-11-13 446 dev_vdbg(bdc->dev, "%s ep:%s num_bds:%d tfs:%d r_len:%d bd:%p\n",
efed421a94e62a7d Ashwini Pahuja 2014-11-13 447 __func__, ep->name, num_bds, tfs, req_len, bd);
efed421a94e62a7d Ashwini Pahuja 2014-11-13 448
efed421a94e62a7d Ashwini Pahuja 2014-11-13 449 for (bdnum = 0; bdnum < num_bds; bdnum++) {
efed421a94e62a7d Ashwini Pahuja 2014-11-13 450 dword2 = dword3 = 0;
efed421a94e62a7d Ashwini Pahuja 2014-11-13 451 /* First bd */
efed421a94e62a7d Ashwini Pahuja 2014-11-13 452 if (!bdnum) {
efed421a94e62a7d Ashwini Pahuja 2014-11-13 453 dword3 |= BD_SOT|BD_SBF|(tfs<<BD_TFS_SHIFT);
efed421a94e62a7d Ashwini Pahuja 2014-11-13 454 dword2 |= BD_LTF;
efed421a94e62a7d Ashwini Pahuja 2014-11-13 455 /* format of first bd for ep0 is different than other */
016040268ccafaa7 Dan Carpenter 2014-11-29 456 if (ep->ep_num == 1) {
efed421a94e62a7d Ashwini Pahuja 2014-11-13 457 ret = setup_first_bd_ep0(bdc, req, &dword3);
efed421a94e62a7d Ashwini Pahuja 2014-11-13 458 if (ret)
efed421a94e62a7d Ashwini Pahuja 2014-11-13 459 return ret;
efed421a94e62a7d Ashwini Pahuja 2014-11-13 460 }
016040268ccafaa7 Dan Carpenter 2014-11-29 461 }
efed421a94e62a7d Ashwini Pahuja 2014-11-13 462 if (!req->ep->dir)
efed421a94e62a7d Ashwini Pahuja 2014-11-13 463 dword3 |= BD_ISP;
efed421a94e62a7d Ashwini Pahuja 2014-11-13 464
efed421a94e62a7d Ashwini Pahuja 2014-11-13 465 if (req_len > BD_MAX_BUFF_SIZE) {
efed421a94e62a7d Ashwini Pahuja 2014-11-13 466 dword2 |= BD_MAX_BUFF_SIZE;
efed421a94e62a7d Ashwini Pahuja 2014-11-13 467 req_len -= BD_MAX_BUFF_SIZE;
efed421a94e62a7d Ashwini Pahuja 2014-11-13 468 } else {
efed421a94e62a7d Ashwini Pahuja 2014-11-13 469 /* this should be the last bd */
efed421a94e62a7d Ashwini Pahuja 2014-11-13 470 dword2 |= req_len;
efed421a94e62a7d Ashwini Pahuja 2014-11-13 471 dword3 |= BD_IOC;
efed421a94e62a7d Ashwini Pahuja 2014-11-13 472 dword3 |= BD_EOT;
efed421a94e62a7d Ashwini Pahuja 2014-11-13 473 }
efed421a94e62a7d Ashwini Pahuja 2014-11-13 474 /* Currently only 1 INT target is supported */
efed421a94e62a7d Ashwini Pahuja 2014-11-13 475 dword2 |= BD_INTR_TARGET(0);
efed421a94e62a7d Ashwini Pahuja 2014-11-13 476 bd = bdi_to_bd(ep, ep->bd_list.eqp_bdi);
efed421a94e62a7d Ashwini Pahuja 2014-11-13 477 if (unlikely(!bd)) {
efed421a94e62a7d Ashwini Pahuja 2014-11-13 478 dev_err(bdc->dev, "Err bd pointing to wrong addr\n");
efed421a94e62a7d Ashwini Pahuja 2014-11-13 479 return -EINVAL;
efed421a94e62a7d Ashwini Pahuja 2014-11-13 480 }
efed421a94e62a7d Ashwini Pahuja 2014-11-13 481 /* write bd */
efed421a94e62a7d Ashwini Pahuja 2014-11-13 482 bd->offset[0] = cpu_to_le32(lower_32_bits(buf_add));
efed421a94e62a7d Ashwini Pahuja 2014-11-13 483 bd->offset[1] = cpu_to_le32(upper_32_bits(buf_add));
efed421a94e62a7d Ashwini Pahuja 2014-11-13 484 bd->offset[2] = cpu_to_le32(dword2);
efed421a94e62a7d Ashwini Pahuja 2014-11-13 485 bd->offset[3] = cpu_to_le32(dword3);
efed421a94e62a7d Ashwini Pahuja 2014-11-13 486 /* advance eqp pointer */
efed421a94e62a7d Ashwini Pahuja 2014-11-13 487 ep_bdlist_eqp_adv(ep);
efed421a94e62a7d Ashwini Pahuja 2014-11-13 488 /* advance the buff pointer */
efed421a94e62a7d Ashwini Pahuja 2014-11-13 489 buf_add += BD_MAX_BUFF_SIZE;
efed421a94e62a7d Ashwini Pahuja 2014-11-13 490 dev_vdbg(bdc->dev, "buf_add:%08llx req_len:%d bd:%p eqp:%d\n",
efed421a94e62a7d Ashwini Pahuja 2014-11-13 491 (unsigned long long)buf_add, req_len, bd,
efed421a94e62a7d Ashwini Pahuja 2014-11-13 492 ep->bd_list.eqp_bdi);
efed421a94e62a7d Ashwini Pahuja 2014-11-13 493 bd = bdi_to_bd(ep, ep->bd_list.eqp_bdi);
efed421a94e62a7d Ashwini Pahuja 2014-11-13 494 bd->offset[3] = cpu_to_le32(BD_SBF);
efed421a94e62a7d Ashwini Pahuja 2014-11-13 495 }
efed421a94e62a7d Ashwini Pahuja 2014-11-13 496 /* clear the STOP BD fetch bit from the first bd of this xfr */
efed421a94e62a7d Ashwini Pahuja 2014-11-13 497 bd = bdi_to_bd(ep, bd_xfr->start_bdi);
efed421a94e62a7d Ashwini Pahuja 2014-11-13 @498 bd->offset[3] &= cpu_to_le32(~BD_SBF);
efed421a94e62a7d Ashwini Pahuja 2014-11-13 499 /* the new eqp will be next hw dqp */
efed421a94e62a7d Ashwini Pahuja 2014-11-13 500 bd_xfr->num_bds = num_bds;
efed421a94e62a7d Ashwini Pahuja 2014-11-13 501 bd_xfr->next_hwd_bdi = ep->bd_list.eqp_bdi;
efed421a94e62a7d Ashwini Pahuja 2014-11-13 502 /* everything is written correctly before notifying the HW */
efed421a94e62a7d Ashwini Pahuja 2014-11-13 503 wmb();
efed421a94e62a7d Ashwini Pahuja 2014-11-13 504
efed421a94e62a7d Ashwini Pahuja 2014-11-13 505 return 0;
efed421a94e62a7d Ashwini Pahuja 2014-11-13 506 }
efed421a94e62a7d Ashwini Pahuja 2014-11-13 507
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34245 bytes --]
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH RESEND v4 01/11] usb: gadget: bdc: fix improper SPDX comment style for header file
2021-01-13 2:42 [PATCH RESEND v4 01/11] usb: gadget: bdc: fix improper SPDX comment style for header file Chunfeng Yun
` (9 preceding siblings ...)
2021-01-13 2:42 ` [PATCH RESEND v4 11/11] usb: gadget: bdc: fix checkpatch.pl repeated word warning Chunfeng Yun
@ 2021-01-13 8:40 ` Felipe Balbi
10 siblings, 0 replies; 23+ messages in thread
From: Felipe Balbi @ 2021-01-13 8:40 UTC (permalink / raw)
To: Chunfeng Yun
Cc: Florian Fainelli, Al Cooper, Greg Kroah-Hartman,
Matthias Brugger, linux-usb, bcm-kernel-feedback-list,
linux-kernel, linux-arm-kernel, linux-mediatek, Chunfeng Yun
[-- Attachment #1: Type: text/plain, Size: 426 bytes --]
Chunfeng Yun <chunfeng.yun@mediatek.com> writes:
> For C header files Documentation/process/license-rules.rst
> mandates C-like comments (opposed to C source files where
> C++ style should be used).
>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Felipe Balbi <balbi@kernel.org>
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH RESEND v4 02/11] usb: gadget: bdc: remove bdc_ep_set_halt() declaration
2021-01-13 2:42 ` [PATCH RESEND v4 02/11] usb: gadget: bdc: remove bdc_ep_set_halt() declaration Chunfeng Yun
@ 2021-01-13 8:41 ` Felipe Balbi
0 siblings, 0 replies; 23+ messages in thread
From: Felipe Balbi @ 2021-01-13 8:41 UTC (permalink / raw)
To: Chunfeng Yun
Cc: Florian Fainelli, Al Cooper, Greg Kroah-Hartman,
Matthias Brugger, linux-usb, bcm-kernel-feedback-list,
linux-kernel, linux-arm-kernel, linux-mediatek, Chunfeng Yun
[-- Attachment #1: Type: text/plain, Size: 327 bytes --]
Chunfeng Yun <chunfeng.yun@mediatek.com> writes:
> No definition for bdc_ep_set_halt(), so remove it.
>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Felipe Balbi <balbi@kernel.org>
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH RESEND v4 03/11] usb: gadget: bdc: prefer pointer dereference to pointer type
2021-01-13 2:42 ` [PATCH RESEND v4 03/11] usb: gadget: bdc: prefer pointer dereference to pointer type Chunfeng Yun
@ 2021-01-13 8:41 ` Felipe Balbi
0 siblings, 0 replies; 23+ messages in thread
From: Felipe Balbi @ 2021-01-13 8:41 UTC (permalink / raw)
To: Chunfeng Yun
Cc: Florian Fainelli, Al Cooper, Greg Kroah-Hartman,
Matthias Brugger, linux-usb, bcm-kernel-feedback-list,
linux-kernel, linux-arm-kernel, linux-mediatek, Chunfeng Yun
[-- Attachment #1: Type: text/plain, Size: 353 bytes --]
Chunfeng Yun <chunfeng.yun@mediatek.com> writes:
> Prefer kzalloc(sizeof(*bd_table)...) over
> kzalloc(sizeof(struct bd_table)
>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Felipe Balbi <balbi@kernel.org>
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH RESEND v4 04/11] usb: gadget: bdc: fix warning of embedded function name
2021-01-13 2:42 ` [PATCH RESEND v4 04/11] usb: gadget: bdc: fix warning of embedded function name Chunfeng Yun
@ 2021-01-13 8:42 ` Felipe Balbi
0 siblings, 0 replies; 23+ messages in thread
From: Felipe Balbi @ 2021-01-13 8:42 UTC (permalink / raw)
To: Chunfeng Yun
Cc: Florian Fainelli, Al Cooper, Greg Kroah-Hartman,
Matthias Brugger, linux-usb, bcm-kernel-feedback-list,
linux-kernel, linux-arm-kernel, linux-mediatek, Chunfeng Yun
[-- Attachment #1: Type: text/plain, Size: 334 bytes --]
Chunfeng Yun <chunfeng.yun@mediatek.com> writes:
> Use '"%s...", __func__' to replace embedded function name
>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Felipe Balbi <balbi@kernel.org>
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH RESEND v4 05/11] usb: gadget: bdc: fix check warning of block comments alignment
2021-01-13 2:42 ` [PATCH RESEND v4 05/11] usb: gadget: bdc: fix check warning of block comments alignment Chunfeng Yun
@ 2021-01-13 8:43 ` Felipe Balbi
0 siblings, 0 replies; 23+ messages in thread
From: Felipe Balbi @ 2021-01-13 8:43 UTC (permalink / raw)
To: Chunfeng Yun
Cc: Florian Fainelli, Al Cooper, Greg Kroah-Hartman,
Matthias Brugger, linux-usb, bcm-kernel-feedback-list,
linux-kernel, linux-arm-kernel, linux-mediatek, Chunfeng Yun
[-- Attachment #1: Type: text/plain, Size: 379 bytes --]
Chunfeng Yun <chunfeng.yun@mediatek.com> writes:
> fix the warning:
> WARNING:BLOCK_COMMENT_STYLE:
> Block comments should align the * on each line
>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Felipe Balbi <balbi@kernel.org>
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH RESEND v4 06/11] usb: gadget: bdc: add identifier name for function declaraion
2021-01-13 2:42 ` [PATCH RESEND v4 06/11] usb: gadget: bdc: add identifier name for function declaraion Chunfeng Yun
@ 2021-01-13 8:43 ` Felipe Balbi
0 siblings, 0 replies; 23+ messages in thread
From: Felipe Balbi @ 2021-01-13 8:43 UTC (permalink / raw)
To: Chunfeng Yun
Cc: Florian Fainelli, Al Cooper, Greg Kroah-Hartman,
Matthias Brugger, linux-usb, bcm-kernel-feedback-list,
linux-kernel, linux-arm-kernel, linux-mediatek, Chunfeng Yun
[-- Attachment #1: Type: text/plain, Size: 447 bytes --]
Chunfeng Yun <chunfeng.yun@mediatek.com> writes:
> This is used to avoid the warning of function arguments, e.g.
> WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32'
> should also have an identifier name
>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Felipe Balbi <balbi@kernel.org>
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH RESEND v4 07/11] usb: gadget: bdc: avoid precedence issues
2021-01-13 2:42 ` [PATCH RESEND v4 07/11] usb: gadget: bdc: avoid precedence issues Chunfeng Yun
@ 2021-01-13 8:44 ` Felipe Balbi
0 siblings, 0 replies; 23+ messages in thread
From: Felipe Balbi @ 2021-01-13 8:44 UTC (permalink / raw)
To: Chunfeng Yun
Cc: Florian Fainelli, Al Cooper, Greg Kroah-Hartman,
Matthias Brugger, linux-usb, bcm-kernel-feedback-list,
linux-kernel, linux-arm-kernel, linux-mediatek, Chunfeng Yun
[-- Attachment #1: Type: text/plain, Size: 332 bytes --]
Chunfeng Yun <chunfeng.yun@mediatek.com> writes:
> Add () around macro argument to avoid precedence issues
>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Felipe Balbi <balbi@kernel.org>
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH RESEND v4 08/11] usb: gadget: bdc: use the BIT macro to define bit filed
2021-01-13 2:42 ` [PATCH RESEND v4 08/11] usb: gadget: bdc: use the BIT macro to define bit filed Chunfeng Yun
2021-01-13 5:30 ` kernel test robot
@ 2021-01-13 8:44 ` Felipe Balbi
1 sibling, 0 replies; 23+ messages in thread
From: Felipe Balbi @ 2021-01-13 8:44 UTC (permalink / raw)
To: Chunfeng Yun
Cc: Florian Fainelli, Al Cooper, Greg Kroah-Hartman,
Matthias Brugger, linux-usb, bcm-kernel-feedback-list,
linux-kernel, linux-arm-kernel, linux-mediatek, Chunfeng Yun
[-- Attachment #1: Type: text/plain, Size: 324 bytes --]
Chunfeng Yun <chunfeng.yun@mediatek.com> writes:
> Prefer using the BIT macro to define bit fileds
>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Felipe Balbi <balbi@kernel.org>
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH RESEND v4 09/11] usb: gadget: bdc: fix checkpatch.pl tab warning
2021-01-13 2:42 ` [PATCH RESEND v4 09/11] usb: gadget: bdc: fix checkpatch.pl tab warning Chunfeng Yun
@ 2021-01-13 8:46 ` Felipe Balbi
0 siblings, 0 replies; 23+ messages in thread
From: Felipe Balbi @ 2021-01-13 8:46 UTC (permalink / raw)
To: Chunfeng Yun
Cc: Florian Fainelli, Al Cooper, Greg Kroah-Hartman,
Matthias Brugger, linux-usb, bcm-kernel-feedback-list,
linux-kernel, linux-arm-kernel, linux-mediatek, Chunfeng Yun
[-- Attachment #1: Type: text/plain, Size: 409 bytes --]
Chunfeng Yun <chunfeng.yun@mediatek.com> writes:
> WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements
> WARNING:TABSTOP: Statements should start on a tabstop
>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Felipe Balbi <balbi@kernel.org>
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH RESEND v4 10/11] usb: gadget: bdc: fix checkpatch.pl spacing error
2021-01-13 2:42 ` [PATCH RESEND v4 10/11] usb: gadget: bdc: fix checkpatch.pl spacing error Chunfeng Yun
@ 2021-01-13 8:46 ` Felipe Balbi
0 siblings, 0 replies; 23+ messages in thread
From: Felipe Balbi @ 2021-01-13 8:46 UTC (permalink / raw)
To: Chunfeng Yun
Cc: Florian Fainelli, Al Cooper, Greg Kroah-Hartman,
Matthias Brugger, linux-usb, bcm-kernel-feedback-list,
linux-kernel, linux-arm-kernel, linux-mediatek, Chunfeng Yun
[-- Attachment #1: Type: text/plain, Size: 352 bytes --]
Chunfeng Yun <chunfeng.yun@mediatek.com> writes:
> fix checkpatch.pl error:
> ERROR:SPACING: space prohibited before that ','
>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Felipe Balbi <balbi@kernel.org>
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH RESEND v4 11/11] usb: gadget: bdc: fix checkpatch.pl repeated word warning
2021-01-13 2:42 ` [PATCH RESEND v4 11/11] usb: gadget: bdc: fix checkpatch.pl repeated word warning Chunfeng Yun
@ 2021-01-13 8:47 ` Felipe Balbi
0 siblings, 0 replies; 23+ messages in thread
From: Felipe Balbi @ 2021-01-13 8:47 UTC (permalink / raw)
To: Chunfeng Yun
Cc: Florian Fainelli, Al Cooper, Greg Kroah-Hartman,
Matthias Brugger, linux-usb, bcm-kernel-feedback-list,
linux-kernel, linux-arm-kernel, linux-mediatek, Chunfeng Yun
[-- Attachment #1: Type: text/plain, Size: 349 bytes --]
Chunfeng Yun <chunfeng.yun@mediatek.com> writes:
> fix the warning:
> WARNING:REPEATED_WORD: Possible repeated word: 'and'
>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Felipe Balbi <balbi@kernel.org>
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
^ permalink raw reply [flat|nested] 23+ messages in thread
end of thread, other threads:[~2021-01-13 8:48 UTC | newest]
Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-13 2:42 [PATCH RESEND v4 01/11] usb: gadget: bdc: fix improper SPDX comment style for header file Chunfeng Yun
2021-01-13 2:42 ` [PATCH RESEND v4 02/11] usb: gadget: bdc: remove bdc_ep_set_halt() declaration Chunfeng Yun
2021-01-13 8:41 ` Felipe Balbi
2021-01-13 2:42 ` [PATCH RESEND v4 03/11] usb: gadget: bdc: prefer pointer dereference to pointer type Chunfeng Yun
2021-01-13 8:41 ` Felipe Balbi
2021-01-13 2:42 ` [PATCH RESEND v4 04/11] usb: gadget: bdc: fix warning of embedded function name Chunfeng Yun
2021-01-13 8:42 ` Felipe Balbi
2021-01-13 2:42 ` [PATCH RESEND v4 05/11] usb: gadget: bdc: fix check warning of block comments alignment Chunfeng Yun
2021-01-13 8:43 ` Felipe Balbi
2021-01-13 2:42 ` [PATCH RESEND v4 06/11] usb: gadget: bdc: add identifier name for function declaraion Chunfeng Yun
2021-01-13 8:43 ` Felipe Balbi
2021-01-13 2:42 ` [PATCH RESEND v4 07/11] usb: gadget: bdc: avoid precedence issues Chunfeng Yun
2021-01-13 8:44 ` Felipe Balbi
2021-01-13 2:42 ` [PATCH RESEND v4 08/11] usb: gadget: bdc: use the BIT macro to define bit filed Chunfeng Yun
2021-01-13 5:30 ` kernel test robot
2021-01-13 8:44 ` Felipe Balbi
2021-01-13 2:42 ` [PATCH RESEND v4 09/11] usb: gadget: bdc: fix checkpatch.pl tab warning Chunfeng Yun
2021-01-13 8:46 ` Felipe Balbi
2021-01-13 2:42 ` [PATCH RESEND v4 10/11] usb: gadget: bdc: fix checkpatch.pl spacing error Chunfeng Yun
2021-01-13 8:46 ` Felipe Balbi
2021-01-13 2:42 ` [PATCH RESEND v4 11/11] usb: gadget: bdc: fix checkpatch.pl repeated word warning Chunfeng Yun
2021-01-13 8:47 ` Felipe Balbi
2021-01-13 8:40 ` [PATCH RESEND v4 01/11] usb: gadget: bdc: fix improper SPDX comment style for header file Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).