From: Stephen Boyd <swboyd@chromium.org>
To: khsieh@codeaurora.org
Cc: dri-devel@lists.freedesktop.org, robdclark@gmail.com,
sean@poorly.run, tanmay@codeaurora.org, abhinavk@codeaurora.org,
aravindh@codeaurora.org, airlied@linux.ie, daniel@ffwll.ch,
linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] drm/msm/dp: postpone irq_hpd event during connection pending state
Date: Wed, 13 Jan 2021 12:21:17 -0800 [thread overview]
Message-ID: <161056927774.3661239.6186577459996584479@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <17a116011ae60194834210a4a0c877b3@codeaurora.org>
Quoting khsieh@codeaurora.org (2021-01-13 09:44:24)
> On 2021-01-11 11:55, Stephen Boyd wrote:
> > Quoting Kuogee Hsieh (2021-01-07 12:30:24)
> >> irq_hpd event can only be executed at connected state. Therefore
> >> irq_hpd event should be postponed if it happened at connection
> >> pending state. This patch also make sure both link rate and lane
> >
> > Why does it happen at connection pending state?
> plug in need two state to complete it.
> advance to connection pending state once link training completed and
> sent uevent notification to frame work.
> transition to connected state after frame work provided resolution
> timing and start transmit video panel.
> Therefore irq_hpd should not be handled if it occurred before connected
> state.
> >
> >> are valid before start link training.
> >
> > Can this part about link rate and lane being valid be split off into
> > another patch?
> >
> ok, i will spilt this patch into two.
> I will merge irq_hpd event part into 2nd patch (drm/msm/dp: unplug
> interrupt missed after irq_hpd handler).
It looks like Rob already picked this patch up
https://gitlab.freedesktop.org/drm/msm/-/commit/2b5f09cadfc576817c0450e01d454f750909b103
next prev parent reply other threads:[~2021-01-13 20:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 20:30 [PATCH 0/2] *** fix missing unplug interrupt problem *** Kuogee Hsieh
2021-01-07 20:30 ` [PATCH 1/2] drm/msm/dp: postpone irq_hpd event during connection pending state Kuogee Hsieh
2021-01-11 19:55 ` Stephen Boyd
2021-01-13 17:44 ` khsieh
2021-01-13 20:21 ` Stephen Boyd [this message]
2021-01-13 20:22 ` Stephen Boyd
2021-01-13 23:44 ` khsieh
2021-01-14 0:00 ` Stephen Boyd
2021-01-14 17:13 ` khsieh
2021-01-07 20:30 ` [PATCH 2/2] drm/msm/dp: unplug interrupt missed after irq_hpd handler Kuogee Hsieh
2021-01-11 19:54 ` Stephen Boyd
2021-01-13 17:48 ` khsieh
2021-01-13 20:23 ` Stephen Boyd
2021-01-13 23:46 ` khsieh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161056927774.3661239.6186577459996584479@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=abhinavk@codeaurora.org \
--cc=airlied@linux.ie \
--cc=aravindh@codeaurora.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=khsieh@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=tanmay@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).