From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F35BC433DB for ; Tue, 26 Jan 2021 11:24:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B957207B3 for ; Tue, 26 Jan 2021 11:24:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392368AbhAZLYR (ORCPT ); Tue, 26 Jan 2021 06:24:17 -0500 Received: from mx2.suse.de ([195.135.220.15]:42624 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388923AbhAZJBo (ORCPT ); Tue, 26 Jan 2021 04:01:44 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4B70CAC4F; Tue, 26 Jan 2021 09:01:01 +0000 (UTC) Message-ID: <1611651660.11983.64.camel@suse.cz> Subject: Re: [PATCH v2 0/1] AMD EPYC: fix schedutil perf regression (freq-invariance) From: Giovanni Gherdovich To: Peter Zijlstra , Michael Larabel Cc: Borislav Petkov , Ingo Molnar , "Rafael J . Wysocki" , Viresh Kumar , Jon Grimm , Nathan Fontenot , Yazen Ghannam , Thomas Lendacky , Suthikulpanit Suravee , Mel Gorman , Pu Wen , Juri Lelli , Vincent Guittot , Dietmar Eggemann , x86@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Date: Tue, 26 Jan 2021 10:01:00 +0100 In-Reply-To: References: <20210122204038.3238-1-ggherdovich@suse.cz> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.6 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2021-01-25 at 09:34 +0100, Peter Zijlstra wrote: > On Sun, Jan 24, 2021 at 04:30:57PM -0600, Michael Larabel wrote: > > From ongoing tests of this patch, it still certainly shows to address most > > of the Linux 5.11 performance regression previously encountered when using > > Schedutil. Additionally, for a number of workloads where not seeing a > > regression from 5.10 to 5.11 Git is still showing even better performance > > with this patch. The power monitoring on the AMD EPYC server is showing > > higher power spikes but the average power consumption rate is roughly > > comparable to that of Linux 5.11 Git, which is higher than 5.10 by just > > about 3%. > > > > So this patch still seems to be working out well and indeed taking care of > > some wide losses seen otherwise on Linux 5.11 when using Schedutil on AMD > > Zen2/Zen3. Still have some other tests running but so far no unexpected > > results. > > > > Did you do all this writing and forget to add: > > Tested-by: Michael Larabel > > ? Michael confirmed me off-list that yes, the patch should carry the "Tested-by" tag with his name. Giovanni