* [PATCH] [net-next] bonding: add TLS dependency
@ 2021-01-25 11:31 Arnd Bergmann
2021-01-27 1:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2021-01-25 11:31 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski
Cc: Arnd Bergmann, Mauro Carvalho Chehab, Florian Fainelli,
Andrew Lunn, Loic Poulain, Pablo Neira Ayuso, Masahiro Yamada,
Martin Varghese, netdev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
When TLS is a module, the built-in bonding driver may cause a
link error:
x86_64-linux-ld: drivers/net/bonding/bond_main.o: in function `bond_start_xmit':
bond_main.c:(.text+0xc451): undefined reference to `tls_validate_xmit_skb'
Add a dependency to avoid the problem.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
I could not figure out when this started, it seems to have been
possible for a while.
---
drivers/net/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 672fcdd9aecb..45d12b0e9a2f 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -42,6 +42,7 @@ config BONDING
tristate "Bonding driver support"
depends on INET
depends on IPV6 || IPV6=n
+ depends on TLS || TLS_DEVICE=n
help
Say 'Y' or 'M' if you wish to be able to 'bond' multiple Ethernet
Channels together. This is called 'Etherchannel' by Cisco,
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [net-next] bonding: add TLS dependency
2021-01-25 11:31 [PATCH] [net-next] bonding: add TLS dependency Arnd Bergmann
@ 2021-01-27 1:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-01-27 1:50 UTC (permalink / raw)
To: Arnd Bergmann
Cc: davem, kuba, arnd, mchehab+huawei, f.fainelli, andrew,
loic.poulain, pablo, masahiroy, martin.varghese, netdev,
linux-kernel
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Mon, 25 Jan 2021 12:31:59 +0100 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When TLS is a module, the built-in bonding driver may cause a
> link error:
>
> x86_64-linux-ld: drivers/net/bonding/bond_main.o: in function `bond_start_xmit':
> bond_main.c:(.text+0xc451): undefined reference to `tls_validate_xmit_skb'
>
> [...]
Here is the summary with links:
- [net-next] bonding: add TLS dependency
https://git.kernel.org/netdev/net-next/c/285715ac9a81
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-27 4:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-25 11:31 [PATCH] [net-next] bonding: add TLS dependency Arnd Bergmann
2021-01-27 1:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).