From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Mathias Nyman <mathias.nyman@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ikjoon Jang <ikjn@chromium.org>,
<linux-mediatek@lists.infradead.org>, <linux-usb@vger.kernel.org>,
Zhanyong Wang <zhanyong.wang@mediatek.com>,
Tianping Fang <tianping.fang@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6] usb: xhci-mtk: fix unreleased bandwidth data
Date: Wed, 27 Jan 2021 10:14:23 +0800 [thread overview]
Message-ID: <1611713663.3905.19.camel@mhfsdcap03> (raw)
In-Reply-To: <b8a2cd47-ff32-2251-4431-da05a0f038f7@intel.com>
On Tue, 2021-01-26 at 16:27 +0200, Mathias Nyman wrote:
> On 26.1.2021 16.13, Greg Kroah-Hartman wrote:
> > On Wed, Jan 13, 2021 at 06:05:11PM +0800, Ikjoon Jang wrote:
> >> xhci-mtk needs XHCI_MTK_HOST quirk functions in add_endpoint() and
> >> drop_endpoint() to handle its own sw bandwidth management.
> >>
> >> It stores bandwidth data into an internal table every time
> >> add_endpoint() is called, and drops those in drop_endpoint().
> >> But when bandwidth allocation fails at one endpoint, all earlier
> >> allocation from the same interface could still remain at the table.
> >>
> >> This patch moves bandwidth management codes to check_bandwidth() and
> >> reset_bandwidth() path. To do so, this patch also adds those functions
> >> to xhci_driver_overrides and lets mtk-xhci to release all failed
> >> endpoints in reset_bandwidth() path.
> >>
> >> Fixes: 08e469de87a2 ("usb: xhci-mtk: supports bandwidth scheduling with multi-TT")
> >> Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
> >
> > Mathias, any objection to me taking this patch, or do you have others
> > being queued up for 5.11-final?
> >
>
> No objections, haven't tried it out but it looks good to me.
>
> If I finish some additional small fix for 5.11-final I can make it on top of this
Please give me some time to test this patch, thank you
>
> -Mathias
prev parent reply other threads:[~2021-01-27 6:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 10:05 [PATCH v6] usb: xhci-mtk: fix unreleased bandwidth data Ikjoon Jang
2021-01-26 6:02 ` Chunfeng Yun
2021-01-26 14:12 ` Greg Kroah-Hartman
2021-01-27 1:34 ` Chunfeng Yun
2021-01-26 14:13 ` Greg Kroah-Hartman
2021-01-26 14:27 ` Mathias Nyman
2021-01-27 2:14 ` Chunfeng Yun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1611713663.3905.19.camel@mhfsdcap03 \
--to=chunfeng.yun@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=ikjn@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=matthias.bgg@gmail.com \
--cc=tianping.fang@mediatek.com \
--cc=zhanyong.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).