From: Stephen Boyd <swboyd@chromium.org>
To: Enric Balletbo Serra <eballetbo@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>
Subject: Re: [PATCH v3 3/3] iio: proximity: Add a ChromeOS EC MKBP proximity driver
Date: Thu, 28 Jan 2021 09:13:32 -0800 [thread overview]
Message-ID: <161185401247.76967.894387173080815413@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <CAFqH_517Wf42Y4-d+3cgbGh-XC4ujzNnQUaX2kMkF1nJ=v7FuA@mail.gmail.com>
Quoting Enric Balletbo Serra (2021-01-28 01:58:48)
> Missatge de Stephen Boyd <swboyd@chromium.org> del dia dj., 28 de gen.
> 2021 a les 9:48:
> > diff --git a/drivers/iio/proximity/cros_ec_mkbp_proximity.c b/drivers/iio/proximity/cros_ec_mkbp_proximity.c
> > new file mode 100644
> > index 000000000000..c8f33cf11b42
> > --- /dev/null
> > +++ b/drivers/iio/proximity/cros_ec_mkbp_proximity.c
> > @@ -0,0 +1,245 @@
> > + data->notifier.notifier_call = cros_ec_mkbp_proximity_notify;
> > + ret = blocking_notifier_chain_register(&ec->event_notifier,
> > + &data->notifier);
> > + if (ret)
> > + dev_err(dev, "cannot register notifier: %d\n", ret);
> > +
> > + return ret;
>
> blocking_notifier_chain_register always return 0, so the error path
> will never happen, you can simplify this a bit with directly:
>
> return blocking_notifier_chain_register(&ec->event_notifier, &data->notifier);
>
> Other than this minor nit
>
> Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>
Cool thanks! I've rolled it into a v4 but I'll wait a day or so for any
more comments before sending again.
prev parent reply other threads:[~2021-01-28 17:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 8:40 [PATCHv3 0/3] iio: Add a ChromeOS EC MKBP proximity driver Stephen Boyd
2021-01-28 8:40 ` [PATCH v3 1/3] platform/chrome: cros_ec: Add SW_FRONT_PROXIMITY MKBP define Stephen Boyd
2021-01-28 9:23 ` Enric Balletbo Serra
2021-01-28 8:40 ` [PATCH v3 2/3] dt-bindings: iio: Add cros ec proximity yaml doc Stephen Boyd
2021-01-28 9:44 ` Enric Balletbo Serra
2021-01-28 8:40 ` [PATCH v3 3/3] iio: proximity: Add a ChromeOS EC MKBP proximity driver Stephen Boyd
2021-01-28 9:58 ` Enric Balletbo Serra
2021-01-28 17:13 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161185401247.76967.894387173080815413@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=bleung@chromium.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eballetbo@gmail.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).