From: richard.gong@linux.intel.com
To: mdf@kernel.org, trix@redhat.com, gregkh@linuxfoundation.org,
linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Richard Gong <richard.gong@intel.com>
Subject: [PATCHv4 4/6] fpga: of-fpga-region: add authenticate-fpga-config property
Date: Mon, 1 Feb 2021 09:21:57 -0600 [thread overview]
Message-ID: <1612192919-4069-5-git-send-email-richard.gong@linux.intel.com> (raw)
In-Reply-To: <1612192919-4069-1-git-send-email-richard.gong@linux.intel.com>
From: Richard Gong <richard.gong@intel.com>
Add authenticate-fpga-config property to support FPGA bitstream
authentication, which makes sure a signed bitstream has valid signatures.
Signed-off-by: Richard Gong <richard.gong@intel.com>
---
v4: add additional checks to make sure *only* authenticate
v3: no change
v2: changed in alphabetical order
---
drivers/fpga/of-fpga-region.c | 24 +++++++++++++++++-------
1 file changed, 17 insertions(+), 7 deletions(-)
diff --git a/drivers/fpga/of-fpga-region.c b/drivers/fpga/of-fpga-region.c
index e405309..5074479 100644
--- a/drivers/fpga/of-fpga-region.c
+++ b/drivers/fpga/of-fpga-region.c
@@ -218,15 +218,25 @@ static struct fpga_image_info *of_fpga_region_parse_ov(
info->overlay = overlay;
- /* Read FPGA region properties from the overlay */
- if (of_property_read_bool(overlay, "partial-fpga-config"))
- info->flags |= FPGA_MGR_PARTIAL_RECONFIG;
+ /*
+ * Read FPGA region properties from the overlay.
+ *
+ * First check the integrity of the bitstream. If the
+ * authentication is passed, the user can perform other
+ * operations.
+ */
+ if (of_property_read_bool(overlay, "authenticate-fpga-config")) {
+ info->flags |= FPGA_MGR_BITSTREAM_AUTHENTICATE;
+ } else {
+ if (of_property_read_bool(overlay, "partial-fpga-config"))
+ info->flags |= FPGA_MGR_PARTIAL_RECONFIG;
- if (of_property_read_bool(overlay, "external-fpga-config"))
- info->flags |= FPGA_MGR_EXTERNAL_CONFIG;
+ if (of_property_read_bool(overlay, "external-fpga-config"))
+ info->flags |= FPGA_MGR_EXTERNAL_CONFIG;
- if (of_property_read_bool(overlay, "encrypted-fpga-config"))
- info->flags |= FPGA_MGR_ENCRYPTED_BITSTREAM;
+ if (of_property_read_bool(overlay, "encrypted-fpga-config"))
+ info->flags |= FPGA_MGR_ENCRYPTED_BITSTREAM;
+ }
if (!of_property_read_string(overlay, "firmware-name",
&firmware_name)) {
--
2.7.4
next prev parent reply other threads:[~2021-02-01 15:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 15:21 [PATCHv4 0/6] Extend Intel service layer, FPGA manager and region richard.gong
2021-02-01 15:21 ` [PATCHv4 1/6] firmware: stratix10-svc: add COMMAND_AUTHENTICATE_BITSTREAM flag richard.gong
2021-02-01 15:21 ` [PATCHv4 2/6] firmware: stratix10-svc: extend SVC driver to get the firmware version richard.gong
2021-02-01 15:21 ` [PATCHv4 3/6] fpga: fpga-mgr: add FPGA_MGR_BITSTREAM_AUTHENTICATE flag richard.gong
2021-02-01 15:21 ` richard.gong [this message]
2021-02-01 15:21 ` [PATCHv4 5/6] dt-bindings: fpga: add authenticate-fpga-config property richard.gong
2021-02-02 4:27 ` Moritz Fischer
2021-02-02 22:01 ` Richard Gong
2021-02-01 15:21 ` [PATCHv4 6/6] fpga: stratix10-soc: extend driver for bitstream authentication richard.gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1612192919-4069-5-git-send-email-richard.gong@linux.intel.com \
--to=richard.gong@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=richard.gong@intel.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).