From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB04CC433E0 for ; Thu, 4 Feb 2021 00:41:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D6E464DDA for ; Thu, 4 Feb 2021 00:41:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234404AbhBDAlI (ORCPT ); Wed, 3 Feb 2021 19:41:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:36930 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234158AbhBDAkr (ORCPT ); Wed, 3 Feb 2021 19:40:47 -0500 Received: by mail.kernel.org (Postfix) with ESMTPS id A0BB164F6A; Thu, 4 Feb 2021 00:40:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612399206; bh=7KT0nKwSZ3Yg3lZtbd8rwlie3OCVRJWDCy2oOT2/k3c=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=DSr3BvRT2nn3di1mE5uarUbY+9AnbzwG6LCntijvY8XQFd7YSqOGttpSBJ6SejBZ0 17NiNtftkrelRUKEL9kWJUrdIHk7ViMgF0+FY/hEtZ30rIqbGvjcsYm3Jm2JTDcRpj nUKqIlK1zt6nnZA+lyPCinHM3diYXp7bX8288rarKNse5KpERYPbl/+C8zjc/fJs3m DBJ4K4zok1BBPNqJ2nNGm0qo4PmsdtT3lUOjlR6x1j/XAINuDdx0TxTDlKvCBddhXI 8YssgXEmz8Crc+MjbYn40L71f+pyuxSbCBTtreRLsVf3gE9BAPgToloGPdBLKaykNE EPB9OFCFnFziw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] net/qrtr: restrict user-controlled length in qrtr_tun_write_iter() From: patchwork-bot+netdevbpf@kernel.org Message-Id: <161239920659.23511.13237805866635175575.git-patchwork-notify@kernel.org> Date: Thu, 04 Feb 2021 00:40:06 +0000 References: <20210202092059.1361381-1-snovitoll@gmail.com> In-Reply-To: <20210202092059.1361381-1-snovitoll@gmail.com> To: Sabyrzhan Tasbolatov Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+c2a7e5c5211605a90865@syzkaller.appspotmail.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 2 Feb 2021 15:20:59 +0600 you wrote: > syzbot found WARNING in qrtr_tun_write_iter [1] when write_iter length > exceeds KMALLOC_MAX_SIZE causing order >= MAX_ORDER condition. > > Additionally, there is no check for 0 length write. > > [1] > WARNING: mm/page_alloc.c:5011 > [..] > Call Trace: > alloc_pages_current+0x18c/0x2a0 mm/mempolicy.c:2267 > alloc_pages include/linux/gfp.h:547 [inline] > kmalloc_order+0x2e/0xb0 mm/slab_common.c:837 > kmalloc_order_trace+0x14/0x120 mm/slab_common.c:853 > kmalloc include/linux/slab.h:557 [inline] > kzalloc include/linux/slab.h:682 [inline] > qrtr_tun_write_iter+0x8a/0x180 net/qrtr/tun.c:83 > call_write_iter include/linux/fs.h:1901 [inline] > > [...] Here is the summary with links: - net/qrtr: restrict user-controlled length in qrtr_tun_write_iter() https://git.kernel.org/netdev/net/c/2a80c1581237 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html