From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10F92C433E6 for ; Thu, 11 Feb 2021 02:57:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA46C64EBC for ; Thu, 11 Feb 2021 02:56:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229707AbhBKC4p (ORCPT ); Wed, 10 Feb 2021 21:56:45 -0500 Received: from mail.kernel.org ([198.145.29.99]:57018 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229485AbhBKC4l (ORCPT ); Wed, 10 Feb 2021 21:56:41 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2C5C264DBA; Thu, 11 Feb 2021 02:56:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613012161; bh=/IWRxwCmtIxZBUuHS0+t/oVWw89lAGEyoFWFw7vLZNU=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=hp2BHKSigiWBJ4auAFAQ6iKu1WtfeLill9ls1jFg3GuePoSNk9+5tMCIBLdX7k7YG 8fVxmka87bPLRL9+X6MP7N6SjEsYF9h2f8L0ui5MQYMkd6M2xYjQk6opDgHsrliKOn 6JnUmL0g0a8mAdcZdwN13JApKWhjZI/Y6rGQ+Dh584ZQBV2dOqWCPRrDt6/Ep28e+7 CvCNINsSdusnRB61L2Vd1AwbYLWVFiBKy3kjE3uBtATeoiOjQxTb5jWm+2u/2Ge5+s iSetek+wSgfHrYX8SfBMWQfIi6Pz1wbVWiMT0pQhJHgMJT0lJwsKo86VNyEcxdtdtf /qrJrlnE7KCAA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <20201114135044.724385-1-daniel@0x0f.com> <20201114135044.724385-3-daniel@0x0f.com> <160843556037.1580929.13575770228476494246@swboyd.mtv.corp.google.com> <160848984935.1580929.936824086681978646@swboyd.mtv.corp.google.com> <161292417080.418021.13416197091150418216@swboyd.mtv.corp.google.com> Subject: Re: [PATCH 2/6] dt-bindings: clk: mstar msc313 mpll binding description From: Stephen Boyd Cc: DTML , linux-clk@vger.kernel.org, linux-arm-kernel , Linux Kernel Mailing List , Willy Tarreau To: Daniel Palmer Date: Wed, 10 Feb 2021 18:55:59 -0800 Message-ID: <161301215989.1254594.8224717086717364802@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Daniel Palmer (2021-02-10 18:28:40) > Hi Stephen, >=20 > On Wed, 10 Feb 2021 at 11:29, Stephen Boyd wrote: > > The child clks should be using clk_parent_data to point to the parent > > clks through DT. That way the name of the clk doesn't matter except for > > debug purposes. >=20 > I think I get it now. I was using of_clk_parent_fill() to get the > parent clocks sourced > from the mpll but I seems like I should be filling out an array of > struct clk_parent_data > with the indices of the parents and using > clk_register_composite_pdata() etc instead. >=20 Yes that's the idea. Thanks!