* [PATCH] power: supply: cpcap-charger: remove unnecessary conversion to bool
@ 2021-02-25 9:46 Jiapeng Chong
0 siblings, 0 replies; 2+ messages in thread
From: Jiapeng Chong @ 2021-02-25 9:46 UTC (permalink / raw)
To: sre; +Cc: linux-pm, linux-kernel, Jiapeng Chong
Fix the following coccicheck warnings:
./drivers/power/supply/cpcap-charger.c:468:31-36: WARNING: conversion to
bool not needed here.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/power/supply/cpcap-charger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/cpcap-charger.c b/drivers/power/supply/cpcap-charger.c
index 641dcad..0437480 100644
--- a/drivers/power/supply/cpcap-charger.c
+++ b/drivers/power/supply/cpcap-charger.c
@@ -465,7 +465,7 @@ static bool cpcap_charger_vbus_valid(struct cpcap_charger_ddata *ddata)
error = iio_read_channel_processed(channel, &value);
if (error >= 0)
- return value > 3900 ? true : false;
+ return value > 3900;
dev_err(ddata->dev, "error reading VBUS: %i\n", error);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] power: supply: cpcap-charger: Remove unnecessary conversion to bool
@ 2021-03-05 6:56 Jiapeng Chong
0 siblings, 0 replies; 2+ messages in thread
From: Jiapeng Chong @ 2021-03-05 6:56 UTC (permalink / raw)
To: sre; +Cc: linux-pm, linux-kernel, Jiapeng Chong
Fix the following coccicheck warnings:
./drivers/power/supply/cpcap-charger.c:468:31-36: WARNING: conversion to
bool not needed here.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/power/supply/cpcap-charger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/cpcap-charger.c b/drivers/power/supply/cpcap-charger.c
index 641dcad..0437480 100644
--- a/drivers/power/supply/cpcap-charger.c
+++ b/drivers/power/supply/cpcap-charger.c
@@ -465,7 +465,7 @@ static bool cpcap_charger_vbus_valid(struct cpcap_charger_ddata *ddata)
error = iio_read_channel_processed(channel, &value);
if (error >= 0)
- return value > 3900 ? true : false;
+ return value > 3900;
dev_err(ddata->dev, "error reading VBUS: %i\n", error);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-05 6:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-25 9:46 [PATCH] power: supply: cpcap-charger: remove unnecessary conversion to bool Jiapeng Chong
2021-03-05 6:56 [PATCH] power: supply: cpcap-charger: Remove " Jiapeng Chong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).