From: Li Wang <li.wang@windriver.com>
To: <gregkh@linuxfoundation.org>, <jirislaby@kernel.org>,
<andriy.shevchenko@linux.intel.com>, <dmitry.torokhov@gmail.com>,
<linux-kernel@vger.kernel.org>, <li.wang@windriver.com>
Subject: [V2][PATCH] vt: keyboard, fix uninitialized variables warning
Date: Thu, 4 Mar 2021 11:10:48 +0800 [thread overview]
Message-ID: <1614827448-1594-1-git-send-email-li.wang@windriver.com> (raw)
In-Reply-To: <2973260e-2405-5a70-f9bd-398d3d45346e@windriver.com>
drivers/tty/vt/keyboard.c: In function 'vt_do_kdgkb_ioctl':
drivers/tty/vt/keyboard.c: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
return ret;
^~~
drivers/tty/vt/keyboard.c: warning: 'kbs' may be used uninitialized in this function [-Wmaybe-uninitialized]
kfree(kbs);
^~~~~~~~~~
Signed-off-by: Li Wang <li.wang@windriver.com>
---
drivers/tty/vt/keyboard.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/tty/vt/keyboard.c b/drivers/tty/vt/keyboard.c
index 7763862..62f1ecb 100644
--- a/drivers/tty/vt/keyboard.c
+++ b/drivers/tty/vt/keyboard.c
@@ -2090,6 +2090,8 @@ int vt_do_kdgkb_ioctl(int cmd, struct kbsentry __user *user_kdgkb, int perm)
ret = 0;
break;
+ default:
+ return -EINVAL;
}
kfree(kbs);
--
2.7.4
next prev parent reply other threads:[~2021-03-04 4:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 4:59 [PATCH] vt: keyboard, fix uninitialized variables warning Li Wang
2021-03-03 7:14 ` Greg KH
2021-03-03 7:33 ` Wang, Li
2021-03-03 7:39 ` Greg KH
2021-03-03 8:24 ` Andy Shevchenko
2021-03-03 9:21 ` Wang, Li
2021-03-04 3:10 ` Li Wang [this message]
2021-03-04 7:03 ` [V2][PATCH] " Jiri Slaby
2021-03-04 7:04 ` Greg KH
2021-03-04 12:28 ` Andy Shevchenko
2021-03-04 12:30 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1614827448-1594-1-git-send-email-li.wang@windriver.com \
--to=li.wang@windriver.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).