From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDFA2C433E9 for ; Thu, 4 Mar 2021 08:53:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D1DB164F20 for ; Thu, 4 Mar 2021 08:53:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236848AbhCDIwq (ORCPT ); Thu, 4 Mar 2021 03:52:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236841AbhCDIwU (ORCPT ); Thu, 4 Mar 2021 03:52:20 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C970C061574; Thu, 4 Mar 2021 00:51:40 -0800 (PST) Date: Thu, 04 Mar 2021 08:51:34 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1614847896; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZpY9xrjaVQfgAvdH5+f0wRgCrdGcIsGgKyjkDkEdEBA=; b=lJMQXLD2SlxgcawdKsKfqCRfpobCaBn7DvLfMpQtW1mWE1HtEqiL5v/VzENk6pxKc8byzF 7+CMfyWm1pY4lQ9jSmgcY9pRRiabooP7ax36aAhbA9r5k0oJ38U+gd5HhXewDI1OFOAxGi 3sY1qYE1C1T3Eqx3I3aGlJij0Wvq3EIacZFliWZp1eT03Z+dr6IGhMTiicrZZ14gMEuhXN 13FGo8P1X975GxtIy80OP8Bpx9vqggwqXpHY5ee6N1X/gNjIhGBwpbz04EU+wIEDbqFJkI Ov4xs9iKITBl/CQW7U9zGMoHd3iRWti7WLoqVCeHagEV3njkVIULVTXIUiwGmA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1614847896; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZpY9xrjaVQfgAvdH5+f0wRgCrdGcIsGgKyjkDkEdEBA=; b=1u0iuChaDTPke2h95/Gdqa682hVfewhqwoyRtZKUzSbxNx3dZXiG3VMavq5AW/UDbYFVv/ Tx8eNbwkFnmyK/Dw== From: "tip-bot2 for Josh Poimboeuf" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: x86/urgent] x86/unwind/orc: Silence warnings caused by missing ORC data Cc: Josh Poimboeuf , "Peter Zijlstra (Intel)" , Ivan Babrou , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <06d02c4bbb220bd31668db579278b0352538efbb.1612534649.git.jpoimboe@redhat.com> References: <06d02c4bbb220bd31668db579278b0352538efbb.1612534649.git.jpoimboe@redhat.com> MIME-Version: 1.0 Message-ID: <161484789468.398.5338977176281362987.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the x86/urgent branch of tip: Commit-ID: 86402dcc894951c0a363b6aee12d955ff923b35e Gitweb: https://git.kernel.org/tip/86402dcc894951c0a363b6aee12d955ff923b35e Author: Josh Poimboeuf AuthorDate: Fri, 05 Feb 2021 08:24:03 -06:00 Committer: Peter Zijlstra CommitterDate: Wed, 03 Mar 2021 16:56:30 +01:00 x86/unwind/orc: Silence warnings caused by missing ORC data The ORC unwinder attempts to fall back to frame pointers when ORC data is missing for a given instruction. It sets state->error, but then tries to keep going as a best-effort type of thing. That may result in further warnings if the unwinder gets lost. Until we have some way to register generated code with the unwinder, missing ORC will be expected, and occasionally going off the rails will also be expected. So don't warn about it. Signed-off-by: Josh Poimboeuf Signed-off-by: Peter Zijlstra (Intel) Tested-by: Ivan Babrou Link: https://lkml.kernel.org/r/06d02c4bbb220bd31668db579278b0352538efbb.1612534649.git.jpoimboe@redhat.com --- arch/x86/kernel/unwind_orc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/unwind_orc.c b/arch/x86/kernel/unwind_orc.c index 1bcc14c..a120253 100644 --- a/arch/x86/kernel/unwind_orc.c +++ b/arch/x86/kernel/unwind_orc.c @@ -13,7 +13,7 @@ #define orc_warn_current(args...) \ ({ \ - if (state->task == current) \ + if (state->task == current && !state->error) \ orc_warn(args); \ })