linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] scsi: bfa: fix warning comparing pointer to 0
@ 2021-03-16  7:48 Jiapeng Chong
  2021-03-30  3:54 ` Martin K. Petersen
  0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-03-16  7:48 UTC (permalink / raw)
  To: anil.gurumurthy
  Cc: sudarsana.kalluru, jejb, martin.petersen, linux-scsi,
	linux-kernel, Jiapeng Chong

Fix the following coccicheck warning:

./drivers/scsi/bfa/bfad_bsg.c:3412:29-30: WARNING comparing pointer to
0.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/scsi/bfa/bfad_bsg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/bfa/bfad_bsg.c b/drivers/scsi/bfa/bfad_bsg.c
index fc51542..be8dfbe 100644
--- a/drivers/scsi/bfa/bfad_bsg.c
+++ b/drivers/scsi/bfa/bfad_bsg.c
@@ -3409,7 +3409,7 @@
 
 	drv_fcxp->port = fcs_port->bfad_port;
 
-	if (drv_fcxp->port->bfad == 0)
+	if (!drv_fcxp->port->bfad)
 		drv_fcxp->port->bfad = bfad;
 
 	/* Fetch the bfa_rport - if nexus needed */
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] scsi: bfa: fix warning comparing pointer to 0
  2021-03-16  7:48 [PATCH] scsi: bfa: fix warning comparing pointer to 0 Jiapeng Chong
@ 2021-03-30  3:54 ` Martin K. Petersen
  0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2021-03-30  3:54 UTC (permalink / raw)
  To: anil.gurumurthy, Jiapeng Chong
  Cc: Martin K . Petersen, linux-kernel, jejb, linux-scsi, sudarsana.kalluru

On Tue, 16 Mar 2021 15:48:50 +0800, Jiapeng Chong wrote:

> Fix the following coccicheck warning:
> 
> ./drivers/scsi/bfa/bfad_bsg.c:3412:29-30: WARNING comparing pointer to
> 0.

Applied to 5.13/scsi-queue, thanks!

[1/1] scsi: bfa: fix warning comparing pointer to 0
      https://git.kernel.org/mkp/scsi/c/1630e752fb83

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-03-30  3:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-16  7:48 [PATCH] scsi: bfa: fix warning comparing pointer to 0 Jiapeng Chong
2021-03-30  3:54 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).