From: Dan Williams <dan.j.williams@intel.com>
To: linux-cxl@vger.kernel.org
Cc: Ben Widawsky <ben.widawsky@intel.com>,
Jason Gunthorpe <jgg@nvidia.com>,
linux-kernel@vger.kernel.org, vishal.l.verma@intel.com,
ira.weiny@intel.com, alison.schofield@intel.com
Subject: [PATCH v2 0/4] cxl/mem: Fix memdev device setup
Date: Mon, 29 Mar 2021 19:47:39 -0700 [thread overview]
Message-ID: <161707245893.2072157.6743322596719518693.stgit@dwillia2-desk3.amr.corp.intel.com> (raw)
Changes since v1: [1]
- switch percpu_ref to srcu (Jason)
- introduce cxl_memdev_alloc() (Jason)
[1]: http://lore.kernel.org/r/161661970558.1721612.10441826898835759137.stgit@dwillia2-desk3.amr.corp.intel.com
---
A small collection of fixes mostly inspired by Jason's recognition of
dev_set_name() error handling mistakes on other driver review.
dev_set_name() can fail and although device_add() might catch it that's
not a reliable assumption. While fixing that I noticed that the unwind
handling for cdev_device_add() failures leaked the device name.
The sysfs_emit() fixup and unpublishing of device power management files
are just sanity cleanups.
---
Dan Williams (4):
cxl/mem: Use sysfs_emit() for attribute show routines
cxl/mem: Fix synchronization mechanism for device removal vs ioctl operations
cxl/mem: Do not rely on device_add() side effects for dev_set_name() failures
cxl/mem: Disable cxl device power management
drivers/cxl/mem.c | 127 +++++++++++++++++++++++++++++++----------------------
1 file changed, 75 insertions(+), 52 deletions(-)
base-commit: a38fd8748464831584a19438cbb3082b5a2dab15
next reply other threads:[~2021-03-30 2:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 2:47 Dan Williams [this message]
2021-03-30 2:47 ` [PATCH v2 1/4] cxl/mem: Use sysfs_emit() for attribute show routines Dan Williams
2021-03-30 2:47 ` [PATCH v2 2/4] cxl/mem: Fix synchronization mechanism for device removal vs ioctl operations Dan Williams
2021-03-30 11:16 ` Jason Gunthorpe
2021-03-30 15:37 ` Dan Williams
2021-03-30 15:47 ` Jason Gunthorpe
2021-03-30 16:05 ` Dan Williams
2021-03-30 17:02 ` Jason Gunthorpe
2021-03-30 17:31 ` Dan Williams
2021-03-30 17:54 ` Jason Gunthorpe
2021-03-30 19:00 ` Dan Williams
2021-03-30 19:26 ` Jason Gunthorpe
2021-03-30 19:43 ` Dan Williams
2021-03-30 19:51 ` Jason Gunthorpe
2021-03-30 21:00 ` Dan Williams
2021-03-30 22:09 ` Jason Gunthorpe
2021-03-30 2:47 ` [PATCH v2 3/4] cxl/mem: Do not rely on device_add() side effects for dev_set_name() failures Dan Williams
2021-03-30 2:48 ` [PATCH v2 4/4] cxl/mem: Disable cxl device power management Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161707245893.2072157.6743322596719518693.stgit@dwillia2-desk3.amr.corp.intel.com \
--to=dan.j.williams@intel.com \
--cc=alison.schofield@intel.com \
--cc=ben.widawsky@intel.com \
--cc=ira.weiny@intel.com \
--cc=jgg@nvidia.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).