From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAC24C433C1 for ; Tue, 30 Mar 2021 12:08:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D15A60235 for ; Tue, 30 Mar 2021 12:08:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231880AbhC3MH4 (ORCPT ); Tue, 30 Mar 2021 08:07:56 -0400 Received: from mail-m17635.qiye.163.com ([59.111.176.35]:42970 "EHLO mail-m17635.qiye.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231992AbhC3MHn (ORCPT ); Tue, 30 Mar 2021 08:07:43 -0400 Received: from ubuntu.localdomain (unknown [36.152.145.182]) by mail-m17635.qiye.163.com (Hmail) with ESMTPA id A6ACC400123; Tue, 30 Mar 2021 20:07:41 +0800 (CST) From: zhouchuangao To: Jessica Yu , linux-kernel@vger.kernel.org Cc: zhouchuangao Subject: [PATCH] kernel/module: Use BUG_ON instead of if condition followed by BUG. Date: Tue, 30 Mar 2021 05:07:34 -0700 Message-Id: <1617106055-6295-1-git-send-email-zhouchuangao@vivo.com> X-Mailer: git-send-email 2.7.4 X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgYFAkeWUFZS1VLWVdZKFlBSE83V1ktWUFJV1kPCR oVCBIfWUFZSkMYSUNDTB0eSE4eVkpNSkxKS01LTUpMQkpVEwETFhoSFyQUDg9ZV1kWGg8SFR0UWU FZT0tIVUpKS0hKTFVLWQY+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6MTY6CCo6UT8OTzczDxIVUSNL FhUaFApVSlVKTUpMSktNS01JS0pPVTMWGhIXVQETFA4YEw4aFRwaFDsNEg0UVRgUFkVZV1kSC1lB WUhNVUpOSVVKT05VSkNJWVdZCAFZQUpJSUk3Bg++ X-HM-Tid: 0a78830849a3d991kuwsa6acc400123 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It can be optimized at compile time. Signed-off-by: zhouchuangao --- kernel/module.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/module.c b/kernel/module.c index 3047935..f46fc4f 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -1014,8 +1014,8 @@ void __symbol_put(const char *symbol) }; preempt_disable(); - if (!find_symbol(&fsa)) - BUG(); + BUG_ON(!find_symbol(&fsa)); + module_put(fsa.owner); preempt_enable(); } -- 2.7.4