From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16576C433E1 for ; Wed, 31 Mar 2021 04:51:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D85F2619ED for ; Wed, 31 Mar 2021 04:51:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233486AbhCaEut (ORCPT ); Wed, 31 Mar 2021 00:50:49 -0400 Received: from labrats.qualcomm.com ([199.106.110.90]:51991 "EHLO labrats.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231315AbhCaEul (ORCPT ); Wed, 31 Mar 2021 00:50:41 -0400 IronPort-SDR: PfZ6ebAWMII3s2EChd/xHkbGjR9QNpOlR0o+gHyV0kyK9mUsAeRc5a+VBngGi6B+Eq+mIhwFNy eYbZII1VCL8Lquc4whrHWAIXWM+QQqiSee+yrH/cA4Cl9OGddDP6P8UbjH3hIRY8+XON931xum l6QgJ/Z6rpwlta9cx03I1+2gIVr34zgBdJpKIqxpWDDwf1fP8R+/A65kOUvSz3JxBfwE4s/Z9Z JOpt/yK69U7sLI/X4t0TF4FVUTy+Wsf2lISk9cAd1vsQuPSOij1WEJJ1NqJ8Fk3lUqCzO2Cmf9 n/E= X-IronPort-AV: E=Sophos;i="5.81,291,1610438400"; d="scan'208";a="29735581" Received: from unknown (HELO ironmsg02-sd.qualcomm.com) ([10.53.140.142]) by labrats.qualcomm.com with ESMTP; 30 Mar 2021 21:50:40 -0700 X-QCInternal: smtphost Received: from wsp769891wss.qualcomm.com (HELO stor-presley.qualcomm.com) ([192.168.140.85]) by ironmsg02-sd.qualcomm.com with ESMTP; 30 Mar 2021 21:50:40 -0700 Received: by stor-presley.qualcomm.com (Postfix, from userid 359480) id 2F22F21093; Tue, 30 Mar 2021 21:50:40 -0700 (PDT) From: Can Guo To: asutoshd@codeaurora.org, nguyenb@codeaurora.org, hongwus@codeaurora.org, linux-scsi@vger.kernel.org, kernel-team@android.com, cang@codeaurora.org Cc: Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , Stanley Chu , Bean Huo , Jaegeuk Kim , Bart Van Assche , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v4 1/2] scsi: ufs: Fix task management request completion timeout Date: Tue, 30 Mar 2021 21:50:34 -0700 Message-Id: <1617166236-39908-2-git-send-email-cang@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1617166236-39908-1-git-send-email-cang@codeaurora.org> References: <1617166236-39908-1-git-send-email-cang@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ufshcd_tmc_handler() calls blk_mq_tagset_busy_iter(fn = ufshcd_compl_tm()), but since blk_mq_tagset_busy_iter() only iterates over all reserved tags and requests which are not in IDLE state, ufshcd_compl_tm() never gets a chance to run. Thus, TMR always ends up with completion timeout. Fix it by calling blk_mq_start_request() in __ufshcd_issue_tm_cmd(). Fixes: 69a6c269c097 ("scsi: ufs: Use blk_{get,put}_request() to allocate and free TMFs") Signed-off-by: Can Guo --- drivers/scsi/ufs/ufshcd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index b49555fa..d4f8cb2 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -6464,6 +6464,7 @@ static int __ufshcd_issue_tm_cmd(struct ufs_hba *hba, spin_lock_irqsave(host->host_lock, flags); task_tag = hba->nutrs + free_slot; + blk_mq_start_request(req); treq->req_header.dword_0 |= cpu_to_be32(task_tag); -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.