From: Marc Zyngier <maz@kernel.org>
To: Nick Desaulniers <ndesaulniers@google.com>,
Nathan Chancellor <nathan@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Arnd Bergmann <arnd@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com
Subject: Re: [PATCH] irqchip/gic-v3: fix OF_BAD_ADDR error handling
Date: Wed, 7 Apr 2021 13:31:54 +0100 [thread overview]
Message-ID: <161779861852.1095473.3028175861742245454.b4-ty@kernel.org> (raw)
In-Reply-To: <20210323131842.2773094-1-arnd@kernel.org>
On Tue, 23 Mar 2021 14:18:35 +0100, Arnd Bergmann wrote:
> When building with extra warnings enabled, clang points out a
> mistake in the error handling:
>
> drivers/irqchip/irq-gic-v3-mbi.c:306:21: error: result of comparison of constant 18446744073709551615 with expression of type 'phys_addr_t' (aka 'unsigned int') is always false [-Werror,-Wtautological-constant-out-of-range-compare]
> if (mbi_phys_base == OF_BAD_ADDR) {
>
> Truncate the constant to the same type as the variable it gets compared
> to, to shut make the check work and void the warning.
Applied to irq/irqchip-next, thanks!
[1/1] irqchip/gic-v3: fix OF_BAD_ADDR error handling
commit: 8e13d96670a4c050d4883e6743a9e9858e5cfe10
Cheers,
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2021-04-07 12:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 13:18 [PATCH] irqchip/gic-v3: fix OF_BAD_ADDR error handling Arnd Bergmann
2021-03-23 22:06 ` Nick Desaulniers
2021-03-24 10:14 ` Marc Zyngier
2021-03-24 10:55 ` Arnd Bergmann
2021-04-07 12:31 ` Marc Zyngier [this message]
2021-04-07 12:38 ` [irqchip: irq/irqchip-next] irqchip/gic-v3: Fix " irqchip-bot for Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161779861852.1095473.3028175861742245454.b4-ty@kernel.org \
--to=maz@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).