linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Jiri Prchal <jiri.prchal@aksignal.cz>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Christian Eggers <ceggers@arri.de>,
	Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 3/3] nvmem: eeprom: add documentation for FRAM
Date: Fri, 09 Apr 2021 13:57:53 -0500	[thread overview]
Message-ID: <1617994673.262904.3960530.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20210409154720.130902-4-jiri.prchal@aksignal.cz>

On Fri, 09 Apr 2021 17:47:20 +0200, Jiri Prchal wrote:
> Added dt binding documentation.
> 
> Signed-off-by: Jiri Prchal <jiri.prchal@aksignal.cz>
> ---
>  Documentation/devicetree/bindings/eeprom/at25.yaml | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/eeprom/at25.example.dts:40.17-27: Warning (reg_format): /example-0/fram@1:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
Documentation/devicetree/bindings/eeprom/at25.example.dt.yaml: Warning (pci_device_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/eeprom/at25.example.dt.yaml: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/eeprom/at25.example.dt.yaml: Warning (simple_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/eeprom/at25.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/eeprom/at25.example.dt.yaml: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/eeprom/at25.example.dt.yaml: example-0: fram@1:reg:0: [1] is too short
	From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/eeprom/at25.example.dt.yaml: fram@1: $nodename:0: 'fram@1' does not match '^eeprom@[0-9a-f]{1,2}$'
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/eeprom/at25.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/eeprom/at25.example.dt.yaml: fram@1: compatible: 'oneOf' conditional failed, one must be fixed:
	['cypress,fm25'] is too short
	'atmel,at25' was expected
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/eeprom/at25.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/eeprom/at25.example.dt.yaml: fram@1: 'pagesize' is a required property
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/eeprom/at25.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/eeprom/at25.example.dt.yaml: fram@1: 'size' is a required property
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/eeprom/at25.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/eeprom/at25.example.dt.yaml: fram@1: 'address-width' is a required property
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/eeprom/at25.yaml

See https://patchwork.ozlabs.org/patch/1464448

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.


  reply	other threads:[~2021-04-09 18:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-09 15:47 [PATCH 0/3] nvmem: eeprom: add support for FRAM Jiri Prchal
2021-04-09 15:47 ` [PATCH 1/3] nvmem: add things " Jiri Prchal
2021-04-09 15:47 ` [PATCH 2/3] nvmem: eeprom: at25: add support " Jiri Prchal
2021-04-09 18:34   ` kernel test robot
2021-04-09 15:47 ` [PATCH 3/3] nvmem: eeprom: add documentation " Jiri Prchal
2021-04-09 18:57   ` Rob Herring [this message]
2021-04-09 17:21 ` [PATCH 0/3] nvmem: eeprom: add support " Christian Eggers
2021-04-12  6:06   ` Jiří Prchal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1617994673.262904.3960530.nullmailer@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=ceggers@arri.de \
    --cc=devicetree@vger.kernel.org \
    --cc=jiri.prchal@aksignal.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).