linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mikael Pettersson <mikpe@csd.uu.se>
To: Dave Jones <davej@codemonkey.org.uk>
Cc: torvalds@transmeta.com, fxkuehl@gmx.de,
	linux-kernel@vger.kernel.org, willy@w.ods.org,
	marcelo@conectiva.com.br
Subject: Re: [PATCH] Disable APIC on reboot.
Date: Mon, 11 Aug 2003 18:57:42 +0200	[thread overview]
Message-ID: <16183.51974.508883.472043@gargle.gargle.HOWL> (raw)
In-Reply-To: <20030811163834.GA21568@redhat.com>

Dave Jones writes:
 > On Mon, Aug 11, 2003 at 06:29:21PM +0200, Mikael Pettersson wrote:
 >  > I agree we should probably disable the local APIC at reboot if we
 >  > enabled it previously, but this patch is broken. CONFIG_X86_LOCAL_APIC
 >  > doesn't imply that the CPU actually has one, and even if it does, the
 >  > access method may be different (e.g. P5 vs P6/K7/P4, and who knows how
 >  > the future C3 with local APIC will do it).
 > 
 > Ok. The original poster mentioned that disable_local_apic() didn't
 > do the right thing there, hence the duplication, so making that DTRT
 > may make sense ?

I'd have to check what callers expect from disable_local_APIC(), but
having it or a new function do a complete disable seems reasonable.

detect_init_APIC() needs to record whether it did a hard enable via
APIC_BASE or not, and the complete-disable code needs to check this
before accessing APIC_BASE. That + a cpu_has_apic check should do it.

I'll do a patch this evening if no-one else beats me to it.

/Mikael

  reply	other threads:[~2003-08-11 17:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-11 13:40 [PATCH] Disable APIC on reboot davej
2003-08-11 15:33 ` [PATCH-2.4] " Willy Tarreau
2003-08-11 16:29 ` [PATCH] " Mikael Pettersson
2003-08-11 16:38   ` Dave Jones
2003-08-11 16:57     ` Mikael Pettersson [this message]
2003-08-11 23:33       ` [PATCH][2.6.0-test3] " Mikael Pettersson
2003-08-12 13:48         ` Maciej W. Rozycki
2003-08-12 13:57           ` Mikael Pettersson
2003-08-12 14:31             ` Maciej W. Rozycki
2003-08-11 23:33       ` [PATCH][2.4.22-rc2] " Mikael Pettersson
2003-08-12  6:09         ` Willy Tarreau
2003-08-15 19:22         ` Marc-Christian Petersen
2003-08-27  7:19         ` Luca Montecchiani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16183.51974.508883.472043@gargle.gargle.HOWL \
    --to=mikpe@csd.uu.se \
    --cc=davej@codemonkey.org.uk \
    --cc=fxkuehl@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    --cc=torvalds@transmeta.com \
    --cc=willy@w.ods.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).