linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: codec: remove unused variable
@ 2021-04-14  3:24 Jiapeng Chong
  2021-04-14 14:21 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-04-14  3:24 UTC (permalink / raw)
  To: paul
  Cc: lgirdwood, broonie, perex, tiwai, linux-mips, alsa-devel,
	linux-kernel, Jiapeng Chong

Fix the following gcc warning:

sound/soc/codecs/jz4760.c:201:6: warning: variable ‘ret’ set but not
used [-Wunused-but-set-variable].

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 sound/soc/codecs/jz4760.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/sound/soc/codecs/jz4760.c b/sound/soc/codecs/jz4760.c
index e8f28cc..ad5e859 100644
--- a/sound/soc/codecs/jz4760.c
+++ b/sound/soc/codecs/jz4760.c
@@ -198,15 +198,13 @@ static int jz4760_codec_startup(struct snd_pcm_substream *substream,
 {
 	struct snd_soc_component *codec = dai->component;
 	struct snd_soc_dapm_context *dapm = snd_soc_component_get_dapm(codec);
-	int ret;
-
 	/*
 	 * SYSCLK output from the codec to the AIC is required to keep the
 	 * DMA transfer going during playback when all audible outputs have
 	 * been disabled.
 	 */
 	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
-		ret = snd_soc_dapm_force_enable_pin(dapm, "SYSCLK");
+		snd_soc_dapm_force_enable_pin(dapm, "SYSCLK");
 	return 0;
 }
 
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ASoC: codec: remove unused variable
  2021-04-14  3:24 [PATCH] ASoC: codec: remove unused variable Jiapeng Chong
@ 2021-04-14 14:21 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2021-04-14 14:21 UTC (permalink / raw)
  To: Jiapeng Chong
  Cc: paul, alsa-devel, lgirdwood, linux-kernel, linux-mips, tiwai

[-- Attachment #1: Type: text/plain, Size: 284 bytes --]

On Wed, Apr 14, 2021 at 11:24:37AM +0800, Jiapeng Chong wrote:
> Fix the following gcc warning:
> 
> sound/soc/codecs/jz4760.c:201:6: warning: variable ‘ret’ set but not
> used [-Wunused-but-set-variable].

This doesn't apply against current code, please check and resend.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-14 14:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-14  3:24 [PATCH] ASoC: codec: remove unused variable Jiapeng Chong
2021-04-14 14:21 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).