* [PATCH -next] powerpc/mce: Make symbol 'mce_ue_event_work' static
@ 2021-04-08 3:58 Li Huafei
2021-04-19 3:59 ` Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Li Huafei @ 2021-04-08 3:58 UTC (permalink / raw)
To: mpe, benh, paulus, npiggin, ganeshgr, christophe.leroy, mahesh,
clg, santosh
Cc: linuxppc-dev, linux-kernel, yangjihong1, zhangjinhao2, lihuafei1
The sparse tool complains as follows:
arch/powerpc/kernel/mce.c:43:1: warning:
symbol 'mce_ue_event_work' was not declared. Should it be static?
This symbol is not used outside of mce.c, so this commit marks it
static.
Signed-off-by: Li Huafei <lihuafei1@huawei.com>
---
arch/powerpc/kernel/mce.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/mce.c b/arch/powerpc/kernel/mce.c
index 11f0cae086ed..6aa6b1cda1ed 100644
--- a/arch/powerpc/kernel/mce.c
+++ b/arch/powerpc/kernel/mce.c
@@ -40,7 +40,7 @@ static struct irq_work mce_ue_event_irq_work = {
.func = machine_check_ue_irq_work,
};
-DECLARE_WORK(mce_ue_event_work, machine_process_ue_event);
+static DECLARE_WORK(mce_ue_event_work, machine_process_ue_event);
static BLOCKING_NOTIFIER_HEAD(mce_notifier_list);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] powerpc/mce: Make symbol 'mce_ue_event_work' static
2021-04-08 3:58 [PATCH -next] powerpc/mce: Make symbol 'mce_ue_event_work' static Li Huafei
@ 2021-04-19 3:59 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2021-04-19 3:59 UTC (permalink / raw)
To: npiggin, mahesh, benh, mpe, santosh, christophe.leroy, paulus,
Li Huafei, ganeshgr, clg
Cc: yangjihong1, zhangjinhao2, linuxppc-dev, linux-kernel
On Thu, 8 Apr 2021 11:58:02 +0800, Li Huafei wrote:
> The sparse tool complains as follows:
>
> arch/powerpc/kernel/mce.c:43:1: warning:
> symbol 'mce_ue_event_work' was not declared. Should it be static?
>
> This symbol is not used outside of mce.c, so this commit marks it
> static.
Applied to powerpc/next.
[1/1] powerpc/mce: Make symbol 'mce_ue_event_work' static
https://git.kernel.org/powerpc/c/f6f1f48e8b3b242dfa684d6e1b930d239d87533a
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-19 4:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08 3:58 [PATCH -next] powerpc/mce: Make symbol 'mce_ue_event_work' static Li Huafei
2021-04-19 3:59 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).