From: zhiyong tao <zhiyong.tao@mediatek.com>
To: Sean Wang <sean.wang@kernel.org>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
srv_heupstream <srv_heupstream@mediatek.com>,
"Hui Liu (刘辉)" <Hui.Liu@mediatek.com>,
"Eddie Huang (黃智傑)" <eddie.huang@mediatek.com>,
"Po Xu (徐坡)" <ot_po.xu@mediatek.com>,
"Biao Huang (黄彪)" <Biao.Huang@mediatek.com>,
"Hongzhou Yang" <hongzhou.yang@mediatek.com>,
"Sean Wang" <Sean.Wang@mediatek.com>,
"Seiya Wang (王迺君)" <seiya.wang@mediatek.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, lkml <linux-kernel@vger.kernel.org>,
"linux-arm Mailing List" <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v4 4/4] pinctrl: add rsel setting on MT8195
Date: Thu, 22 Apr 2021 10:10:46 +0800 [thread overview]
Message-ID: <1619057446.27999.2.camel@mhfsdcap03> (raw)
In-Reply-To: <CAGp9LzoM=9v5mLxtAN9sQm_2f+66xc7G4YqfUF1Mwvr4K_wz5w@mail.gmail.com>
On Tue, 2021-04-20 at 11:50 +0800, Sean Wang wrote:
> On Mon, Apr 12, 2021 at 10:57 PM Zhiyong Tao <zhiyong.tao@mediatek.com> wrote:
>
> <snip>
> > @@ -176,6 +180,12 @@ static int mtk_pinconf_get(struct pinctrl_dev *pctldev,
> > else
> > err = -ENOTSUPP;
> > break;
> > + case MTK_PIN_CONFIG_RSEL:
> > + if (hw->soc->rsel_get)
> > + err = hw->soc->rsel_get(hw, desc, &ret);
> > + else
> > + err = -EOPNOTSUPP;
>
> I think that should want to be -ENOTSUPP to align other occurrences.
==>Hi sean,
Can you give me some suggestion? -ENOPARAM or -EBADTYPE?
Thanks.
>
> > + break;
> > default:
> > err = -ENOTSUPP;
> > }
> > @@ -295,6 +305,12 @@ static int mtk_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
> > else
> > err = -ENOTSUPP;
> > break;
> > + case MTK_PIN_CONFIG_RSEL:
> > + if (hw->soc->rsel_set)
> > + err = hw->soc->rsel_set(hw, desc, arg);
> > + else
> > + err = -EOPNOTSUPP;
>
> Ditto
>
> > + break;
> > default:
> > err = -ENOTSUPP;
> > }
> > --
> > 2.18.0
> >
next prev parent reply other threads:[~2021-04-22 2:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 5:56 [PATCH v4 0/4] Mediatek pinctrl patch on mt8195 Zhiyong Tao
2021-04-13 5:56 ` [PATCH v4 1/4] dt-bindings: pinctrl: mt8195: add pinctrl file and binding document Zhiyong Tao
2021-04-13 16:28 ` Rob Herring
2021-04-13 5:57 ` [PATCH v4 2/4] pinctrl: add pinctrl driver on mt8195 Zhiyong Tao
2021-04-20 3:46 ` Sean Wang
2021-04-13 5:57 ` [PATCH v4 3/4] pinctrl: add drive for I2C related pins on MT8195 Zhiyong Tao
2021-04-20 3:47 ` Sean Wang
2021-04-13 5:57 ` [PATCH v4 4/4] pinctrl: add rsel setting " Zhiyong Tao
2021-04-20 3:50 ` Sean Wang
2021-04-22 2:10 ` zhiyong tao [this message]
2021-04-21 23:51 ` [PATCH v4 0/4] Mediatek pinctrl patch on mt8195 Linus Walleij
2021-04-22 1:37 ` zhiyong tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1619057446.27999.2.camel@mhfsdcap03 \
--to=zhiyong.tao@mediatek.com \
--cc=Biao.Huang@mediatek.com \
--cc=Hui.Liu@mediatek.com \
--cc=Sean.Wang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=eddie.huang@mediatek.com \
--cc=hongzhou.yang@mediatek.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=ot_po.xu@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@kernel.org \
--cc=seiya.wang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).