From: "irqchip-bot for Randy Dunlap" <tip-bot2@linutronix.de>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>,
Christian Ruppert <christian.ruppert@abilis.com>
Subject: [irqchip: irq/irqchip-next] irqchip/tb10x: Use 'fallthrough' to eliminate a warning
Date: Thu, 22 Apr 2021 13:07:24 -0000 [thread overview]
Message-ID: <161909684492.29796.7954496853919794538.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20210422051620.23021-1-rdunlap@infradead.org>
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: a6992bbe9774e044d3d0f973593d655c53efe089
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/a6992bbe9774e044d3d0f973593d655c53efe089
Author: Randy Dunlap <rdunlap@infradead.org>
AuthorDate: Wed, 21 Apr 2021 22:16:20 -07:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Thu, 22 Apr 2021 13:53:33 +01:00
irqchip/tb10x: Use 'fallthrough' to eliminate a warning
Use the 'fallthrough' macro to document that this switch case
does indeed fall through to the next case.
../drivers/irqchip/irq-tb10x.c: In function 'tb10x_irq_set_type':
../drivers/irqchip/irq-tb10x.c:62:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
62 | flow_type = IRQ_TYPE_LEVEL_LOW;
../drivers/irqchip/irq-tb10x.c:63:2: note: here
63 | case IRQ_TYPE_LEVEL_LOW:
| ^~~~
Fixes: b06eb0173ef1 ("irqchip: Add TB10x interrupt controller driver")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Marc Zyngier <maz@kernel.org>
Cc: Christian Ruppert <christian.ruppert@abilis.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210422051620.23021-1-rdunlap@infradead.org
---
drivers/irqchip/irq-tb10x.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/irq-tb10x.c b/drivers/irqchip/irq-tb10x.c
index 9e45649..9a63b02 100644
--- a/drivers/irqchip/irq-tb10x.c
+++ b/drivers/irqchip/irq-tb10x.c
@@ -60,6 +60,7 @@ static int tb10x_irq_set_type(struct irq_data *data, unsigned int flow_type)
break;
case IRQ_TYPE_NONE:
flow_type = IRQ_TYPE_LEVEL_LOW;
+ fallthrough;
case IRQ_TYPE_LEVEL_LOW:
mod ^= im;
pol ^= im;
prev parent reply other threads:[~2021-04-22 13:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 5:16 [PATCH] irqchip: tb10x: use 'fallthrough' to eliminate a warning Randy Dunlap
2021-04-22 13:07 ` irqchip-bot for Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161909684492.29796.7954496853919794538.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=christian.ruppert@abilis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).